Opened 2 years ago
Closed 2 years ago
#29895 closed enhancement (fixed)
move sage.misc.misc.*verbose* to new module sage.misc.verbose
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  refactoring  Keywords:  
Cc:  chapoton, tscrim, dkrenn, ghmwageringel  Merged in:  
Authors:  Daniel Krenn, Matthias Koeppe  Reviewers:  Travis Scrimshaw, Markus Wageringel 
Report Upstream:  N/A  Work issues:  
Branch:  8d7609e (Commits, GitHub, GitLab)  Commit:  8d7609eac1bebbaca15996a86a587c2c9ffbcc05 
Dependencies:  #29892  Stopgaps: 
Description (last modified by )
The "simple verbosity system" in sage.misc.misc
has 2 global variables, LEVEL
and verbose_files
, which are meant to be internal.
 Access is through functions
verbose
,set_verbose
,set_verbose_files
,get_verbose_files
,unset_verbose_files
,get_verbose
, all of which are imported bysage.misc.all
.
 Only
verbose
andget_verbose
are used in sagelib.
 Additionally,
set_verbose
is used in doctests of sagelib.
We move the functions to a new module sage.misc.verbose
, with lazy_import
and deprecation. This is preparation for #21349, and is also helpful for #29865 (modularization).
We also add some documentation taken from #21349.
We also deprecate the import of verbose
into sage.misc.all
as proposed in #17815.
See also:
Change History (26)
comment:1 Changed 2 years ago by
 Description modified (diff)
comment:2 Changed 2 years ago by
 Cc chapoton tscrim added
 Description modified (diff)
comment:3 Changed 2 years ago by
 Cc dkrenn added
comment:4 Changed 2 years ago by
comment:5 Changed 2 years ago by
 Description modified (diff)
comment:6 Changed 2 years ago by
 Branch set to u/mkoeppe/move_sage_misc_misc__verbose__to_new_module_sage_misc_verbose
comment:7 Changed 2 years ago by
 Commit set to 23636427fb8b083bc06124c6493aa2764d6fbbf8
The branch does not work yet because it the moved functions depend on cputime
from sage.misc.misc
and other missing imports
Last 10 new commits:
a5453bf  Fixup: Add src/sage/misc/call.py

64c5701  lazy_import from sage.misc.call with deprecation

65414f7  Fix imports and one deprecation warning

b9314d4  sage.misc.call: Add standard header information, add to reference manual

6024ffd  src/sage/misc/call.py: register_unpickle_override for call_method

e8ad8d3  sage.misc.verbose: New module

ad01c5f  sage.misc.misc: Move *verbose* to sage.misc.verbose

67f7eb2  sage.misc.all: Import *verbose* from sage.misc.verbose, deprecate import of function verbose

8068325  sage.misc.misc: lazy_import *verbose* with deprecation

2363642  fixup

comment:8 Changed 2 years ago by
 Description modified (diff)
comment:9 Changed 2 years ago by
 Commit changed from 23636427fb8b083bc06124c6493aa2764d6fbbf8 to d8abdb06b865ada8cc7fa306602f9121da64a427
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
68da7f5  replace all of sage.misc.*verbose by sage.verbose.*verbose

55ec500  resolve verbosenameclash

c9eb31d  Replace imports *verbose* from sage.misc.all by imports from sage.misc.verbose

06dcba2  sage.plot.graphics: Use warnings.warn instead of nonexisting sage.misc.misc.warn

210c1a7  sage.plot: Import sage.misc.verbose

8a5e384  Fix remaining imports of *verbose*

5632556  src/sage/modular/modsym/relation_matrix_pyx.pyx: Fixup import

41d42e9  sage.misc.verbose: Fix imports

b3af9e2  sage.misc.verbose: Fix doctest

d8abdb0  Fixup various imports and uses of verbose

comment:10 Changed 2 years ago by
 Status changed from new to needs_review
comment:11 Changed 2 years ago by
 Commit changed from d8abdb06b865ada8cc7fa306602f9121da64a427 to db40fd553880dd48ca94fe4a7554d19205c7270b
Branch pushed to git repo; I updated commit sha1. New commits:
db40fd5  Fix pyflakes warnings regarding imports

comment:12 Changed 2 years ago by
The remaining patchbot plugin warnings are old news. Needs review.
comment:13 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:14 Changed 2 years ago by
Thank you!
comment:15 Changed 2 years ago by
 Commit changed from db40fd553880dd48ca94fe4a7554d19205c7270b to df742b13b3127b42485b99362c1fb2da69de5b37
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
df742b1  Merge tag '9.2.beta3' into t/29895/move_sage_misc_misc__verbose__to_new_module_sage_misc_verbose

comment:16 Changed 2 years ago by
 Status changed from needs_review to positive_review
comment:18 Changed 2 years ago by
 Dependencies set to #29892
comment:19 Changed 2 years ago by
 Commit changed from df742b13b3127b42485b99362c1fb2da69de5b37 to ceaf81749f221d0055e6820108a48a14d41631dd
Branch pushed to git repo; I updated commit sha1. New commits:
3f5b6ea  Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr

08fedfa  src/sage/combinat/root_system/type_dual.py: Remove unused variable to fix pyflakes warning

05efc11  sage.misc.repr.coeff_repr: Add doctest, adapted from sage.misc.latex.coeff_repr

538323b  src/sage/misc/call.py: Fix block syntax in docstring

b5f63a5  src/sage/misc/call.py: Returns should be Return

ceaf817  Merge branch 't/29892/move_sage_misc_misc_coeff_repr__repr_lincomb_to_new_module_sage_misc_repr' into t/29895/move_sage_misc_misc__verbose__to_new_module_sage_misc_verbose

comment:20 Changed 2 years ago by
 Status changed from needs_work to positive_review
Trivial merge to resolve conflict
comment:21 Changed 2 years ago by
 Status changed from positive_review to needs_work
sage t long warnlong 36.6 src/sage/algebras/splitting_algebra.py ********************************************************************** File "src/sage/algebras/splitting_algebra.py", line 56, in sage.algebras.splitting_algebra.SplittingAlgebraElement Failed example: CR6.<e6> = SplittingAlgebra(cp6) Expected nothing Got: doctest:warning File "/home/release/Sage/src/bin/sageruntests", line 177, in <module> err = DC.run() File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/control.py", line 1207, in run self.run_doctests() File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/control.py", line 908, in run_doctests self.dispatcher.dispatch() File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 2038, in dispatch self.parallel_dispatch() File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 1933, in parallel_dispatch w.start() # This might take some time File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 2205, in start super(DocTestWorker, self).start() File "/home/release/Sage/local/lib/python3.7/multiprocessing/process.py", line 112, in start self._popen = self._Popen(self) File "/home/release/Sage/local/lib/python3.7/multiprocessing/context.py", line 223, in _Popen return _default_context.get_context().Process._Popen(process_obj) File "/home/release/Sage/local/lib/python3.7/multiprocessing/context.py", line 277, in _Popen return Popen(process_obj) File "/home/release/Sage/local/lib/python3.7/multiprocessing/popen_fork.py", line 20, in __init__ self._launch(process_obj) File "/home/release/Sage/local/lib/python3.7/multiprocessing/popen_fork.py", line 74, in _launch code = process_obj._bootstrap() File "/home/release/Sage/local/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap self.run() File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 2177, in run task(self.options, self.outtmpfile, msgpipe, self.result_queue) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 2506, in __call__ doctests, extras = self._run(runner, options, results) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 2552, in _run result = runner.run(test) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 905, in run return self._run(test, compileflags, out) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 707, in _run self.compile_and_execute(example, compiler, test.globs) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/doctest/forker.py", line 1131, in compile_and_execute exec(compiled, globs) File "<doctest sage.algebras.splitting_algebra.SplittingAlgebraElement[2]>", line 1, in <module> CR6 = SplittingAlgebra(cp6, names=('e6',)); (e6,) = CR6._first_ngens(1) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/algebras/splitting_algebra.py", line 224, in __init__ % (base_ring, monic_polynomial, iterate, warning)) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/misc/superseded.py", line 100, in deprecation warning(trac_number, message, DeprecationWarning, stacklevel) File "/home/release/Sage/local/lib/python3.7/sitepackages/sage/misc/superseded.py", line 146, in warning warn(message, warning_class, stacklevel) File "/home/release/Sage/local/lib/python3.7/warnings.py", line 110, in _showwarnmsg msg.file, msg.line) : DeprecationWarning: Importing verbose from here is deprecated. If you need to use it, please import it directly from sage.misc.verbose See http://trac.sagemath.org/17815 for details. ********************************************************************** 1 item had failures: 1 of 6 in sage.algebras.splitting_algebra.SplittingAlgebraElement [107 tests, 1 failure, 0.65 s]  sage t long warnlong 36.6 src/sage/algebras/splitting_algebra.py # 1 doctest failed 
comment:22 Changed 2 years ago by
 Commit changed from ceaf81749f221d0055e6820108a48a14d41631dd to 8d7609eac1bebbaca15996a86a587c2c9ffbcc05
Branch pushed to git repo; I updated commit sha1. New commits:
8d7609e  src/sage/algebras/splitting_algebra.py: from sage.misc.verbose import verbose

comment:23 Changed 2 years ago by
 Cc ghmwageringel added
 Status changed from needs_work to needs_review
comment:24 Changed 2 years ago by
 Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Markus Wageringel
 Status changed from needs_review to positive_review
The fix looks good to me and the bot is green.
comment:25 Changed 2 years ago by
Thanks!
comment:26 Changed 2 years ago by
 Branch changed from u/mkoeppe/move_sage_misc_misc__verbose__to_new_module_sage_misc_verbose to 8d7609eac1bebbaca15996a86a587c2c9ffbcc05
 Resolution set to fixed
 Status changed from positive_review to closed
We can reuse some of the commits of #21349 for this ticket.