Opened 2 years ago
Closed 2 years ago
#29885 closed enhancement (fixed)
Remove sagenb from "sage notebook"
Reported by:  John Palmieri  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  scripts  Keywords:  
Cc:  Merged in:  
Authors:  John Palmieri  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  f5853f9 (Commits, GitHub, GitLab)  Commit:  f5853f9be456b0add1c6e9cb82f3f1f1741a5cf4 
Dependencies:  Stopgaps: 
Description
 Remove
sagenb
as a documented argument to thesagenotebook
script, and remove the code to start the SageNB server.  Rewrite the error when
sagenb
is passed as an argument.  Change the default from
SageNBExport
toNotebookJupyter
.
Change History (9)
comment:1 Changed 2 years ago by
Branch:  → u/jhpalmieri/nosagenbinsagenotebook 

comment:2 Changed 2 years ago by
Commit:  → 62bfb51d0ffa48d4c0c80c9faf65995651002790 

Status:  new → needs_review 
comment:3 Changed 2 years ago by
I am okay with this. I would just add something like the last line here:
print('See https://wiki.sagemath.org/Python3Switch') print('Use sage notebook=export to export sagenb notebooks to Jupyter')
comment:4 Changed 2 years ago by
By the way, see #17590 and possibly elsewhere. But since 9.2 will (apparently) not support Py2, perhaps it's indeed better to simply remove sagenb than to keep it as an optional package that can't be launched from the command line.
comment:5 Changed 2 years ago by
Commit:  62bfb51d0ffa48d4c0c80c9faf65995651002790 → f5853f9be456b0add1c6e9cb82f3f1f1741a5cf4 

Branch pushed to git repo; I updated commit sha1. New commits:
f5853f9  trac 29885: add to the error message for "sage n sagenb"

comment:6 followup: 7 Changed 2 years ago by
Here is an expansion of the "sage n sagenb" error message.
comment:7 Changed 2 years ago by
Here is an expansion of the "sage n sagenb" error message.
Thanks. The code looks good, someone who can test the branch should just confirm that this works, and that tests pass  I can imagine some stray doctest somewhere needing the class?
comment:8 Changed 2 years ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → positive_review 
LGTM.
comment:9 Changed 2 years ago by
Branch:  u/jhpalmieri/nosagenbinsagenotebook → f5853f9be456b0add1c6e9cb82f3f1f1741a5cf4 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
trac 29885: sagenotebook: remove sagenb as an option,