Opened 4 months ago
Closed 3 months ago
#29882 closed enhancement (fixed)
Add tutorial-like docstring material on RecursivelyEnumeratedSet
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | combinatorics | Keywords: | |
Cc: | hivert, tscrim, slabbe, nthiery, slelievre | Merged in: | |
Authors: | Florent Hivert, Sébastien Labbé | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 90dc326 (Commits) | Commit: | 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457 |
Dependencies: | Stopgaps: |
Description
... from a forgotten branch on #16351 ...
Change History (11)
comment:1 Changed 4 months ago by
- Branch set to u/hivert/move_searchforest_code_to_sage_sets_recursively_enumerated_set_pyx
- Commit set to 1bf8c97ef9e6479ede07b339b11d413819508307
comment:2 Changed 4 months ago by
- Cc slelievre added
comment:3 Changed 4 months ago by
- Branch changed from u/hivert/move_searchforest_code_to_sage_sets_recursively_enumerated_set_pyx to public/29882
- Commit changed from 1bf8c97ef9e6479ede07b339b11d413819508307 to 8b9869fd278b20a9bce6b662d8189eb5f79f3b5c
- Status changed from new to needs_review
comment:4 Changed 4 months ago by
Note that I rebased old Florent Hivert's commit on top of 9.2.beta1 (new commit hash is cb48f33).
comment:5 Changed 4 months ago by
- Commit changed from 8b9869fd278b20a9bce6b662d8189eb5f79f3b5c to b44aac221c1fe6ddc86c859e53d7c9ad7747bc2c
comment:6 Changed 4 months ago by
- Reviewers set to Travis Scrimshaw
I made a few small changes to try and improve the exposition. If my changes are good, then positive review.
comment:7 Changed 3 months ago by
- Status changed from needs_review to needs_work
There are a few lines which are syntax errors in Python 3:
def children((lst, st)):
post_process = lambda (l, s): tuple(l) if not s else None,
comment:8 Changed 3 months ago by
- Commit changed from b44aac221c1fe6ddc86c859e53d7c9ad7747bc2c to 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457
comment:11 Changed 3 months ago by
- Branch changed from public/29882 to 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I just did few modifications to properly include Florent's example into the doc.
New commits:
Revert "Removed TODO in doc"
29882: including the two examples provided by Florent Hivert into docstring