Opened 4 months ago

Closed 3 months ago

#29882 closed enhancement (fixed)

Add tutorial-like docstring material on RecursivelyEnumeratedSet

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: combinatorics Keywords:
Cc: hivert, tscrim, slabbe, nthiery, slelievre Merged in:
Authors: Florent Hivert, Sébastien Labbé Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 90dc326 (Commits) Commit: 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457
Dependencies: Stopgaps:

Description

... from a forgotten branch on #16351 ...

Change History (11)

comment:1 Changed 4 months ago by mkoeppe

  • Branch set to u/hivert/move_searchforest_code_to_sage_sets_recursively_enumerated_set_pyx
  • Commit set to 1bf8c97ef9e6479ede07b339b11d413819508307

comment:2 Changed 4 months ago by mkoeppe

  • Cc slelievre added

comment:3 Changed 4 months ago by slabbe

  • Authors set to Florent Hivert, Sébastien Labbé
  • Branch changed from u/hivert/move_searchforest_code_to_sage_sets_recursively_enumerated_set_pyx to public/29882
  • Commit changed from 1bf8c97ef9e6479ede07b339b11d413819508307 to 8b9869fd278b20a9bce6b662d8189eb5f79f3b5c
  • Status changed from new to needs_review

I just did few modifications to properly include Florent's example into the doc.


New commits:

cb48f33Revert "Removed TODO in doc"
8b9869f29882: including the two examples provided by Florent Hivert into docstring

comment:4 Changed 4 months ago by slabbe

Note that I rebased old Florent Hivert's commit on top of 9.2.beta1 (new commit hash is cb48f33).

comment:5 Changed 4 months ago by git

  • Commit changed from 8b9869fd278b20a9bce6b662d8189eb5f79f3b5c to b44aac221c1fe6ddc86c859e53d7c9ad7747bc2c

Branch pushed to git repo; I updated commit sha1. New commits:

46cce8fMerge branch 'public/29882' of git://trac.sagemath.org/sage into public/29882
b44aac2Some reviewer changes.

comment:6 Changed 4 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

I made a few small changes to try and improve the exposition. If my changes are good, then positive review.

comment:7 Changed 3 months ago by gh-mwageringel

  • Status changed from needs_review to needs_work

There are a few lines which are syntax errors in Python 3:

    def children((lst, st)):
        post_process = lambda (l, s): tuple(l) if not s else None,

comment:8 Changed 3 months ago by git

  • Commit changed from b44aac221c1fe6ddc86c859e53d7c9ad7747bc2c to 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457

Branch pushed to git repo; I updated commit sha1. New commits:

0a8c6d8Merge branch 'public/29882' of trac.sagemath.org:/sage into 29882
90dc32629882: adapted examples to Python3 syntax

comment:9 Changed 3 months ago by slabbe

  • Status changed from needs_work to needs_review

Needs review.

comment:10 Changed 3 months ago by tscrim

  • Status changed from needs_review to positive_review

LGTM.

comment:11 Changed 3 months ago by vbraun

  • Branch changed from public/29882 to 90dc3261d6f936d9ccd79562a18f1f6f0c1e7457
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.