#29867 closed enhancement (fixed)
Remove __div__ methods from cython modules
Reported by: | arojas | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | refactoring | Keywords: | |
Cc: | isuruf, nbruin, fbissey, dimpase, gh-timokau, chapoton | Merged in: | |
Authors: | Antonio Rojas | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | aa02d4f (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
They are not needed since python 2 is no longer supported, and they make sage crash when built with cython 0.29.20 [1] (#29861). If there is a __truediv__
method defined we simply remove it, otherwise we rename them to __truediv__
[1] https://groups.google.com/forum/#!topic/sage-packaging/D_XVxbOrpNk
Change History (14)
comment:1 Changed 9 months ago by
- Branch set to u/arojas/remove___div___methods_from_cython_modules
comment:2 Changed 9 months ago by
- Commit set to e2dcdeeabb578c37bcf0361c0be3079315e9252c
- Component changed from PLEASE CHANGE to refactoring
- Description modified (diff)
- Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 9 months ago by
- Cc isuruf nbruin fbissey dimpase added
comment:4 Changed 9 months ago by
- Commit changed from e2dcdeeabb578c37bcf0361c0be3079315e9252c to b721abd01ad2cc80f5f4bb2b5d473e0ae8cb85e6
comment:5 Changed 9 months ago by
- Cc gh-timokau added
comment:6 Changed 9 months ago by
- Cc chapoton added
- Description modified (diff)
comment:7 Changed 9 months ago by
- Status changed from new to needs_review
comment:8 Changed 8 months ago by
There is documentation to be changed around line 430 of ext/fast_callable.pyx
comment:9 Changed 8 months ago by
- Commit changed from b721abd01ad2cc80f5f4bb2b5d473e0ae8cb85e6 to aa02d4f4a9421488d9f326adf02d587d5e6a2c7a
Branch pushed to git repo; I updated commit sha1. New commits:
aa02d4f | Remove obsolete test block
|
comment:10 Changed 8 months ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, let it be. Please add your name as author
comment:11 Changed 8 months ago by
comment:12 Changed 8 months ago by
- Branch changed from u/arojas/remove___div___methods_from_cython_modules to aa02d4f4a9421488d9f326adf02d587d5e6a2c7a
- Resolution set to fixed
- Status changed from positive_review to closed
comment:13 Changed 8 months ago by
- Commit aa02d4f4a9421488d9f326adf02d587d5e6a2c7a deleted
Follow up at #30098
comment:14 Changed 8 months ago by
This was by the way just a regression in cython 0.29.20, which is fixed in 0.29.21 - https://github.com/cython/cython/blob/master/CHANGES.rst#02921-2020-07-09
Branch pushed to git repo; I updated commit sha1. New commits:
Remove __div__ methods from cython modules