Changes between Version 3 and Version 6 of Ticket #29852
- Timestamp:
- Nov 13, 2020, 3:09:59 AM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #29852
-
Property
Status
changed from
new
toneeds_review
-
Property
Authors
changed from
to
Matthias Koeppe
- Property Cc Michael Orlitzky added
-
Property
Summary
changed from
Get rid of sage-env-config
tosage: Determine SAGE_LOCAL, SAGE_ROOT via sage-config if it exists
-
Property
Dependencies
changed from
#29850
to#22731
-
Property
Branch
changed from
to
u/mkoeppe/get_rid_of_sage_env_config
-
Property
Commit
changed from
to
9810f492a246441d7c570a1010558e38c1fc30ad
-
Property
Status
changed from
-
Ticket #29852 – Description
v3 v6 1 We remove 2 * the build-time dependency of the sage distribution on `src/bin/sage-env-config` 3 * the runtime dependency of sagelib on `sage-env-config`. 1 We reduce the runtime dependency of `sage` on `sage-env-config`. 4 2 5 Instead we use `sage-config` from `sage_conf` (which has a dependency on our `python3` package, of course). 6 In this ticket, we do this for `SAGE_LOCAL` and `SAGE_ROOT`. 3 We query `sage-config` from `sage_conf` (which has a dependency on our `python3` package, of course) for the values of `SAGE_LOCAL` and `SAGE_ROOT`. `sage-config` must be in the same directory as $0. 7 4 5 This allows the installed `sage` script to be invoked directly from `$SAGE_LOCAL/bin` in an environment without `SAGE_...` variables, restoring what was previously implemented in #25486. 6 7 Also, we move sourcing of `sage-env-config` (but not `sage-env`!) earlier in the `sage` script. 8 This is so that commands such as `sage --root` work correctly. 9 10 Follow-up tickets: 11 - #30888 resolve symlinks so it even works for symlinks to `$SAGE_LOCAL/bin/sage` 12 - #30013 set `SAGE_VENV` too 13 - remove the build-time dependency of the sage distribution on `src/bin/sage-env-config` 14