Opened 2 years ago
Closed 20 months ago
#29850 closed enhancement (fixed)
Install sageenvconfig as part of sage_conf
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  build  Keywords:  sd111 
Cc:  jhpalmieri, fbissey, mjo, dimpase, isuruf, ghtobiasdiez  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  4b52dcf (Commits, GitHub, GitLab)  Commit:  4b52dcf3def54b17a565d027b757a46b95f94e81 
Dependencies:  #31002  Stopgaps: 
Description (last modified by )
As a followup to #21559 and #30128, we reassign sageenvconfig
from the package sagelib
to the package sage_conf
.
(After #22731, sageenvconfig
is no longer required by the sage
script.)
(This is preparation for allowing installation of sagelib for example in a conda environment without having to run ./configure first  see #28745, #30845.)
Part of Metaticket #21707: Split sageenv into 5 to clean up sage configuration
Change History (48)
comment:1 Changed 2 years ago by
 Dependencies set to #29825
 Description modified (diff)
comment:2 Changed 2 years ago by
 Dependencies changed from #29825 to #29825, #21559
comment:3 Changed 2 years ago by
 Branch set to u/mkoeppe/install_sage_env_config_with_sage_conf
comment:4 followups: ↓ 7 ↓ 9 Changed 2 years ago by
 Commit set to dacea8b8d9a58555003d425957093b11ad0952fd
 Dependencies changed from #29825, #21559 to #29825, #21559, #29803
comment:5 Changed 2 years ago by
Perhaps it's easier to get rid of sageenvconfig altogether.
comment:6 Changed 2 years ago by
 Summary changed from Install sageenvconfig with sage_conf to Install sageenvconfig as part of sage_conf
comment:7 in reply to: ↑ 4 Changed 2 years ago by
comment:8 Changed 2 years ago by
 Commit changed from dacea8b8d9a58555003d425957093b11ad0952fd to 5f7b1cc40b66a94030e3e53607e2f0350363e40a
comment:9 in reply to: ↑ 4 Changed 2 years ago by
Replying to mkoeppe:
Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.
It would probably suffice to just replace the use of pip
by setup.py install
.
comment:10 Changed 2 years ago by
 Cc jhpalmieri fbissey added
 Description modified (diff)
comment:11 Changed 2 years ago by
 Work issues set to use setup.py install, add spkgsrc
comment:12 Changed 2 years ago by
 Commit changed from 5f7b1cc40b66a94030e3e53607e2f0350363e40a to 308ca6971af903adf4822e5349ef665cddc1e08a
comment:13 Changed 2 years ago by
 Work issues changed from use setup.py install, add spkgsrc to make sageenvconfig optional for sageenv
comment:14 Changed 2 years ago by
 Description modified (diff)
 Work issues make sageenvconfig optional for sageenv deleted
comment:15 Changed 2 years ago by
 Status changed from new to needs_review
comment:16 Changed 2 years ago by
 Work issues set to Move sage_conf.py to SAGE_ROOT/src/, symlink to there
comment:17 Changed 2 years ago by
(comment was meant for a different ticket)
comment:18 Changed 2 years ago by
 Work issues Move sage_conf.py to SAGE_ROOT/src/, symlink to there deleted
comment:19 Changed 2 years ago by
 Commit changed from 308ca6971af903adf4822e5349ef665cddc1e08a to 03301806c3b9d41fdfaf576fd84ac887f4156e1a
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
3a0193c  src/bin/sage: Remove handling of 'sage axiom'

6b04075  Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/changesrcbininstallation

9c7116b  src/bin/sagelistoptional, sagelistexperimental, sageliststandard: Remove deprecated scripts

831cc09  Merge branch 't/29920/remove_deprecated_scripts_sage_list_optional__sage_list_experimental__sage_list_standard' into t/21559/changesrcbininstallation

e3eca85  Merge branch 'public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup' of git://trac.sagemath.org/sage into t/21559/changesrcbininstallation

7d29141  src/setup.py: Do not install removed script sagersyncdist

c5f7f2f  Merge tag '9.2.beta3' into t/21559/changesrcbininstallation

6bc0cd4  Install sageenvconfig with sage_conf

5e6ca95  build/pkgs/sage_conf/spkginstall: Install with setup.py instead of pip

0330180  build/pkgs/sage_conf/spkgsrc: New

comment:20 Changed 2 years ago by
 Dependencies changed from #29825, #21559, #29803 to #21559
comment:21 Changed 2 years ago by
 Commit changed from 03301806c3b9d41fdfaf576fd84ac887f4156e1a to 709ebca31bd68a64865b6251b264fcd5a2e38aa7
Branch pushed to git repo; I updated commit sha1. New commits:
3953671  Merge tag '9.2.beta4' into t/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution

19d7f67  Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/changesrcbininstallation

709ebca  Merge branch 't/21559/changesrcbininstallation' into t/29850/install_sage_env_config_with_sage_conf

comment:22 Changed 2 years ago by
 Cc mjo added
comment:23 Changed 2 years ago by
 Description modified (diff)
 Summary changed from Install sageenvconfig as part of sage_conf to Install sageenvconfig as part of sage_conf; make sageenvconfig optional
comment:24 Changed 2 years ago by
 Dependencies changed from #21559 to #29951
 Status changed from needs_review to needs_work
comment:25 Changed 2 years ago by
 Milestone changed from sage9.2 to sage9.3
comment:26 Changed 21 months ago by
 Cc dimpase isuruf added
comment:27 Changed 21 months ago by
 Commit changed from 709ebca31bd68a64865b6251b264fcd5a2e38aa7 to a3615809e0eda053534d6f0713ee95e6c5939c7d
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
53805b0  src/bin/sageenv: Make SAGE_ROOT and SAGE_LOCAL optional

09584ea  Merge tag '9.2.beta14' into t/29951/src_bin_sage_env__make_sage_env_config_and_sage_local_optional

a2571b1  Merge tag '9.2' into t/29951/src_bin_sage_env__make_sage_env_config_and_sage_local_optional

9ba8cf2  Merge tag '9.3.beta0' into t/29951/src_bin_sage_env__make_sage_env_config_and_sage_local_optional

c8e6910  Merge tag '9.3.beta1' into t/29951/src_bin_sage_env__make_sage_env_config_and_sage_local_optional

9ab593c  Install sageenvconfig with sage_conf

a361580  build/pkgs/sage_conf/spkgsrc: New

comment:28 Changed 21 months ago by
 Commit changed from a3615809e0eda053534d6f0713ee95e6c5939c7d to d02b59722808b81329c390017e55e69237cc9557
Branch pushed to git repo; I updated commit sha1. New commits:
d02b597  build/pkgs/sagelib/src/setup.py: Do not install sageenvconfig

comment:29 Changed 21 months ago by
 Commit changed from d02b59722808b81329c390017e55e69237cc9557 to 1b4bc9938d3dcef8cd4f745f0bc26a718b35178d
Branch pushed to git repo; I updated commit sha1. New commits:
1b4bc99  src/bin/sage: Only source sageenvconfig if it exists

comment:30 Changed 21 months ago by
 Commit changed from 1b4bc9938d3dcef8cd4f745f0bc26a718b35178d to a1a6df55d880441fe57975c653c161e929cc9dd5
Branch pushed to git repo; I updated commit sha1. New commits:
a1a6df5  src/bin/sage: Use python3 etc. from PATH instead of using SAGE_LOCAL

comment:31 Changed 21 months ago by
 Commit changed from a1a6df55d880441fe57975c653c161e929cc9dd5 to 19f7eae793b3eee1113f98e31b952246ebfd51c4
comment:32 Changed 21 months ago by
 Description modified (diff)
 Status changed from needs_work to needs_review
comment:33 Changed 21 months ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_review to positive_review
lgtm
comment:34 Changed 21 months ago by
Thanks!
comment:35 Changed 21 months ago by
 Status changed from positive_review to needs_info
comment:36 Changed 21 months ago by
comment:37 Changed 21 months ago by
 Dependencies changed from #29951 to #29951  #22731
 Work issues set to Rebase on top of #22731
comment:38 Changed 21 months ago by
 Commit changed from 19f7eae793b3eee1113f98e31b952246ebfd51c4 to 5dc4266d471b31e08b97b7e4ab8f8ee7aca9f58e
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
4577f37  src/bin/sageenv: Make sageenvconfig optional

c35c170  sage.env: Add SAGE_VENV

c585d94  src/sage: Replace some SAGE_LOCAL by SAGE_VENV

2fd195f  src/bin/sage: Fix reference to trac ticket

f3b7a9c  src/sage/env.py: Add documentation

0e4764c  Merge branch 't/22731/22731' into t/29850/install_sage_env_config_with_sage_conf

657eea0  Install sageenvconfig with sage_conf

7e18730  build/pkgs/sage_conf/spkgsrc: New

36e479c  build/pkgs/sagelib/src/setup.py: Do not install sageenvconfig

5dc4266  build/pkgs/sage_conf/spkginstall: Build wheel manually

comment:39 Changed 21 months ago by
 Cc ghtobiasdiez added
 Dependencies changed from #29951  #22731 to #22731
 Description modified (diff)
 Status changed from needs_info to needs_review
 Summary changed from Install sageenvconfig as part of sage_conf; make sageenvconfig optional to Install sageenvconfig as part of sage_conf
 Work issues Rebase on top of #22731 deleted
comment:40 Changed 20 months ago by
 Keywords sd111 added
comment:41 Changed 20 months ago by
 Dependencies changed from #22731 to #31002
 Status changed from needs_review to needs_work
 Work issues set to use new function from #31002
comment:42 Changed 20 months ago by
 Work issues changed from use new function from #31002 to use new function from #31002  or use #30013 and move sageenvconfig into the sage_conf source directory
comment:43 Changed 20 months ago by
 Commit changed from 5dc4266d471b31e08b97b7e4ab8f8ee7aca9f58e to 4b52dcf3def54b17a565d027b757a46b95f94e81
Branch pushed to git repo; I updated commit sha1. New commits:
a8e0364  Specify bdist temp folder for WSL compatibility

a3077c7  Use mktemp

c5a14a3  build/bin/sagedisthelpers (sdh_setup_bdist_wheel): New

fb10429  build/pkgs/*/spkginstall.in: Use new function sdh_setup_bdist_wheel

5f11e24  Merge branch 'public/build/bdist_wsl' of git://trac.sagemath.org/sage into t/29850/install_sage_env_config_with_sage_conf

0773001  Merge tag '9.3.beta3' into t/29850/install_sage_env_config_with_sage_conf

4b52dcf  build/pkgs/sage_conf/spkginstall: Use sdh_setup_bdist_wheel

comment:44 Changed 20 months ago by
 Status changed from needs_work to needs_review
 Work issues use new function from #31002  or use #30013 and move sageenvconfig into the sage_conf source directory deleted
comment:45 Changed 20 months ago by
Still needs review...
comment:47 Changed 20 months ago by
Thanks!
comment:48 Changed 20 months ago by
 Branch changed from u/mkoeppe/install_sage_env_config_with_sage_conf to 4b52dcf3def54b17a565d027b757a46b95f94e81
 Resolution set to fixed
 Status changed from positive_review to closed
Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.
Last 10 new commits:
build/pkgs/pip/dependencies: Add wheel, simplify $(PYTHON) python3 to $(PYTHON)
build/pkgs/setuptools, build/pkgs/pip: Remove python2 support from dependencies, install scripts
build/pkgs/pkgconfig/spkginstall.in: Remove pyproject.toml so that pip installs using setup.py
build/pkgs/entrypoints: Do not provide setup.py, not needed for entrypoints 0.3
build/pkgs/entrypoints/spkginstall.in: Remove pyproject.toml so that setup.py is used
build/pkgs/terminado/spkginstall.in: Remove pyproject.toml so that setup.py is used
build/pkgs/testpath/spkginstall.in: Remove pyproject.toml so that setup.py is used
build/pkgs/zope_interface: Change to a dummy script package
Merge branch 't/29803/upgrade_setuptools__pip__2020_06_' into t/29850/install_sage_env_config_with_sage_conf
WIP: Install sageenvconfig with sage_conf