Opened 2 years ago

Last modified 13 months ago

#29847 closed enhancement

Install sage_setup with pip, move sage_include_directories, cython_aliases from sage.env to sage_setup — at Version 10

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.5
Component: build Keywords: sd111
Cc: François Bissey, John Palmieri, Dima Pasechnik Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #29702, #29706, #29785 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

sage_setup will be used by the build system of various distutils packages (#29705).

So we make it a regular distutils package itself and install it with pip.

We remove some dependencies on sage.* that are still in sage_setup:

./library_order.py:77:from sage.env import cython_aliases
./command/sage_build_cython.py:21:from sage.env import (SAGE_INC, cython_aliases, sage_include_directories)

... by moving functions these functions to sage_setup (and leave a perhaps deprecated reimport behind). Should be done after #29706, #29785, which touch these functions.

... and remove the use of SAGE_INC by using instead the environment variables set in sage-build-env-config (as noted in #29711).

Harmless dependencies on sage.*:

./docbuild/ ........
  (will be invoked later, when sage.* is installed)
./optional_extension.py:22:from sage.misc.package import list_packages
./optional_extension.py:44:    from sage.misc.package import is_package_installed
  (no longer used, only kept around in case user packages use it)
./autogen/interpreters/__main__.py:4:from sage.env import SAGE_SRC
  (only used when invoked interactively)
./command/sage_install.py:28:        from sage.repl.ipython_kernel.install import SageKernelSpec
  (just need to make sure that `sage_setup.command.sage_install` is only used by the distribution that installs `sage.repl.ipython_kernel`)

Change History (10)

comment:1 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:2 Changed 2 years ago by Matthias Köppe

Dependencies: #29702

comment:3 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:4 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:5 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:6 Changed 2 years ago by Matthias Köppe

Summary: Install sage_setup with pipInstall sage_setup with pip, move sage_include_directories, cython_aliases from sage.env to sage_setup

comment:7 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:8 Changed 2 years ago by Matthias Köppe

Dependencies: #29702#29702, #29706, #29785
Description: modified (diff)

comment:9 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:10 Changed 2 years ago by Matthias Köppe

Description: modified (diff)
Note: See TracTickets for help on using tickets.