Opened 2 years ago
Closed 10 months ago
#29847 closed enhancement (fixed)
Install sage_setup with setuptools as a prerequisite for building/installing sagelib
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.5 |
Component: | build | Keywords: | sd111 |
Cc: | fbissey, jhpalmieri, dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | f84730e (Commits, GitHub, GitLab) | Commit: | f84730e30ff7ac94f5f5990eb5a28744ac2932b3 |
Dependencies: | #32046 | Stopgaps: |
Description (last modified by )
sage_setup will be used by the build system of various distribution packages (#29705).
So we make it a regular distribution package itself, with sources in pkgs/sage-setup/
(#31577) and install it with pip
.
The actual Python source files are not moved because sage_setup
takes part in Sage doctesting (see #31577).
sagelib
's setup.py
will no longer install sage_setup
.
sage-setup
will become a build-system requires
of sagemath-standard
(declared in pyproject.toml
)
Follow-up:
- #29924: Do not fail if
sage.env
,sage.*
are not available
References:
python - pip ignores dependency_links in setup.py - Stack Overflow https://stackoverflow.com/questions/12518499/pip-ignores-dependency-links-in-setup-py
dependency_links flag ignored when package exists on PyPI · Issue #987 · pypa/setuptools https://github.com/pypa/setuptools/issues/987
Suggest alternatives for --process-dependency-links · Issue #6162 · pypa/pip https://github.com/pypa/pip/issues/6162
PEP 508 -- Dependency specification for Python Software Packages | Python.org https://www.python.org/dev/peps/pep-0508/#pep440
PEP 440 -- Version Identification and Dependency Specification | Python.org https://www.python.org/dev/peps/pep-0440/#local-version-segments
Change History (98)
comment:1 Changed 2 years ago by
- Description modified (diff)
comment:2 Changed 2 years ago by
- Dependencies set to #29702
comment:3 Changed 2 years ago by
- Description modified (diff)
comment:4 Changed 2 years ago by
- Description modified (diff)
comment:5 Changed 2 years ago by
- Description modified (diff)
comment:6 Changed 2 years ago by
- Summary changed from Install sage_setup with pip to Install sage_setup with pip, move sage_include_directories, cython_aliases from sage.env to sage_setup
comment:7 Changed 2 years ago by
- Description modified (diff)
comment:8 Changed 2 years ago by
- Dependencies changed from #29702 to #29702, #29706, #29785
- Description modified (diff)
comment:9 Changed 2 years ago by
- Description modified (diff)
comment:10 Changed 2 years ago by
- Description modified (diff)
comment:11 Changed 2 years ago by
- Description modified (diff)
comment:12 Changed 2 years ago by
- Branch set to u/mkoeppe/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
comment:13 Changed 2 years ago by
- Commit set to 4ce81bf162906ba72c5fc8ca7c349dedf33cd033
- Dependencies changed from #29702, #29706, #29785 to #29702, #29706, #29785, #29855
comment:14 Changed 2 years ago by
- Commit changed from 4ce81bf162906ba72c5fc8ca7c349dedf33cd033 to 4a9dd3ad8c103784403e8ecce172427b2f5c0eff
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
041c9e8 | sage_setup.command.sage_build_cython: Use SAGE_GMP_PREFIX, SAGE_NTL_PREFIX for header dependencies instead of SAGE_INC
|
4a9dd3a | Merge branch 't/29855/sagelib_setup_py__fix_dependencies_on_header_files_of_packages_gmp__ntl' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:15 Changed 2 years ago by
- Description modified (diff)
comment:16 Changed 2 years ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:17 Changed 2 years ago by
- Description modified (diff)
comment:18 Changed 2 years ago by
- Summary changed from Install sage_setup with pip, move sage_include_directories, cython_aliases from sage.env to sage_setup to Install sage_setup with pip as a prerequisite for building/installing sagelib
comment:19 Changed 2 years ago by
- Milestone changed from sage-9.3 to sage-9.2
comment:20 Changed 2 years ago by
- Cc fbissey added
- Description modified (diff)
comment:21 Changed 2 years ago by
- Description modified (diff)
comment:22 Changed 2 years ago by
- Description modified (diff)
- Summary changed from Install sage_setup with pip as a prerequisite for building/installing sagelib to Install sage_setup with setuptools as a prerequisite for building/installing sagelib, install sage-the-distribution scripts as "scripts"
comment:23 Changed 2 years ago by
- Description modified (diff)
comment:24 follow-up: ↓ 27 Changed 2 years ago by
[sagelib-9.1.rc5] running build [sagelib-9.1.rc5] Generating auto-generated sources [sagelib-9.1.rc5] Building interpreters for fast_callable [sagelib-9.1.rc5] -> Rebuilding interpreters because /Users/mkoeppe/s/sage/sage-rebasing/src/sage_setup/autogen/interpreters/memory.py changed [sagelib-9.1.rc5] running build_cython [sagelib-9.1.rc5] Enabling Cython debugging support [sagelib-9.1.rc5] Updating Cython code.... [sagelib-9.1.rc5] Compiling sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra_element.pyx because it changed. [sagelib-9.1.rc5] error: [Errno 21] Is a directory: '/Users/mkoeppe/s/sage/sage-rebasing/src/sage/cpython'
Hm....
comment:25 Changed 2 years ago by
- Commit changed from 4a9dd3ad8c103784403e8ecce172427b2f5c0eff to 010c6e3b7abcf381a691ca87c6e0d4238d922ce5
comment:26 Changed 2 years ago by
- Commit changed from 010c6e3b7abcf381a691ca87c6e0d4238d922ce5 to 2d0d0a7720bbef005892f5f56c982c26e5eb0fb8
Branch pushed to git repo; I updated commit sha1. New commits:
18aae7f | sage_setup.command.sage_build_cython: Fix up - add list brackets
|
2d0d0a7 | Merge branch 't/29855/sagelib_setup_py__fix_dependencies_on_header_files_of_packages_gmp__ntl' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:27 in reply to: ↑ 24 Changed 2 years ago by
comment:28 Changed 2 years ago by
- Commit changed from 2d0d0a7720bbef005892f5f56c982c26e5eb0fb8 to 0459006f8ad828e3c3f83004b6db605ec036a0f6
Branch pushed to git repo; I updated commit sha1. New commits:
0459006 | .gitignore: Ignore generated files in build/pkgs/*/src
|
comment:29 Changed 2 years ago by
- Work issues set to Install scripts, add spkg-src
comment:30 Changed 2 years ago by
- Commit changed from 0459006f8ad828e3c3f83004b6db605ec036a0f6 to c66384d34edb84b22dd2cc9c5e3afa1b049a3e8f
Branch pushed to git repo; I updated commit sha1. New commits:
c66384d | build/pkgs/sage_setup/spkg-install: Fixup use of --root
|
comment:31 Changed 2 years ago by
- Commit changed from c66384d34edb84b22dd2cc9c5e3afa1b049a3e8f to 58956e65bcf221fac3aa670d165d89948a65e825
Branch pushed to git repo; I updated commit sha1. New commits:
58956e6 | build/pkgs/sage_setup/spkg-src: New
|
comment:32 Changed 2 years ago by
- Work issues changed from Install scripts, add spkg-src to Install scripts
comment:33 Changed 2 years ago by
- Cc jhpalmieri added
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from Install sage_setup with setuptools as a prerequisite for building/installing sagelib, install sage-the-distribution scripts as "scripts" to Install sage_setup with setuptools as a prerequisite for building/installing sagelib
- Work issues Install scripts deleted
comment:34 Changed 2 years ago by
- Commit changed from 58956e65bcf221fac3aa670d165d89948a65e825 to 0e1702396fc2e66b851e187a02a52bc2853da7e6
Branch pushed to git repo; I updated commit sha1. New commits:
0e17023 | Merge tag '9.2.beta2' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:35 Changed 2 years ago by
- Dependencies changed from #29702, #29706, #29785, #29855 to #29702, #29855
comment:36 Changed 2 years ago by
- Cc dimpase added
comment:37 Changed 2 years ago by
- Description modified (diff)
comment:38 Changed 2 years ago by
- Description modified (diff)
comment:39 Changed 2 years ago by
- Commit changed from 0e1702396fc2e66b851e187a02a52bc2853da7e6 to 0d22cefeb55b66cbd1e9e3b0057861f8db486963
Branch pushed to git repo; I updated commit sha1. New commits:
0d22cef | build/pkgs/sage_setup/spkg-src: chmod +x
|
comment:40 Changed 2 years ago by
- Commit changed from 0d22cefeb55b66cbd1e9e3b0057861f8db486963 to 21eb31edf8575b13f6f1baa312f73c2c60a8ce82
Branch pushed to git repo; I updated commit sha1. New commits:
21eb31e | build/pkgs/sage_setup/src/tox.ini, requirements.txt: New
|
comment:41 Changed 2 years ago by
- Commit changed from 21eb31edf8575b13f6f1baa312f73c2c60a8ce82 to eeeaa47644aad4801b99e645ccd24176864bfa54
Branch pushed to git repo; I updated commit sha1. New commits:
eeeaa47 | build/pkgs/sage_setup/src/setup.cfg: Add nested packages
|
comment:42 Changed 2 years ago by
- Commit changed from eeeaa47644aad4801b99e645ccd24176864bfa54 to 4dcaf1cd1b203e6fc08d0d57ba872b085284f685
Branch pushed to git repo; I updated commit sha1. New commits:
4dcaf1c | build/pkgs/sage_setup/src/setup.cfg: Add remaining nested packages
|
comment:43 Changed 2 years ago by
- Description modified (diff)
- Milestone changed from sage-9.2 to sage-9.3
comment:44 Changed 2 years ago by
- Dependencies changed from #29702, #29855 to #29702, #29855, #30011
comment:45 Changed 2 years ago by
- Work issues set to merge #30011, remove dep on six
comment:46 Changed 2 years ago by
comment:47 Changed 2 years ago by
- Commit changed from 4dcaf1cd1b203e6fc08d0d57ba872b085284f685 to 44cc65dbdf5c7f3818eb0a880835162579238b57
Branch pushed to git repo; I updated commit sha1. New commits:
212d183 | trac 30011: remove sage_setup/fpickle_setup.py
|
0ef60f5 | Merge branch 'u/jhpalmieri/sage_setup__remove_use_of_six' of git://trac.sagemath.org/sage into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
44cc65d | build/pkgs/sage_setup/dependencies: New
|
comment:48 Changed 2 years ago by
- Work issues merge #30011, remove dep on six deleted
comment:49 Changed 2 years ago by
This ticket is not so urgent (I've set its milestone to 9.3)
comment:50 Changed 2 years ago by
- Status changed from needs_review to needs_work
- Work issues set to Merge #29950
comment:51 Changed 2 years ago by
- Work issues changed from Merge #29950 to Merge #30010
comment:52 Changed 22 months ago by
- Dependencies changed from #29702, #29855, #30011 to #29500, #30010
comment:53 Changed 22 months ago by
- Commit changed from 44cc65dbdf5c7f3818eb0a880835162579238b57 to 8d465d72bf2b199f3fb46b7a72e51a186c954228
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
8aa6fd9 | build/bin/sage-dist-helpers (sdh_pip_install): Build a wheel, store it
|
d369aab | build/bin/sage-dist-helpers (sdh_store_and_pip_install_wheel): New, factored out from sdh_pip_install
|
2d435ab | build/pkgs/numpy/spkg-install.in: Install via setup.py bdist_wheel
|
55993b6 | build/bin/sage-dist-helpers: Fixup
|
0a64674 | build/pkgs/gambit/spkg-install.in: Install via bdist_wheel
|
ca58693 | build/pkgs/pillow/spkg-install.in: Install via bdist_wheel
|
65773f7 | Merge branch 't/29500/install_all_python_packages_via_pip_wheel__create_pep_503_simple_repository_for_wheels' into t/30010/split_sage_setup_docbuild_out_to_a_separate_package
|
14ab446 | build/pkgs/sage_setup_docbuild/spkg-install: Install via setup.py bdist_wheel
|
3c5584d | Merge branch 't/30010/split_sage_setup_docbuild_out_to_a_separate_package' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
8d465d7 | build/pkgs/sage_setup/spkg-install: Install via setup.py bdist_wheel
|
comment:54 Changed 22 months ago by
- Status changed from needs_work to needs_review
- Work issues Merge #30010 deleted
comment:55 Changed 22 months ago by
- Commit changed from 8d465d72bf2b199f3fb46b7a72e51a186c954228 to db56301317b59708186defd76e2e6db1423e86af
Branch pushed to git repo; I updated commit sha1. New commits:
db56301 | build/pkgs/sagelib/src/requirements.txt: Update
|
comment:56 Changed 22 months ago by
- Commit changed from db56301317b59708186defd76e2e6db1423e86af to 1bb5b3453ac6d4a163be5c28446afb7ac66750b8
comment:57 Changed 20 months ago by
- Dependencies changed from #29500, #30010 to #30010
- Description modified (diff)
- Milestone changed from sage-9.3 to sage-9.4
comment:58 Changed 19 months ago by
- Keywords sd111 added
Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111
comment:60 Changed 17 months ago by
- Description modified (diff)
comment:61 Changed 17 months ago by
- Dependencies changed from #30010 to #30010, #30913, #31377
- Work issues set to rebase
comment:62 Changed 12 months ago by
- Dependencies changed from #30010, #30913, #31377 to #31577
- Description modified (diff)
- Work issues changed from rebase to rebase on #31577
comment:63 Changed 12 months ago by
- Commit changed from 1bb5b3453ac6d4a163be5c28446afb7ac66750b8 to 2b25c06f1fece1897e222f16c5e4b5bd9ab047d1
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
d3a8f5f | build/pkgs/sage_setup/spkg-src: New
|
9c71594 | build/pkgs/sage_setup/spkg-src: chmod +x
|
23cd1d9 | build/pkgs/sage_setup/src/tox.ini, requirements.txt: New
|
ae23b43 | build/pkgs/sage_setup/src/setup.cfg: Add nested packages
|
7c7b38a | build/pkgs/sage_setup/src/setup.cfg: Add remaining nested packages
|
2e9b850 | build/pkgs/sage_setup/dependencies: New
|
5511555 | build/pkgs/sage_setup/spkg-install: Install via setup.py bdist_wheel
|
3e28f39 | build/pkgs/sage_setup/src: Set version, remove sage_setup.docbuild package
|
4d387bb | build/pkgs/sage_setup/type: Change to standard
|
2b25c06 | Move sage_setup distribution source to pkgs/sage-setup
|
comment:64 Changed 12 months ago by
- Commit changed from 2b25c06f1fece1897e222f16c5e4b5bd9ab047d1 to f51ca1cd744740d2d2a59b634310e1a92b4e1d04
comment:65 Changed 12 months ago by
- Commit changed from f51ca1cd744740d2d2a59b634310e1a92b4e1d04 to 35e38cdca128295ec79e88d3f43ce858392bd5eb
Branch pushed to git repo; I updated commit sha1. New commits:
35e38cd | Fixup
|
comment:66 Changed 12 months ago by
- Commit changed from 35e38cdca128295ec79e88d3f43ce858392bd5eb to cf606f743e019c82ec3cfc212d60b6b54c1fa3f4
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
a1d33bc | build/pkgs/pillow/spkg-install.in, build/bin/sage-dist-helpers: Remove debugging code
|
413f6b5 | build/pkgs/{jupyter_jsmol,python_igraph,pillow}/spkg-install.in: Use --build-option, not --global-option
|
1e993d4 | Fixup
|
9ec5bc2 | pkgs/sagemath-standard/setup.py, src/setup.py, src/MANIFEST.in: Exclude sage_setup
|
9ec930c | Update paths in comments
|
d8d5755 | pkgs/sage-setup/tox.ini: Update paths in comments
|
b4b5c19 | build/bin/write-dockerfile.sh: ADD pkgs
|
40abff0 | pkgs/sage-setup/setup.cfg: README.rst, not README.md
|
782b64b | pkgs/sagemath-standard: Remove symlink to SAGE_ROOT/src/sage_setup
|
cf606f7 | build/bin/write-dockerfile.sh: ADD src/sage_setup before building TARGETS_PRE
|
comment:67 Changed 12 months ago by
- Commit changed from cf606f743e019c82ec3cfc212d60b6b54c1fa3f4 to a1b8832dc2aea68404314cdfca4abd9c92cae6b7
Branch pushed to git repo; I updated commit sha1. New commits:
a1b8832 | build/pkgs/sage_setup/spkg-src: Use python3
|
comment:68 Changed 12 months ago by
- Status changed from needs_work to needs_review
- Work issues rebase on #31577 deleted
comment:69 Changed 12 months ago by
- Commit changed from a1b8832dc2aea68404314cdfca4abd9c92cae6b7 to 61c25a05c81b2204f89d7c5f68a16c5b5b41e517
comment:70 Changed 12 months ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
ok, fine
comment:71 Changed 12 months ago by
Thanks!
comment:72 Changed 12 months ago by
- Commit changed from 61c25a05c81b2204f89d7c5f68a16c5b5b41e517 to 7f0bd4af0ae00e7ad19476c75ffdb00d9eee21f1
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
7f0bd4a | Merge tag '9.4.beta4' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:73 Changed 12 months ago by
- Status changed from needs_review to positive_review
comment:74 Changed 12 months ago by
- Status changed from positive_review to needs_work
*********************************************** make[1]: Entering directory '/home/release/Sage/build/make' make --no-print-directory sagelib-SAGE_VENV-no-deps cd '/home/release/Sage/build/pkgs/sagelib' && . '/home/release/Sage/src/bin/sage-src-env-config' && . '/home/release/Sage/src/bin/sage-env-config' && . '/home/release/Sage/src/bin/sage-env' && . '/home/release/Sage/build/bin/sage-build-env-config' && . '/home/release/Sage/build/bin/sage-build-env' && SAGE_SPKG_WHEELS=/home/release/Sage/local/var/lib/sage/wheels SAGE_INST_LOCAL=/home/release/Sage/local sage-logger -p '/home/release/Sage/build/pkgs/sagelib/spkg-install' '/home/release/Sage/logs/pkgs/sagelib-9.4.beta4.log' [sagelib-9.4.beta4] Traceback (most recent call last): [sagelib-9.4.beta4] File "/home/release/Sage/pkgs/sagemath-standard/setup.py", line 31, in <module> [sagelib-9.4.beta4] from sage_setup.excepthook import excepthook [sagelib-9.4.beta4] ModuleNotFoundError: No module named 'sage_setup.excepthook' [sagelib-9.4.beta4] [sagelib-9.4.beta4] real 0m0.140s [sagelib-9.4.beta4] user 0m0.121s [sagelib-9.4.beta4] sys 0m0.017s make[2]: *** [Makefile:2693: sagelib-SAGE_VENV-no-deps] Error 1 make[1]: *** [Makefile:2693: /home/release/Sage/local/var/lib/sage/installed/sagelib-9.4.beta4] Error 2 make[1]: Leaving directory '/home/release/Sage/build/make' real 0m0.257s user 0m0.222s sys 0m0.037s *************************************************************** Error building Sage.
comment:75 Changed 12 months ago by
- Commit changed from 7f0bd4af0ae00e7ad19476c75ffdb00d9eee21f1 to 35b8b7448e6062ee5f57c8c02d586924023b6bd7
Branch pushed to git repo; I updated commit sha1. New commits:
35b8b74 | Merge tag '9.4.beta5' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:76 follow-up: ↓ 78 Changed 12 months ago by
- Status changed from needs_work to needs_review
I can't reproduce this error. Possibly from forgetting to run bootstrap
and configure
.
comment:77 follow-up: ↓ 79 Changed 12 months ago by
I don't know if this is worth a ticket or if there is a relevant one already, but running ./bootstrap
produces various warnings:
m4/sage_spkg_configures.m4:513: warning: The macro `AC_PROG_CC_C99' is obsolete. m4/sage_spkg_configures.m4:516: warning: The macro `AC_FOREACH' is obsolete. m4/sage_spkg_configures.m4:516: warning: The macro `AC_FOREACH' is obsolete. m4/sage_spkg_configures.m4:530: warning: The macro `AC_FOREACH' is obsolete. m4/sage_spkg_configures.m4:594: warning: The macro `AC_TRY_RUN' is obsolete. m4/sage_spkg_configures.m4:594: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:447: warning: back quotes and double quotes must not be escaped in: multiple installation records for $SPKG_NAME: m4_newline($(ls -l "$SAGE_SPKG_INST/$SPKG_NAME"-*)) m4_newline([only one should exist, so please delete some or all of these files and re-run \"$srcdir/configure\"])
comment:78 in reply to: ↑ 76 ; follow-up: ↓ 80 Changed 12 months ago by
Replying to mkoeppe:
I can't reproduce this error. Possibly from forgetting to run
bootstrap
andconfigure
.
In the meantime, are you waiting for more information from Volker, or should this go back to "positive review"?
comment:79 in reply to: ↑ 77 Changed 12 months ago by
Replying to jhpalmieri:
I don't know if this is worth a ticket or if there is a relevant one already, but running
./bootstrap
produces various warnings
I think this is #30668
comment:80 in reply to: ↑ 78 Changed 12 months ago by
Replying to jhpalmieri:
Replying to mkoeppe:
I can't reproduce this error. Possibly from forgetting to run
bootstrap
andconfigure
.In the meantime, are you waiting for more information from Volker, or should this go back to "positive review"?
Let's do "positive review". Easier to run it just as part of Volker's integration tests.
comment:81 Changed 12 months ago by
- Status changed from needs_review to positive_review
comment:82 Changed 11 months ago by
- Status changed from positive_review to needs_work
Merge conflict
comment:83 Changed 11 months ago by
- Commit changed from 35b8b7448e6062ee5f57c8c02d586924023b6bd7 to 9aa1f10c1656f4d7f1cf8e15c1c0dfd2feaad1c0
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
8feca2a | Merge tag '9.4.beta5' into t/32073/deprecate_sage_libs_readline
|
ed14848 | Remove readline lib file from the documentation.
|
773ef29 | Merge #32073
|
28d6622 | build/bin/sage-spkg: Remove dead code for old-style spkg
|
3b435d9 | build/bin/sage-dist-helpers (sdh_store_and_pip_install_wheel): Record name of installed distribution name
|
34bd445 | sdh_pip_uninstall (sdh_pip_uninstall): New helper functtion; use same flags in 'make SPKG-clean' for pip packages
|
49af8aa | build/bin/sage-spkg, build/sage_bootstrap/uninstall.py: Prepare/install/use the spkg-piprm script
|
ecd49fb | build/bin/sage-dist-helpers, src/doc/en/developer/packaging.rst: Document sdh_pip_uninstall
|
c3eeb69 | build/bin/sage-spkg: Fix typo in comment, unindent a block
|
9aa1f10 | Merge #29585
|
comment:84 Changed 11 months ago by
- Dependencies changed from #31577 to #31577, #29585, #32073
- Status changed from needs_work to positive_review
comment:85 Changed 11 months ago by
- Dependencies changed from #31577, #29585, #32073 to #31577, #29585, #32073, #32046
comment:86 Changed 11 months ago by
- Commit changed from 9aa1f10c1656f4d7f1cf8e15c1c0dfd2feaad1c0 to 6b1b222e05281413854602e2bec2e8d6ad680513
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
8c5ee65 | build/pkgs/pip/install-requires.txt: Update lower bound
|
ed5f9f0 | Merge tag '9.4.beta6' into t/32046/use_pip___use_feature_in_tree_build__replace_use_of_sdh_setup_bdist_wheel_by_sdh_pip_install
|
6b1b222 | Merge #32046
|
comment:87 Changed 11 months ago by
- Milestone changed from sage-9.4 to sage-9.5
comment:88 Changed 11 months ago by
- Commit changed from 6b1b222e05281413854602e2bec2e8d6ad680513 to a41b507abb68a451e0d2f369749bcc5a3352ccf0
Branch pushed to git repo; I updated commit sha1. New commits:
85d1d27 | Merge tag '9.4.rc1' into t/32046/use_pip___use_feature_in_tree_build__replace_use_of_sdh_setup_bdist_wheel_by_sdh_pip_install
|
050f8df | build/pkgs/numpy/spkg-install.in: Use sdh_pip_install, sdh_prefix_args
|
a41b507 | Merge branch 't/32046/use_pip___use_feature_in_tree_build__replace_use_of_sdh_setup_bdist_wheel_by_sdh_pip_install' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
comment:89 Changed 11 months ago by
- Dependencies changed from #31577, #29585, #32073, #32046 to #32046
comment:90 Changed 11 months ago by
- Commit changed from a41b507abb68a451e0d2f369749bcc5a3352ccf0 to 478ffcddb5a0b663f7bc1fd98d2b4ac632d79988
comment:91 Changed 11 months ago by
- Commit changed from 478ffcddb5a0b663f7bc1fd98d2b4ac632d79988 to b2368c62fc1fbc08fc0f06191d3671fb33133a8b
Branch pushed to git repo; I updated commit sha1. New commits:
b2368c6 | pkgs/sage-setup/setup.cfg: Add pkgconfig as install_requires
|
comment:92 Changed 11 months ago by
I'm getting a lot of doctest failures:
sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/utils.py # 15 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/find.py # 38 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/rdf.py # 11 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/optional_extension.py # 12 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/__init__.py # 5 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/generator.py # 70 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/clean.py # 13 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/storage.py # 97 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/memory.py # 57 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/cdf.py # 9 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/cc.py # 20 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/python.py # 25 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/instructions.py # 39 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/rr.py # 21 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/base.py # 22 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/autogen/interpreters/specs/element.py # 11 doctests failed sage -t --long --warn-long 100.8 --random-seed=0 src/sage_setup/util.py # 6 doctests failed
The directory local/lib/python3.9/site-packages/sage_setup
doesn't have much in it anymore, and I'm guessing that this causes the problems.
comment:93 Changed 10 months ago by
- Status changed from needs_review to needs_work
comment:94 Changed 10 months ago by
- Commit changed from b2368c62fc1fbc08fc0f06191d3671fb33133a8b to f84730e30ff7ac94f5f5990eb5a28744ac2932b3
Branch pushed to git repo; I updated commit sha1. New commits:
db8e30d | Merge tag '9.5.beta0' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
|
37f9b0c | build/make/Makefile.in: For script packages, make sure that 'sage -f' uninstalls first
|
456d8a9 | build/make/Makefile.in (sage_setup-clean): Clean the build tree
|
f84730e | sage_setup.clean: Do not clean the sage_setup installation in site-packages
|
comment:95 Changed 10 months ago by
- Status changed from needs_work to needs_review
Thanks for catching this. When configure --enable-editable
is not used, the "cleaner" erased sage_setup
's files at the end of the sagelib installation. Fixed now, tamed the cleaner.
comment:96 Changed 10 months ago by
- Status changed from needs_review to positive_review
seems to work for me (without --enable-editable
).
comment:97 Changed 10 months ago by
Thank you!
comment:98 Changed 10 months ago by
- Branch changed from u/mkoeppe/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup to f84730e30ff7ac94f5f5990eb5a28744ac2932b3
- Resolution set to fixed
- Status changed from positive_review to closed
Last 10 new commits:
src/sage/tests: Move Extension options from src/module_list.py to distutils directives
src/sage/structure: Move Extension options from src/module_list.py to distutils directives
src/sage/stats: Move Extension options from src/module_list.py to distutils directives
src/sage/schemes: Move Extension options from src/module_list.py to distutils directives
src/sage/modular/pollack_stevens/dist.pyx: Add missing distutils directives
Remove self-listing in distutils sources directive
sage.env.cython_aliases: Fix for systems without zlib pc
Merge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29785/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_3__get_rid_of_uname_specific_
Merge branch 't/29785/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_3__get_rid_of_uname_specific_' into t/29847/install_sage_setup_with_pip__move_sage_include_directories__cython_aliases_from_sage_env_to_sage_setup
sage_setup.command.sage_build_cython: Use SAGE_GMP_PREFIX, SAGE_NTL_PREFIX for header dependencies instead of SAGE_INC