Opened 10 months ago

Closed 10 months ago

#29840 closed enhancement (fixed)

Document choice of base ring of incidence matrix and adjacency matrices

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: polyhedra, incidence matrix, adjacency
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 5b4d3d7 (Commits, GitHub, GitLab) Commit: 5b4d3d7776546f89312f20bec56eb40d46baa5f9
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

Currently incidence matrix and adjacency matrices of polyhedra/cones/lattice polytopes are set up with base ring ZZ.

This ticket documents this.

Change History (10)

comment:1 Changed 10 months ago by gh-kliem

  • Branch set to public/29840
  • Cc jipilab gh-LaisRast added
  • Commit set to a4576d633d8a2890c8ce0482288d686a4896ecc1
  • Status changed from new to needs_review

New commits:

​a4576d6set up incidence/adjacency matrix with GF(2)

comment:2 follow-up: Changed 10 months ago by mkoeppe

I don't think that GF(2) is more natural. ZZ is more natural for incidence matrices one can express various counting questions using it (row sum, column sum...)

comment:3 in reply to: ↑ 2 ; follow-up: Changed 10 months ago by gh-kliem

Replying to mkoeppe:

I don't think that GF(2) is more natural. ZZ is more natural for incidence matrices one can express various counting questions using it (row sum, column sum...)

Ok, I never thought of this one...

comment:4 Changed 10 months ago by gh-kliem

  • Branch public/29840 deleted
  • Commit a4576d633d8a2890c8ce0482288d686a4896ecc1 deleted
  • Milestone changed from sage-9.2 to sage-duplicate/invalid/wontfix

comment:5 Changed 10 months ago by gh-kliem

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-9.2
  • Status changed from needs_review to needs_work

comment:6 in reply to: ↑ 3 Changed 10 months ago by gh-kliem

Replying to gh-kliem:

Replying to mkoeppe:

I don't think that GF(2) is more natural. ZZ is more natural for incidence matrices one can express various counting questions using it (row sum, column sum...)

Ok, I never thought of this one...

Well, I have used it in the past, but I just forgot. I think we should use this ticket to add those examples. Because ZZ vs GF(2) is a design decision that was never documented. At least not with a doctest.

comment:7 Changed 10 months ago by gh-kliem

  • Branch set to public/29840-reb
  • Commit set to 5b4d3d7776546f89312f20bec56eb40d46baa5f9
  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Summary changed from Incidence matrix and adjacency matrix mod 2 to Document choice of base ring of incidence matrix and adjacency matrices

New commits:

​5b4d3d7document choice of base ring

comment:8 Changed 10 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

Nice!

comment:9 Changed 10 months ago by gh-kliem

Thank you. This way I'm hopefully the last person trying this.

comment:10 Changed 10 months ago by vbraun

  • Branch changed from public/29840-reb to 5b4d3d7776546f89312f20bec56eb40d46baa5f9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.