Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#29834 closed defect (fixed)

convert cunningham_tables to a new style package

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.2
Component: packages: optional Keywords:
Cc: mkoeppe, jdemeyer Merged in:
Authors: Dima Pasechnik Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: dcae6e7 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

tarball - see checksums.ini

Change History (18)

comment:1 Changed 2 years ago by dimpase

  • Summary changed from conver cunningham_tables to a new style package to convert cunningham_tables to a new style package

comment:2 Changed 2 years ago by git

  • Commit changed from 19095288fdd60da4a075ac9c0f9447303e93880d to 5066177ea5f0119ab8363d07ac925b6133c5d105

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​5066177convert cunningham_tables to a new style package

comment:3 Changed 2 years ago by git

  • Commit changed from 5066177ea5f0119ab8363d07ac925b6133c5d105 to ede9b61fd7c151babd1853d4995e7395db41f5f2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ede9b61convert cunningham_tables to a new style package

comment:4 Changed 2 years ago by mkoeppe

Is main.gz really supposed to be on the branch?

comment:5 Changed 2 years ago by git

  • Commit changed from ede9b61fd7c151babd1853d4995e7395db41f5f2 to 1c9e941ed315cafa15eb3913b577c91aaba4ee51

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​1c9e941convert cunningham_tables to a new style package

comment:6 Changed 2 years ago by dimpase

  • Status changed from new to needs_review

comment:7 Changed 2 years ago by git

  • Commit changed from 1c9e941ed315cafa15eb3913b577c91aaba4ee51 to dcae6e74e1998d3e663e2483ea5bd335ee01eb7d

Branch pushed to git repo; I updated commit sha1. New commits:

​dcae6e7correct doctest tags

comment:8 Changed 2 years ago by dimpase

doctests now are back, and work, too.

comment:9 Changed 2 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:10 Changed 2 years ago by slelievre

  • Cc jdemeyer added

comment:11 follow-up: Changed 2 years ago by slelievre

The file build/pkgs/cunningham_tables/read_cunningham_prime_factors.py starts: 

+# python2/Sage script used to create the package
+# (needs porting to python3 Sage)

Was that done? If so, consider removing the comment -- in a follow-up ticket if it's too late here.

comment:12 Changed 2 years ago by slelievre

Also, a download url at archive.org scares me a little as brittle.

comment:13 Changed 2 years ago by slelievre

Software Heritage to the rescue?

comment:15 in reply to: ↑ 11 ; follow-up: Changed 2 years ago by dimpase

Replying to slelievre:

The file build/pkgs/cunningham_tables/read_cunningham_prime_factors.py starts: 

+# python2/Sage script used to create the package
+# (needs porting to python3 Sage)

Was that done? If so, consider removing the comment -- in a follow-up ticket if it's too late here.

no, I added this comment -- this script is broken atm, in the sense it doesn't work with Python3-based Sage.

comment:16 in reply to: ↑ 15 Changed 2 years ago by slelievre

Replying to dimpase:

Replying to slelievre: 

+# (needs porting to python3 Sage)

Was that done? If so, consider removing the comment -- in a follow-up ticket if it's too late here.

no, I added this comment -- this script is broken atm, in the sense it doesn't work with Python3-based Sage.

Is there a follow-up ticket for that? Sage 9.2 will be Py3-only.

comment:17 Changed 2 years ago by vbraun

  • Branch changed from u/dimpase/packages/cutables to dcae6e74e1998d3e663e2483ea5bd335ee01eb7d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:18 Changed 2 years ago by dimpase

  • Commit dcae6e74e1998d3e663e2483ea5bd335ee01eb7d deleted

the script in question is only needed to create the package source; as long as we are happy with what we have, no need to run it, so it can be left as it is for the time being.

Last edited 2 years ago by dimpase (previous) (diff)
Note: See TracTickets for help on using tickets.