Opened 2 years ago

Closed 16 months ago

#29827 closed enhancement (invalid)

Upgrade gcc to 9.3

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: John Palmieri, Zachary L Scherr Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/upgrade_gcc_to_9_3 (Commits, GitHub, GitLab) Commit: d07ba7bb91dcae08ca35e1f2f9ff710945169495
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

We upgrade gcc from 9.2 to 9.3

https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=9.3

part of #29703

tarball: see checksums.ini [upstream_url]

Previous update:

Change History (12)

comment:1 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Description: modified (diff)

comment:2 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/upgrade_gcc_to_9_3

comment:3 Changed 2 years ago by Matthias Köppe

Commit: ff3bb3a106d22290e942f3cb5192b406bc2a09a6
Description: modified (diff)

New commits:

ff3bb3abuild/pkgs/gcc: Update to 9.3.0

comment:4 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:5 Changed 19 months ago by git

Commit: ff3bb3a106d22290e942f3cb5192b406bc2a09a6cd596127918fdbdc4de07206b4b7add22b5e05d5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9eb8b21build/pkgs/gcc: Update to 9.3.0
cd59612build/pkgs/gcc: Remove libsanitizer patches (upstreamed)

comment:6 Changed 19 months ago by Matthias Köppe

Reviewers: https://github.com/mkoeppe/sage/actions/runs/615728756
Status: newneeds_review

comment:7 Changed 19 months ago by Matthias Köppe

Status: needs_reviewneeds_work

Patches need updating

gfortran-9.3.0]   Applying patches from ../patches...
  [gfortran-9.3.0]   Applying ../patches/gcc-multilib-multiarch.patch
  [gfortran-9.3.0]   patching file gcc/config/i386/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/mips/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/rs6000/t-linux
  [gfortran-9.3.0]   Hunk #1 succeeded at 2 with fuzz 2.
  [gfortran-9.3.0]   patching file gcc/config/rs6000/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/s390/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/sparc/t-linux64
  [gfortran-9.3.0]   Applying ../patches/homebrew-9.2.0-catalina.patch
  [gfortran-9.3.0]   patching file fixincludes/fixincl.x
  [gfortran-9.3.0]   Hunk #1 FAILED at 2.
  [gfortran-9.3.0]   Hunk #2 FAILED at 15.
  [gfortran-9.3.0]   Hunk #3 succeeded at 2686 (offset 50 lines).
  [gfortran-9.3.0]   Hunk #4 FAILED at 10388.
  [gfortran-9.3.0]   Hunk #5 succeeded at 10558 (offset 100 lines).
  [gfortran-9.3.0]   Hunk #6 succeeded at 11071 (offset 106 lines).
  [gfortran-9.3.0]   3 out of 6 hunks FAILED -- saving rejects to file fixincludes/fixincl.x.rej
  [gfortran-9.3.0]   patching file fixincludes/inclhack.def
  [gfortran-9.3.0]   Hunk #1 succeeded at 1325 (offset 27 lines).
  [gfortran-9.3.0]   Error applying '../patches/homebrew-9.2.0-catalina.patch'

https://github.com/mkoeppe/sage/runs/2017617134?check_suite_focus=true

comment:8 Changed 19 months ago by git

Commit: cd596127918fdbdc4de07206b4b7add22b5e05d5d07ba7bb91dcae08ca35e1f2f9ff710945169495

Branch pushed to git repo; I updated commit sha1. New commits:

d07ba7bbuild/pkgs/gcc/patches: Remove

comment:9 Changed 19 months ago by Matthias Köppe

Cc: John Palmieri Zachary L Scherr added

As @gh-zlscherr reports in #31326, upgrading to gcc 9.3 does NOT fix the issues on macOS Big Sur.

homebrew:

Not sure if anyone has a backport to the GCC 9.x series

comment:10 Changed 19 months ago by Matthias Köppe

Authors: Matthias Koeppe
Milestone: sage-9.3sage-duplicate/invalid/wontfix
Reviewers: https://github.com/mkoeppe/sage/actions/runs/615728756
Status: needs_workneeds_review

I had thought that staying for a while on the GCC 9.x series would be useful - given how many fixes were necessary in packages for the 10.x series, there may still be optional/experimental/user packages that cannot be built with GCC 10.

But it looks like this is not going anywhere, so let's move on and continue in #29703 with an upgrade to 10.x

comment:11 Changed 19 months ago by John Palmieri

Status: needs_reviewpositive_review

Sounds okay.

comment:12 Changed 16 months ago by Frédéric Chapoton

Resolution: invalid
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.