Opened 2 years ago
Closed 2 years ago
#29825 closed enhancement (fixed)
Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/bin
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  build  Keywords:  
Cc:  mjo, fbissey, arojas, vbraun  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  John Palmieri, François Bissey 
Report Upstream:  N/A  Work issues:  
Branch:  7c91fb4 (Commits, GitHub, GitLab)  Commit:  7c91fb4a9a46c5a52cafab012ff7342421e73781 
Dependencies:  #21559, #29929, #30088  Stopgaps: 
Description (last modified by )
We remove some unused environment variables from the sage runtime environment.
Part of Metaticket #21707: Split sageenv into 5 to clean up sage configuration
Change History (25)
comment:1 Changed 2 years ago by
 Branch set to u/mkoeppe/clean_up_for_src_bin_sage_env
comment:2 Changed 2 years ago by
 Commit set to 20b81cc091936228d8c1355e98a96c6e2bf95b09
 Description modified (diff)
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
 Cc mjo added
comment:4 Changed 2 years ago by
 Description modified (diff)
comment:5 Changed 2 years ago by
 Cc fbissey arojas added
comment:6 Changed 2 years ago by
 Reviewers set to John Palmieri
 Status changed from needs_review to positive_review
Looks okay to me.
comment:7 Changed 2 years ago by
Thanks!
comment:8 Changed 2 years ago by
 Branch changed from u/mkoeppe/clean_up_for_src_bin_sage_env to 20b81cc091936228d8c1355e98a96c6e2bf95b09
 Resolution set to fixed
 Status changed from positive_review to closed
comment:9 Changed 2 years ago by
 Commit 20b81cc091936228d8c1355e98a96c6e2bf95b09 deleted
 Resolution fixed deleted
 Status changed from closed to new
This breaks sage sdist
which is part of the release process:
rm f /openblas.pc (echo "Name: openblas"; echo "Description: OpenBLAS"; echo "Version: 0.3"; echo "Libs: lopenblas ") > "/openblas.pc" /bin/sh: /openblas.pc: Permission denied make[1]: *** [Makefile:59: /openblas.pc] Error 1 make[1]: Leaving directory '/home/release/Sage/build/make' make: *** [Makefile:1766: downloadforsdist] Error 2
comment:10 Changed 2 years ago by
 Cc vbraun added
 Dependencies set to #21559
 Summary changed from Cleanup for src/bin/sageenv to Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/
comment:11 Changed 2 years ago by
 Summary changed from Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/ to Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/, add "make dist" testing to tox.ini
comment:12 Changed 2 years ago by
 Dependencies changed from #21559 to #21559, #29929
 Summary changed from Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/, add "make dist" testing to tox.ini to Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/
comment:13 Changed 2 years ago by
 Dependencies changed from #21559, #29929 to #21559, #29929, #30088
comment:14 Changed 2 years ago by
 Branch changed from 20b81cc091936228d8c1355e98a96c6e2bf95b09 to u/mkoeppe/20b81cc091936228d8c1355e98a96c6e2bf95b09
comment:15 Changed 2 years ago by
 Commit set to c1eb3ea3da350a426cdfc4832bcd6a225eb70586
comment:16 Changed 2 years ago by
 Status changed from new to needs_review
comment:17 Changed 2 years ago by
 Summary changed from Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/ to Cleanup for src/bin/sageenv, move src/bin/sageclonesource, src/bin/sagesdist to build/bin
comment:18 Changed 2 years ago by
 Reviewers changed from John Palmieri to John Palmieri, François Bissey
 Status changed from needs_review to positive_review
LGTM. This is all fairly minor spring cleaning. Apart from the dist
stuff which was annoying.
comment:19 Changed 2 years ago by
Thanks.
comment:20 Changed 2 years ago by
 Status changed from positive_review to needs_work
[sagelib9.2.beta6] copying bin/sagecachegrind > build/scripts3.7 [sagelib9.2.beta6] copying bin/sagecallgrind > build/scripts3.7 [sagelib9.2.beta6] copying bin/sagemassif > build/scripts3.7 [sagelib9.2.beta6] copying bin/sageomega > build/scripts3.7 [sagelib9.2.beta6] copying bin/sagevalgrind > build/scripts3.7 [sagelib9.2.beta6] copying bin/sageversion.sh > build/scripts3.7 [sagelib9.2.beta6] copying and adjusting bin/sagecleaner > build/scripts3.7 [sagelib9.2.beta6] copying and adjusting bin/sagelistpackages > build/scripts3.7 [sagelib9.2.beta6] error: file '/home/release/Sage/src/bin/sageclonesource' does not exist [sagelib9.2.beta6] [sagelib9.2.beta6] real 5m25.685s [sagelib9.2.beta6] user 49m14.730s [sagelib9.2.beta6] sys 1m10.018s make[4]: *** [Makefile:2090: sagelibnodeps] Error 1 make[4]: Leaving directory '/home/release/Sage/build/make' make[3]: *** [Makefile:2090: /home/release/Sage/local/var/lib/sage/installed/sagelib9.2.beta6] Error 2 make[3]: Leaving directory '/home/release/Sage/build/make' make[2]: *** [Makefile:1701: allstart] Error 2 make[2]: Leaving directory '/home/release/Sage/build/make'
comment:21 Changed 2 years ago by
 Commit changed from c1eb3ea3da350a426cdfc4832bcd6a225eb70586 to 7c91fb4a9a46c5a52cafab012ff7342421e73781
Branch pushed to git repo; I updated commit sha1. New commits:
7c91fb4  src/setup.py: Remove sageclonesource, sagesdist from list of installed sagelib scripts

comment:22 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:23 Changed 2 years ago by
 Status changed from needs_review to positive_review
Now, that's something I should have checked. All good now as far as I can see it.
comment:24 Changed 2 years ago by
Thanks!
comment:25 Changed 2 years ago by
 Branch changed from u/mkoeppe/20b81cc091936228d8c1355e98a96c6e2bf95b09 to 7c91fb4a9a46c5a52cafab012ff7342421e73781
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
src/bin/sageenvconfig.in: Do not export CONFIGURED_CC etc. and SAGE_PKG_CONFIG_PATH; only used in sageenv
build/make/install: Move SAGE_SPKG_SCRIPTS here from src/bin/sageenv; only used during build
src/bin/sageenv: Do not set SAGE_PKGCONFIG; only use in build/ and already set in build/make/install