Opened 2 years ago

Closed 2 years ago

#29824 closed enhancement (fixed)

add lmfdb_page for Dirichlet characters

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: number theory Keywords:
Cc: Alex J. Best, John Cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 39481ec (Commits, GitHub, GitLab) Commit: 39481ec56944eef6339cb1aa331499c902f28bc4
Dependencies: Stopgaps:

Status badges

Description

as exists already for number fields and elliptic curves

Change History (15)

comment:1 Changed 2 years ago by Frédéric Chapoton

Branch: u/chapoton/29824
Cc: Alex J. Best added
Commit: 8b4a46818fe738435e52357273fdfd2042a3410f
Status: newneeds_info

just a first sketch, through pari, probably not working yet


New commits:

8b4a468first step towards adding LMFDB link for Dirichlet characters

comment:2 Changed 2 years ago by git

Commit: 8b4a46818fe738435e52357273fdfd2042a3410f2454d9ca66e5254829dee138a46185486168a629

Branch pushed to git repo; I updated commit sha1. New commits:

2454d9cwork on lmfdb_page for Dirichlet characters

comment:3 Changed 2 years ago by git

Commit: 2454d9ca66e5254829dee138a46185486168a62968b8e4b959c0e7a7f82c7d2d85a29a24bb54967f

Branch pushed to git repo; I updated commit sha1. New commits:

68b8e4bmore work on Dirichlet characters, pari and LMFDB

comment:4 Changed 2 years ago by git

Commit: 68b8e4b959c0e7a7f82c7d2d85a29a24bb54967fe77b93719240e3884b9dcd2cf61e52afeab75eec

Branch pushed to git repo; I updated commit sha1. New commits:

e77b937one more example for Conrey number

comment:5 Changed 2 years ago by git

Commit: e77b93719240e3884b9dcd2cf61e52afeab75eecb3c1b37ca3c6da29b6cf0cc6dcdf49761a3dea30

Branch pushed to git repo; I updated commit sha1. New commits:

b3c1b37another example for Conrey number

comment:6 Changed 2 years ago by git

Commit: b3c1b37ca3c6da29b6cf0cc6dcdf49761a3dea309baeee71459a0866523bd52c391812d3f613083e

Branch pushed to git repo; I updated commit sha1. New commits:

9baeee7fix values of L-functions

comment:7 Changed 2 years ago by Frédéric Chapoton

Cc: John Cremona added
Status: needs_infoneeds_review

This should be ready to go now.

I have moved the creation of pari data from L-functions to Dirichlet characters file.

And fixed this conversion by the way.

comment:8 Changed 2 years ago by git

Commit: 9baeee71459a0866523bd52c391812d3f613083ed8dc0f00b6faf1cf295ea4af20b65e7d2b523aba

Branch pushed to git repo; I updated commit sha1. New commits:

d8dc0f0details

comment:9 Changed 2 years ago by git

Commit: d8dc0f00b6faf1cf295ea4af20b65e7d2b523aba39481ec56944eef6339cb1aa331499c902f28bc4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

39481ecfirst step towards adding LMFDB link for Dirichlet characters

comment:10 Changed 2 years ago by Frédéric Chapoton

green bot, please review

comment:11 Changed 2 years ago by John Cremona

I will look at it later today. It would be nice to have an explanation of why some of the numbers output by doctests have changed.

comment:12 Changed 2 years ago by Frédéric Chapoton

Concerning the changed numbers : apparently the conversion of Dirichlet characters was not working correctly, so the L-function was computed for another character. I checked the new values purely in pari, and they are now correct.

comment:13 Changed 2 years ago by John Cremona

Status: needs_reviewpositive_review

Looks good to me.

One day we might include Bober's pip-installable package https://github.com/jwbober/conrey-dirichlet-characters. At that time, somce of the code in https://github.com/JohnCremona/CMFs/blob/master/sage-pari/char.py might be useful.

comment:14 Changed 2 years ago by Matthias Köppe

Reviewers: John Cremona

comment:15 Changed 2 years ago by Volker Braun

Branch: u/chapoton/2982439481ec56944eef6339cb1aa331499c902f28bc4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.