Opened 2 years ago
Closed 2 years ago
#29824 closed enhancement (fixed)
add lmfdb_page for Dirichlet characters
Reported by:  Frédéric Chapoton  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  number theory  Keywords:  
Cc:  Alex J. Best, John Cremona  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  John Cremona 
Report Upstream:  N/A  Work issues:  
Branch:  39481ec (Commits, GitHub, GitLab)  Commit:  39481ec56944eef6339cb1aa331499c902f28bc4 
Dependencies:  Stopgaps: 
Description
as exists already for number fields and elliptic curves
Change History (15)
comment:1 Changed 2 years ago by
Branch:  → u/chapoton/29824 

Cc:  Alex J. Best added 
Commit:  → 8b4a46818fe738435e52357273fdfd2042a3410f 
Status:  new → needs_info 
comment:2 Changed 2 years ago by
Commit:  8b4a46818fe738435e52357273fdfd2042a3410f → 2454d9ca66e5254829dee138a46185486168a629 

Branch pushed to git repo; I updated commit sha1. New commits:
2454d9c  work on lmfdb_page for Dirichlet characters

comment:3 Changed 2 years ago by
Commit:  2454d9ca66e5254829dee138a46185486168a629 → 68b8e4b959c0e7a7f82c7d2d85a29a24bb54967f 

Branch pushed to git repo; I updated commit sha1. New commits:
68b8e4b  more work on Dirichlet characters, pari and LMFDB

comment:4 Changed 2 years ago by
Commit:  68b8e4b959c0e7a7f82c7d2d85a29a24bb54967f → e77b93719240e3884b9dcd2cf61e52afeab75eec 

Branch pushed to git repo; I updated commit sha1. New commits:
e77b937  one more example for Conrey number

comment:5 Changed 2 years ago by
Commit:  e77b93719240e3884b9dcd2cf61e52afeab75eec → b3c1b37ca3c6da29b6cf0cc6dcdf49761a3dea30 

Branch pushed to git repo; I updated commit sha1. New commits:
b3c1b37  another example for Conrey number

comment:6 Changed 2 years ago by
Commit:  b3c1b37ca3c6da29b6cf0cc6dcdf49761a3dea30 → 9baeee71459a0866523bd52c391812d3f613083e 

Branch pushed to git repo; I updated commit sha1. New commits:
9baeee7  fix values of Lfunctions

comment:7 Changed 2 years ago by
Cc:  John Cremona added 

Status:  needs_info → needs_review 
This should be ready to go now.
I have moved the creation of pari data from Lfunctions to Dirichlet characters file.
And fixed this conversion by the way.
comment:8 Changed 2 years ago by
Commit:  9baeee71459a0866523bd52c391812d3f613083e → d8dc0f00b6faf1cf295ea4af20b65e7d2b523aba 

Branch pushed to git repo; I updated commit sha1. New commits:
d8dc0f0  details

comment:9 Changed 2 years ago by
Commit:  d8dc0f00b6faf1cf295ea4af20b65e7d2b523aba → 39481ec56944eef6339cb1aa331499c902f28bc4 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
39481ec  first step towards adding LMFDB link for Dirichlet characters

comment:11 Changed 2 years ago by
I will look at it later today. It would be nice to have an explanation of why some of the numbers output by doctests have changed.
comment:12 Changed 2 years ago by
Concerning the changed numbers : apparently the conversion of Dirichlet characters was not working correctly, so the Lfunction was computed for another character. I checked the new values purely in pari, and they are now correct.
comment:13 Changed 2 years ago by
Status:  needs_review → positive_review 

Looks good to me.
One day we might include Bober's pipinstallable package https://github.com/jwbober/conreydirichletcharacters. At that time, somce of the code in https://github.com/JohnCremona/CMFs/blob/master/sagepari/char.py might be useful.
comment:14 Changed 2 years ago by
Reviewers:  → John Cremona 

comment:15 Changed 2 years ago by
Branch:  u/chapoton/29824 → 39481ec56944eef6339cb1aa331499c902f28bc4 

Resolution:  → fixed 
Status:  positive_review → closed 
just a first sketch, through pari, probably not working yet
New commits:
first step towards adding LMFDB link for Dirichlet characters