Opened 2 years ago

Closed 2 years ago

#29821 closed enhancement (fixed)

allow to generate bigger hypergraphs with nauty using genbgL

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords: nauty
Cc: slelievre, dcoudert Merged in:
Authors: Dima Pasechnik Reviewers: David Coudert, Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 03bd63f (Commits, GitHub, GitLab) Commit: 03bd63ff607438d442a140f731e20bb1a53db4cd
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

As reported ​on sage-support, bigger hypergraphs are easy to generate if a different nauty routine is used.

Here we implement this.

Change History (15)

comment:1 Changed 2 years ago by dimpase

branch is coming

comment:2 Changed 2 years ago by dimpase

  • Branch set to u/dimpase/graphs/genbgL
  • Commit set to c907930275120ce3b3e883dac832d19467bb100c
  • Status changed from new to needs_review

New commits:

​c907930replace genbg by genbgL, add tests

comment:3 Changed 2 years ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Keywords nauty added
  • Summary changed from allow to generate bigger hypergraphs with nauty to allow to generate bigger hypergraphs with nauty using genbgL

Missing closing double-backtick, and maybe spell out "minus": 

- at most 64-``number_of_vertices
+ at most 64 minus ``number_of_vertices``

Missing blank line between 

    TESTS::

and the test block it introduces.

comment:4 Changed 2 years ago by git

  • Commit changed from c907930275120ce3b3e883dac832d19467bb100c to 14d8d511d999ca391bb1913176265d93f0b1e39d

Branch pushed to git repo; I updated commit sha1. New commits:

​14d8d51typos noted by reviewer

comment:5 Changed 2 years ago by dimpase

ok, fixed

comment:6 Changed 2 years ago by dimpase

ping?

comment:7 Changed 2 years ago by dimpase

  • Cc dcoudert added

comment:8 Changed 2 years ago by dcoudert

may be it's time to update the link to nauty to ​https://pallini.di.uniroma1.it

also, some pep8 comments 

-        if number_of_sets+number_of_vertices > 64:
+        if number_of_sets + number_of_vertices > 64:

-        sp = subprocess.Popen(nautyprefix+"genbgL {0}".format(nauty_input), shell=True,
+        sp = subprocess.Popen(nautyprefix + "genbgL {0}".format(nauty_input), shell=True,

comment:9 Changed 2 years ago by git

  • Commit changed from 14d8d511d999ca391bb1913176265d93f0b1e39d to 03bd63ff607438d442a140f731e20bb1a53db4cd

Branch pushed to git repo; I updated commit sha1. New commits:

​03bd63fPEP8 fixes

comment:10 Changed 2 years ago by dimpase

fixed PEP8 - and will do the URL changes on nauty update ticket.

comment:11 follow-up: Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:12 Changed 2 years ago by dimpase

I checked that both uniroma and ANU urls are mentioned in SPKG-install.txt And, by the way, please review the nauty update ticket #26891

comment:13 in reply to: ↑ 11 Changed 2 years ago by dimpase

Replying to dcoudert:

LGTM.

Thanks

comment:14 Changed 2 years ago by slelievre

  • Reviewers changed from David Coudert to David Coudert, Samuel Lelièvre

Thanks!

comment:15 Changed 2 years ago by vbraun

  • Branch changed from u/dimpase/graphs/genbgL to 03bd63ff607438d442a140f731e20bb1a53db4cd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.