Opened 14 months ago

Closed 2 weeks ago

#29811 closed enhancement (fixed)

PolyhedronFace: Add method to compute affine tangent cones

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: jipilab, gh-kliem, mjo, yzh, tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 5965400 (Commits, GitHub, GitLab) Commit: 5965400139f4ff4e3a589a2d71ad8ff3674d87b1
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

In analogy to the existing method normal_cone.

For #29806 (Gram-Brianchon formula) I only need the (affine) tangent cones of a face, tcone(P, F). See for example https://epubs.siam.org/doi/pdf/10.1137/1.9781611972443.ch6 Def 6.2.2

Change History (12)

comment:1 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:2 Changed 10 months ago by mjo

  • Cc mjo added

comment:3 Changed 5 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:4 Changed 3 months ago by mkoeppe

  • Cc yzh added

comment:5 Changed 6 weeks ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Description modified (diff)
  • Summary changed from PolyhedronFace: Add methods to compute cones of feasible directions and affine tangent cones to PolyhedronFace: Add method to compute affine tangent cones

comment:6 Changed 6 weeks ago by mkoeppe

  • Branch set to u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones

comment:7 Changed 6 weeks ago by mkoeppe

  • Commit set to 5965400139f4ff4e3a589a2d71ad8ff3674d87b1
  • Status changed from new to needs_review

New commits:

5965400PolyhedronFace.affine_tangent_cone: New

comment:8 Changed 5 weeks ago by mkoeppe

Patchbot is green modulo the unrelated misc/package failure

comment:9 Changed 2 weeks ago by mkoeppe

  • Cc tscrim added

comment:10 Changed 2 weeks ago by gh-kliem

  • Status changed from needs_review to positive_review

LGTM.

comment:11 Changed 2 weeks ago by mkoeppe

  • Reviewers set to Jonathan Kliem

Thanks!

comment:12 Changed 2 weeks ago by vbraun

  • Branch changed from u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones to 5965400139f4ff4e3a589a2d71ad8ff3674d87b1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.