Opened 2 years ago

Closed 2 years ago

#29804 closed enhancement (fixed)

pycodestyle: fix graph.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 64f66d4 (Commits, GitHub, GitLab) Commit: 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec
Dependencies: Stopgaps:

Status badges

Description

The patchbot frequently reports some pycodestyle errors due to statements like if certificate: return Graph(). We fix this in graph.py.

Change History (6)

comment:1 Changed 2 years ago by chapoton 

pep --select=E701 .
./graph.py:1129:34: E701 multiple statements on one line (colon)
./graph.py:1130:34: E701 multiple statements on one line (colon)
./graph.py:1136:34: E701 multiple statements on one line (colon)
./graph.py:1143:34: E701 multiple statements on one line (colon)
./graph.py:1166:29: E701 multiple statements on one line (colon)
./graph.py:1167:34: E701 multiple statements on one line (colon)
./graph.py:1168:32: E701 multiple statements on one line (colon)
./graph.py:1216:29: E701 multiple statements on one line (colon)
./graph.py:1217:32: E701 multiple statements on one line (colon)
./graph.py:1256:30: E701 multiple statements on one line (colon)
./graph.py:2804:27: E701 multiple statements on one line (colon)
./graph.py:2805:27: E701 multiple statements on one line (colon)
./graph.py:2806:17: E701 multiple statements on one line (colon)
./graph_database.py:312:28: E701 multiple statements on one line (colon)
./graph_database.py:414:28: E701 multiple statements on one line (colon)
./graph_database.py:441:37: E701 multiple statements on one line (colon)
./graph_database.py:442:36: E701 multiple statements on one line (colon)
./graph_database.py:443:36: E701 multiple statements on one line (colon)
./graph_database.py:444:33: E701 multiple statements on one line (colon)
./graph_database.py:445:37: E701 multiple statements on one line (colon)
./graph_database.py:484:41: E701 multiple statements on one line (colon)
./graph_database.py:485:40: E701 multiple statements on one line (colon)
./graph_database.py:486:40: E701 multiple statements on one line (colon)
./graph_database.py:487:37: E701 multiple statements on one line (colon)
./graph_database.py:488:41: E701 multiple statements on one line (colon)
./graph_database.py:503:39: E701 multiple statements on one line (colon)
./graph_database.py:504:44: E701 multiple statements on one line (colon)
./graph_database.py:505:44: E701 multiple statements on one line (colon)
./graph_database.py:506:41: E701 multiple statements on one line (colon)
./graph_database.py:507:45: E701 multiple statements on one line (colon)
./graph_database.py:657:13: E701 multiple statements on one line (colon)
./graph_input.py:341:26: E701 multiple statements on one line (colon)
./graph_input.py:422:26: E701 multiple statements on one line (colon)
./graph_plot.py:593:41: E701 multiple statements on one line (colon)
./generators/basic.py:1090:23: E701 multiple statements on one line (colon)
./generators/basic.py:1091:23: E701 multiple statements on one line (colon)
./generators/basic.py:1093:21: E701 multiple statements on one line (colon)
./generators/basic.py:1117:18: E701 multiple statements on one line (colon)
./generators/basic.py:1118:17: E701 multiple statements on one line (colon)

comment:2 Changed 2 years ago by dcoudert

  • Branch set to public/graphs/29804_pycodestyle_in_graph
  • Commit set to 592b4f256823d2677235feb0178ee787009eec3b

New commits:

​592b4f2fix pycodestyle in graph.py

comment:3 Changed 2 years ago by git

  • Commit changed from 592b4f256823d2677235feb0178ee787009eec3b to 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec

Branch pushed to git repo; I updated commit sha1. New commits:

​f54d5f8fix pycodestyle in graph_database.py
​27b8e27fix pycodestyle in graph_input.py
​90de346fix pycodestyle in graph_plot.py
​64f66d4fix pycodestyle in generators/basic.py

comment:4 Changed 2 years ago by dcoudert

  • Status changed from new to needs_review

Thank you for pointing all the issues.

comment:5 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good. Merci. Jette un oeil à #29807 si tu peux.

comment:6 Changed 2 years ago by vbraun

  • Branch changed from public/graphs/29804_pycodestyle_in_graph to 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.