Opened 2 years ago
Closed 2 years ago
#29804 closed enhancement (fixed)
pycodestyle: fix graph.py
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | ||
Authors: | David Coudert | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 64f66d4 (Commits, GitHub, GitLab) | Commit: | 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec |
Dependencies: | Stopgaps: |
Description
The patchbot frequently reports some pycodestyle errors due to statements like
if certificate: return Graph()
. We fix this in graph.py
.
Change History (6)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
- Branch set to public/graphs/29804_pycodestyle_in_graph
- Commit set to 592b4f256823d2677235feb0178ee787009eec3b
New commits:
592b4f2 | fix pycodestyle in graph.py
|
comment:3 Changed 2 years ago by
- Commit changed from 592b4f256823d2677235feb0178ee787009eec3b to 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec
comment:4 Changed 2 years ago by
- Status changed from new to needs_review
Thank you for pointing all the issues.
comment:5 Changed 2 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, looks good. Merci. Jette un oeil à #29807 si tu peux.
comment:6 Changed 2 years ago by
- Branch changed from public/graphs/29804_pycodestyle_in_graph to 64f66d4a7dd4b3645b7851f83c50cdceeef7c8ec
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.