Opened 2 years ago
Closed 2 years ago
#29800 closed enhancement (fixed)
Make categories of Polyhedra parent more precise
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  geometry  Keywords:  
Cc:  tscrim, jipilab  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  c3d5c00 (Commits, GitHub, GitLab)  Commit:  c3d5c0090a0aa81f6eb70bebfe5cc1feb7c27f76 
Dependencies:  Stopgaps: 
Description (last modified by )
For a given dimension and base ring, there are infinitely many polyhedra if and only if the ambient dimension is positive.
Change History (16)
comment:1 Changed 2 years ago by
 Description modified (diff)
comment:2 Changed 2 years ago by
 Branch set to u/mkoeppe/make_categories_of_polyhedra_parent_more_precise
comment:3 Changed 2 years ago by
 Commit set to abe3d8b8a3f4d46703491731895f5c0ee65175a6
 Status changed from new to needs_review
comment:4 Changed 2 years ago by
 Commit changed from abe3d8b8a3f4d46703491731895f5c0ee65175a6 to 0c4fbd1615f57fe6078130452b2920135d0b4b8b
Branch pushed to git repo; I updated commit sha1. New commits:
0c4fbd1  src/sage/geometry/polyhedron/parent.py: Make list(Polyhedra(AA, 0)) work

comment:5 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 2 years ago by
Thanks!
comment:7 Changed 2 years ago by
what about the failing doctests ?
comment:8 Changed 2 years ago by
 Status changed from positive_review to needs_work
Ah, right...I didn't think of testing the category...
comment:9 Changed 2 years ago by
There are two polyhedra in ambient dimension 0. The 0
dimensional one and the 1
dimensional one.
comment:10 Changed 2 years ago by
Ouch!
comment:11 Changed 2 years ago by
 Commit changed from 0c4fbd1615f57fe6078130452b2920135d0b4b8b to 6c2129ed5bcf6d3f8ea75966ad96aa63fa51fe89
Branch pushed to git repo; I updated commit sha1. New commits:
6c2129e  src/sage/geometry/polyhedron/parent.py: Fix up list... there is another one in dimension 0

comment:12 Changed 2 years ago by
 Commit changed from 6c2129ed5bcf6d3f8ea75966ad96aa63fa51fe89 to c3d5c0090a0aa81f6eb70bebfe5cc1feb7c27f76
Branch pushed to git repo; I updated commit sha1. New commits:
c3d5c00  src/sage/categories/polyhedra.py (PolyhedralSets): Update doctests for element_class

comment:13 Changed 2 years ago by
 Status changed from needs_work to needs_review
I've updated the category doctest  please review
comment:14 Changed 2 years ago by
 Status changed from needs_review to positive_review
Green bot, so positive review. (I like the output when ambient dimension is 1 of empty and the universe.)
comment:15 Changed 2 years ago by
Thanks!
comment:16 Changed 2 years ago by
 Branch changed from u/mkoeppe/make_categories_of_polyhedra_parent_more_precise to c3d5c0090a0aa81f6eb70bebfe5cc1feb7c27f76
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
src/sage/geometry/polyhedron/parent.py: Make categories of Polyhedra parent more precise