Opened 2 years ago
Closed 23 months ago
#29793 closed enhancement (fixed)
script packages should cd into the SPKG directory
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | build | Keywords: | |
Cc: | jhpalmieri, embray, mjo, dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Michael Orlitzky |
Report Upstream: | N/A | Work issues: | |
Branch: | 72346ef (Commits, GitHub, GitLab) | Commit: | 72346ef564fec76ad2a8411b837afbb107cb14e5 |
Dependencies: | #29345 | Stopgaps: |
Description
This simplifies several spkg-install
scripts and make script packages a bit more similar to normal packages.
This is a step towards #29386 (Install script packages via sage-spkg
).
Change History (13)
comment:1 Changed 2 years ago by
- Branch set to u/mkoeppe/script_packages_should_cd_into_the_spkg_directory
comment:2 Changed 2 years ago by
- Commit set to df3f05e03ba671dd6be502ccae96d2a6162d29d4
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
Branch is on top of #29345. There is only 1 new commit.
comment:4 Changed 2 years ago by
- Reviewers set to Michael Orlitzky
- Status changed from needs_review to positive_review
LGTM but is there some documentation that says what the initial working directory of spkg-install should be? It shouldn't be an implementation detail.
comment:5 Changed 2 years ago by
- Status changed from positive_review to needs_work
Indeed I forgot to update the documentation
comment:6 Changed 2 years ago by
- Commit changed from df3f05e03ba671dd6be502ccae96d2a6162d29d4 to 72346ef564fec76ad2a8411b837afbb107cb14e5
Branch pushed to git repo; I updated commit sha1. New commits:
72346ef | Update developer manual on script packages
|
comment:7 Changed 2 years ago by
- Status changed from needs_work to needs_review
comment:9 Changed 2 years ago by
Thank you!
comment:10 Changed 2 years ago by
- Branch changed from u/mkoeppe/script_packages_should_cd_into_the_spkg_directory to public/script_packages_should_cd_into_the_spkg_directory
- Commit changed from 72346ef564fec76ad2a8411b837afbb107cb14e5 to 7a6cb81fc71001e334f197a48758a981855537f4
rebased over rebased #29345
Last 10 new commits:
ff63210 | Trac #29345: replace a bash array with something portable.
|
bb69c7e | Trac #29345: replace a few uses of "source" with "."
|
c549738 | Trac #29345: fix some bashisms in sage-env's resolvelinks() function.
|
b445b6e | Trac #29345: don't force SHELL=bash any longer.
|
18dd124 | Trac #29345: remove "break" statements from AC_SEARCH_LIBS.
|
6a5d73f | Trac #29345: don't use sage's config.status for the lrcalc build.
|
3d8ba26 | Trac #29345: replace the function that populates the CVXOPT_* variables.
|
604657a | Trac #29345: add Dima's SPKG patches for ksh compatibility.
|
493a7e2 | build/make/Makefile.in [SCRIPT_PACKAGE_templ]: cd into the SPKG directory; adjust spkg-install scripts
|
7a6cb81 | Update developer manual on script packages
|
comment:11 Changed 2 years ago by
... but why?
comment:12 Changed 2 years ago by
- Branch changed from public/script_packages_should_cd_into_the_spkg_directory to u/mkoeppe/script_packages_should_cd_into_the_spkg_directory
- Commit changed from 7a6cb81fc71001e334f197a48758a981855537f4 to 72346ef564fec76ad2a8411b837afbb107cb14e5
comment:13 Changed 23 months ago by
- Branch changed from u/mkoeppe/script_packages_should_cd_into_the_spkg_directory to 72346ef564fec76ad2a8411b837afbb107cb14e5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
Trac #29345: replace a few obsolete "-a" tests with "-e".
Trac #29345: replace a bash array with something portable.
Trac #29345: replace a few uses of "source" with "."
Trac #29345: fix some bashisms in sage-env's resolvelinks() function.
Trac #29345: don't force SHELL=bash any longer.
Trac #29345: remove "break" statements from AC_SEARCH_LIBS.
Trac #29345: don't use sage's config.status for the lrcalc build.
Trac #29345: replace the function that populates the CVXOPT_* variables.
Trac #29345: add Dima's SPKG patches for ksh compatibility.
build/make/Makefile.in [SCRIPT_PACKAGE_templ]: cd into the SPKG directory; adjust spkg-install scripts