#29792 closed enhancement (fixed)

proper fix for "fedora-30-standard: Doctests using system brial crash"

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.2
Component: build: configure Keywords:
Cc: mjo, mkoeppe Merged in:
Authors: Dima Pasechnik Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 1ef1f87 (Commits, GitHub, GitLab) Commit: 1ef1f8784a23f3952e11d6f393c89c8068457790
Dependencies: Stopgaps:

Status badges

Description

This is a followup to #29490.

We now add code rejecting Brial 1.2.5 - provided it can be recognised from VERSION macro in polybory/config.h header. This identifies standard Brial on Fedora 30 (and possibly elsewhere, but tough luck then).

Change History (6)

comment:1 Changed 11 months ago by dimpase

  • Status changed from new to needs_review

comment:3 Changed 11 months ago by gh-kliem

Seems to work fine.

https://github.com/kliem/sage-test-27122/actions/runs/125137242

It rejects brial on fedora 30 and 31 and ubuntu eoan (all use Brial 1.2.5).

It doesn't reject Brial 1.2.4 on debian buster and Brial 1.2.7 on ubuntu focal.

comment:4 Changed 11 months ago by dimpase

it also accepts brial 1.2.8 on Gentoo lunux.

comment:5 Changed 11 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

I think this is good to go.

comment:6 Changed 10 months ago by vbraun

  • Branch changed from u/dimpase/packages/brialconfigfix to 1ef1f8784a23f3952e11d6f393c89c8068457790
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.