Opened 11 months ago

Closed 10 months ago

Last modified 9 months ago

#29791 closed enhancement (fixed)

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 6: last)

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords:
Cc: gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 802356a (Commits, GitHub, GitLab) Commit:
Dependencies: #29706 Stopgaps:

Status badges

Description (last modified by mkoeppe)

Follow-up from #29706.

It takes care of all remaining extensions.

Change History (11)

comment:1 Changed 11 months ago by mkoeppe

  • Branch set to u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_

comment:2 Changed 11 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 23558368dba0e6121feede5f121378eb4fe99616
  • Dependencies set to #29706
  • Description modified (diff)
  • Status changed from new to needs_review

Last 10 new commits:

70901easrc/sage/env.py (cython_aliases): Update doctest
eed920esrc/sage/tests: Move Extension options from src/module_list.py to distutils directives
0d25d1dsrc/sage/structure: Move Extension options from src/module_list.py to distutils directives
808f46asrc/sage/stats: Move Extension options from src/module_list.py to distutils directives
10f7542src/sage/schemes: Move Extension options from src/module_list.py to distutils directives
5867c05src/sage/modular/pollack_stevens/dist.pyx: Add missing distutils directives
c536daaRemove self-listing in distutils sources directive
9dc7022Merge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_
96b99c8src/module_list.py: Move options for Extensions in sage.matrix to distutils directives
2355836src/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

comment:3 Changed 11 months ago by git

  • Commit changed from 23558368dba0e6121feede5f121378eb4fe99616 to 6421e2c85409fef5a539299d96145e3a088826bf

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f78b06dsrc/module_list.py: Move options for Extensions in sage.libs to distutils directives
1b0e29dsrc/module_list.py: Move options for Extensions in sage.matrix to distutils directives
6421e2csrc/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

comment:4 Changed 11 months ago by git

  • Commit changed from 6421e2c85409fef5a539299d96145e3a088826bf to 802356ae870f2e798a223df2f3fc5512b4aeb693

Branch pushed to git repo; I updated commit sha1. New commits:

b1b3787sage.env.cython_aliases: Fix for systems without zlib pc
802356aMerge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_

comment:5 Changed 11 months ago by mkoeppe

  • Cc gh-kliem added

comment:6 Changed 11 months ago by gh-kliem

What about

+              depends = [SAGE_INC + "/polybori/" + hd + ".h" for hd in ["polybori", "config"]]),

Is that going to stay there? Is this being removed in a different ticket?

comment:7 Changed 11 months ago by mkoeppe

Ah right, that's a loose end...

comment:8 Changed 11 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 11 months ago by mkoeppe

Thanks!

comment:10 Changed 10 months ago by vbraun

  • Branch changed from u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_ to 802356ae870f2e798a223df2f3fc5512b4aeb693
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 9 months ago by dimpase

  • Commit 802356ae870f2e798a223df2f3fc5512b4aeb693 deleted

Is there a follow-up ticket? E.g. the polybori thing in comment:6 is still not fixed.

Note: See TracTickets for help on using tickets.