Opened 2 years ago

Closed 2 years ago

#29790 closed enhancement (fixed)

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 5: sage.graphs)

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords:
Cc: gh-kliem, David Coudert, Dima Pasechnik Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 5d5803e (Commits, GitHub, GitLab) Commit: 5d5803ef5920f894bcac69ed1268e1e03ea9dd5e
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

Follow-up from #29706 (which is NOT a dependency).

This ticket takes care of sage.graphs except for sage.graphs.graph_decompositions, which is done in #28925, and OptionalExtensions, which are done in #29720.

Change History (11)

comment:1 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:2 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_5__sage_graphs_

comment:3 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: David Coudert Dima Pasechnik added
Commit: 55bd7bab624b37aaa1474b9de09a70d03123f97d
Description: modified (diff)
Status: newneeds_review

New commits:

55bd7basrc/module_list.py: Move options for Extensions in sage.graphs to distutils directives

comment:4 Changed 2 years ago by gh-kliem

Reviewers: Jonathan Kliem
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 2 years ago by Matthias Köppe

Thanks!

comment:6 Changed 2 years ago by Matthias Köppe

Status: positive_reviewneeds_work

https://github.com/mkoeppe/sage/runs/747836383

graphs   ] WARNING: autodoc: failed to import module 'planarity' from module 'sage.graphs'; the following exception was raised:
[graphs   ] dlopen(/Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so, 2): Symbol not found: _gp_AddEdge
[graphs   ]   Referenced from: /Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so
[graphs   ]   Expected in: flat namespace

comment:7 Changed 2 years ago by git

Commit: 55bd7bab624b37aaa1474b9de09a70d03123f97d5d5803ef5920f894bcac69ed1268e1e03ea9dd5e

Branch pushed to git repo; I updated commit sha1. New commits:

5d5803esrc/sage/graphs/planarity.pyx: Add forgotten distutils directive

comment:8 Changed 2 years ago by Matthias Köppe

Status: needs_workneeds_review

comment:9 Changed 2 years ago by gh-kliem

Status: needs_reviewpositive_review

Should be fine now.

comment:10 Changed 2 years ago by Matthias Köppe

Thanks!

comment:11 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_5__sage_graphs_5d5803ef5920f894bcac69ed1268e1e03ea9dd5e
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.