Opened 2 years ago
Closed 2 years ago
#29790 closed enhancement (fixed)
Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 5: sage.graphs)
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  refactoring  Keywords:  
Cc:  ghkliem, David Coudert, Dima Pasechnik  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Jonathan Kliem 
Report Upstream:  N/A  Work issues:  
Branch:  5d5803e (Commits, GitHub, GitLab)  Commit:  5d5803ef5920f894bcac69ed1268e1e03ea9dd5e 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (11)
comment:1 Changed 2 years ago by
Description:  modified (diff) 

comment:2 Changed 2 years ago by
Branch:  → u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_5__sage_graphs_ 

comment:3 Changed 2 years ago by
Authors:  → Matthias Koeppe 

Cc:  David Coudert Dima Pasechnik added 
Commit:  → 55bd7bab624b37aaa1474b9de09a70d03123f97d 
Description:  modified (diff) 
Status:  new → needs_review 
comment:4 Changed 2 years ago by
Reviewers:  → Jonathan Kliem 

Status:  needs_review → positive_review 
LGTM.
comment:6 Changed 2 years ago by
Status:  positive_review → needs_work 

https://github.com/mkoeppe/sage/runs/747836383
graphs ] WARNING: autodoc: failed to import module 'planarity' from module 'sage.graphs'; the following exception was raised: [graphs ] dlopen(/Users/runner/runners/2.263.0/work/sage/sage/.tox/localhomebrewmacosstandard/local/lib/python3.7/sitepackages/sage/graphs/planarity.cpython37mdarwin.so, 2): Symbol not found: _gp_AddEdge [graphs ] Referenced from: /Users/runner/runners/2.263.0/work/sage/sage/.tox/localhomebrewmacosstandard/local/lib/python3.7/sitepackages/sage/graphs/planarity.cpython37mdarwin.so [graphs ] Expected in: flat namespace
comment:7 Changed 2 years ago by
Commit:  55bd7bab624b37aaa1474b9de09a70d03123f97d → 5d5803ef5920f894bcac69ed1268e1e03ea9dd5e 

Branch pushed to git repo; I updated commit sha1. New commits:
5d5803e  src/sage/graphs/planarity.pyx: Add forgotten distutils directive

comment:8 Changed 2 years ago by
Status:  needs_work → needs_review 

comment:11 Changed 2 years ago by
Branch:  u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_5__sage_graphs_ → 5d5803ef5920f894bcac69ed1268e1e03ea9dd5e 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
src/module_list.py: Move options for Extensions in sage.graphs to distutils directives