Opened 18 months ago
Closed 17 months ago
#29787 closed defect (fixed)
1 optional internet oeis doctest failing (busy beaver ordering)
Reported by:  slabbe  Owned by:  

Priority:  minor  Milestone:  sage9.2 
Component:  doctest coverage  Keywords:  
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  cf800be (Commits, GitHub, GitLab)  Commit:  cf800be33067884454dddcf7dac4760d288862e1 
Dependencies:  Stopgaps: 
Description
With SageMath version 9.2.beta0, Release Date: 20200528
sage t optional=sage,internet src/sage/databases/oeis.py
gives:
sage t long src/sage/databases/oeis.py ********************************************************************** File "src/sage/databases/oeis.py", line 489, in sage.databases.oeis.OEIS.find_by_description Failed example: oeis('beaver', max_results=4, first_result=2) # optional  internet Expected: 0: A131956: Busy Beaver variation: maximum number of steps for ... 1: A141475: Number of Turing machines with n states following ... 2: A131957: Busy Beaver sigma variation: maximum number of 1's ... 3: A...: ... Got: 0: A131956: Busy Beaver variation: maximum number of steps for a 2state, 2symbol Turing machine running on a tape which is initialized with the number n in binary and 0's everywhere else. The machine is started at the rightmost bit in the number n. 1: A141475: Number of Turing machines with n states following the standard formalism of the busy beaver problem where the head of a Turing machine either moves to the right or to the left, but none once halted. 2: A333479: Busy Beaver for binary lambda calculus: the maximum normal form size of any closed lambda term of size n, or 0 if no closed term of size n exists. 3: A131957: Busy Beaver sigma variation: maximum number of 1's on the final tape, for a 2state, 2symbol Turing machine running on a tape which is initialized with the number n in binary and 0's everywhere else. The machine is started at the rightmost bit in the number n. ********************************************************************** 1 item had failures: 1 of 5 in sage.databases.oeis.OEIS.find_by_description 5 webbrowser tests not run 0 tests not run because we ran out of time [281 tests, 1 failure, 34.75 s]
Change History (8)
comment:1 Changed 18 months ago by
comment:2 Changed 18 months ago by
 Branch set to u/chapoton/29787
 Commit set to b95fa2c28a49c9b3c3e2fa3dc2eb55699dcbbcfd
 Status changed from new to needs_review
comment:3 Changed 18 months ago by
green bot, please review
comment:4 Changed 18 months ago by
How about we also include in the test that the word Beaver
appears and similar for the others?
comment:5 Changed 18 months ago by
 Commit changed from b95fa2c28a49c9b3c3e2fa3dc2eb55699dcbbcfd to cf800be33067884454dddcf7dac4760d288862e1
Branch pushed to git repo; I updated commit sha1. New commits:
cf800be  still test something in the oeis everchanging doctests

comment:6 Changed 18 months ago by
Here you go
so much energy in so bad doctests..
comment:7 Changed 18 months ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Thanks. That way it at least it is testing that we are getting the right word in the result. Hopefully this will end this issue.
comment:8 Changed 17 months ago by
 Branch changed from u/chapoton/29787 to cf800be33067884454dddcf7dac4760d288862e1
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
oh, damn, these doctests should be marked random once and for all...