Opened 2 years ago

Closed 2 years ago

#29772 closed enhancement (fixed)

convert some code in finitely generated groups to libgap

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: group theory Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c0f5f74 (Commits, GitHub, GitLab) Commit: c0f5f74a490daf7ea8b7fe6234f8dd5b23d46889
Dependencies: Stopgaps:

Status badges


which helps to simplify

also some pep8 fixes in the modified file

Change History (4)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/29772
  • Commit set to c0f5f74a490daf7ea8b7fe6234f8dd5b23d46889
  • Status changed from new to needs_review

New commits:

c0f5f74convert some code in finitely generated groups from gap to libgap

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim added

morally green bot, please review

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Indeed, it is much better to use libgap where we can. In a similar vein, it probably would be good to also convert the singular calls to libsingular, but that is better for a separate ticket.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/29772 to c0f5f74a490daf7ea8b7fe6234f8dd5b23d46889
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.