#29754 closed enhancement (fixed)

Remove packages that handle backporting from Python 3 to Python 2

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-9.2
Component: packages: standard Keywords: sd109
Cc: Merged in:
Authors: John Palmieri Reviewers: Dima Pasechnik, Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 0578937 (Commits, GitHub, GitLab) Commit: 057893701afc844827240711fa63cb821d6fbd0d
Dependencies: Stopgaps:

Status badges

Description (last modified by jhpalmieri)

Remove

  • backports_abc
  • backports_functools_lru_cache
  • backports_shutil_get_terminal_size
  • backports_ssl_match_hostname
  • configparser
  • enum34
  • functools32
  • future
  • ipaddress
  • pathlib2
  • singledispatch
  • subprocess32
  • typing

Let's also remove sagenb, since it doesn't build with Python 3. That lets us remove

  • flask
  • flask_autoindex
  • flask_babel
  • flask_oldsessions
  • flask_openid
  • flask_silk
  • sagenb
  • twisted (it may be used by terminado when it is present, but terminado seems to function fine without it)
  • werkzeug

Change History (37)

comment:1 Changed 12 months ago by dimpase

sagenb should go, too, it doesn't work in py3.

comment:2 Changed 12 months ago by jhpalmieri

  • Description modified (diff)

comment:3 Changed 12 months ago by jhpalmieri

  • Description modified (diff)

comment:4 Changed 12 months ago by jhpalmieri

  • Dependencies set to #29752

comment:5 Changed 12 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/werkzeug-optional

comment:6 Changed 12 months ago by jhpalmieri

  • Commit set to 27b3d91efa3011e2f643214881d2d572ca472ffb
  • Status changed from new to needs_review

New commits:

56444d6trac 29752: convert werkzeug from standard to optional
27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

comment:7 Changed 12 months ago by git

  • Commit changed from 27b3d91efa3011e2f643214881d2d572ca472ffb to ddca85a935ebc3b06ee83d5acffeafcfb7a4a4e4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional

comment:8 Changed 12 months ago by git

  • Commit changed from ddca85a935ebc3b06ee83d5acffeafcfb7a4a4e4 to 27b3d91efa3011e2f643214881d2d572ca472ffb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

56444d6trac 29752: convert werkzeug from standard to optional
27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

comment:9 Changed 12 months ago by git

  • Commit changed from 27b3d91efa3011e2f643214881d2d572ca472ffb to 9385b73e192cf64d5f248760fd7b3a36b0d482f2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional
9385b73trac 29754: remove packages backported Python 3 components to Python

comment:10 Changed 12 months ago by git

  • Commit changed from 9385b73e192cf64d5f248760fd7b3a36b0d482f2 to ddca85a935ebc3b06ee83d5acffeafcfb7a4a4e4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:11 Changed 12 months ago by git

  • Commit changed from ddca85a935ebc3b06ee83d5acffeafcfb7a4a4e4 to 406a030cd4f98375f35519f27f94a9a68807c055

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e1a0c8ctrac 29752: convert werkzeug from standard to optional
406a030trac 29754: remove packages backported Python 3 components to Python

comment:12 Changed 12 months ago by jhpalmieri

  • Status changed from needs_review to needs_info

I have to test my new branch. I'll set it back to "needs review" when that's done.

comment:13 Changed 12 months ago by jhpalmieri

  • Branch u/jhpalmieri/werkzeug-optional deleted
  • Commit 406a030cd4f98375f35519f27f94a9a68807c055 deleted
  • Dependencies #29752 deleted

comment:14 Changed 12 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/no-py2-backports

comment:15 Changed 12 months ago by jhpalmieri

  • Commit set to 2903b2201edb67a3f90ca4250a8dde14cff5ba93
  • Status changed from needs_info to needs_review

Okay, ready for review.


New commits:

2903b22trac 29754: remove packages which backport Python 3 components:

comment:16 Changed 12 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:17 Changed 12 months ago by jhpalmieri

  • Status changed from positive_review to needs_info

Thanks, but as you and Matthias noted on another ticket, this needs rebasing. I'll work on that.

comment:18 Changed 12 months ago by git

  • Commit changed from 2903b2201edb67a3f90ca4250a8dde14cff5ba93 to c182f481bc0794572a970b1240300fc910f176e8

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

32bb2feMerge tag '9.1.rc3' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs
7555ba6Merge branch 't/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs' into t/29669/for_sage_9_2__remove_python_2_support_from_the_build_system
520078abuild/pkgs/python2: Remove
f712bb5configure.ac: Remove option --with-python=2
96a5e76Remove python2 from tox and GitHub CI scripts
ea7df3econfigure.ac: Remove message 'Checking for Python version to install...'
ff41817configure.ac: Warn on 'configure --with-python=3.x'
378bf54Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29757/_github_workflows_tox_gcc_spkg_yml__remove_python2
225f730.github/workflows/tox-gcc_spkg.yml: Remove python2
c182f48trac 29754: remove packages backporting Python 3 components to Python 2.

comment:19 Changed 12 months ago by jhpalmieri

  • Dependencies set to #29757
  • Description modified (diff)
  • Status changed from needs_info to needs_review

Rebased to #29757.

comment:20 Changed 11 months ago by mkoeppe

Can zope_interface also be removed?

$ grep zope_interface build/pkgs/*/dependencies
build/pkgs/twisted/dependencies:$(PYTHON) | $(PYTHON_TOOLCHAIN) zope_interface

comment:21 Changed 11 months ago by dimpase

I tested this meanwhile, it works. Most probably zope_interface may go too, it only is mentioned in doctests (and as a dependence of removed here twisted)

comment:22 Changed 11 months ago by mkoeppe

If this version here works, let's get this ticket in, and do the zope_interface removal on a follow-up ticket.

comment:23 Changed 11 months ago by mkoeppe

This could happen on #29803.

comment:24 Changed 11 months ago by mkoeppe

Removal of zope_interface is now done on #29803, actually I changed it to a dummy script package there so that #29803 is independent of this one here.

comment:25 Changed 11 months ago by dimpase

  • Status changed from needs_review to positive_review

lgtm

comment:26 Changed 11 months ago by mkoeppe

Conflicts with #29745

comment:27 Changed 11 months ago by mkoeppe

  • Branch changed from u/jhpalmieri/no-py2-backports to u/mkoeppe/no-py2-backports

comment:28 Changed 11 months ago by mkoeppe

  • Commit changed from c182f481bc0794572a970b1240300fc910f176e8 to 05a69377eca3a1ee383ef21153154518884a5acc
  • Reviewers changed from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

New commits:

4672d55trac 29633: fixes for PDF docbuilding
2ee9befMerge tag '9.1' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs
9c7ea5ftrac 29633: fix SQLite doctests in cmdline.py
8baef11trac 29745: clean up various SPKG.rst files
c559f26Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29745/cleanup-spkg-rst-files
05a6937Merge commit 'c559f26caf56378c8c4a5652f577986b4f5d431c' of git://trac.sagemath.org/sage into t/29754/no-py2-backports

comment:29 Changed 11 months ago by mkoeppe

Follow-up: #29823

comment:30 follow-up: Changed 11 months ago by jhpalmieri

Another follow-up: #29878

comment:31 in reply to: ↑ 30 Changed 11 months ago by jhpalmieri

And another: #29885 (remove "sage -n sagenb" as an advertised option, and strip the SageNB code from the sage-notebook script).

comment:32 Changed 11 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:33 Changed 11 months ago by git

  • Commit changed from 05a69377eca3a1ee383ef21153154518884a5acc to cc615411d7ceee69b369139923e2fe153b4f56cb

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

8387b7badd forgotten doctest fix.
2ddcd31change upstream_url to a (hopefully) more stable and easy to decipher address for sphinx packages
649289emove sphinx packages from pip to PYTHON_TOOLCHAIN
e5415datrac 28856: fix apostrophes in wikipedia links
b9d44e3Merge branch 'ticket-28000' into sphinx3
8f66113Minor upgdrade to Sphinx 3.0.3
321e2bfBump to 3.0.4
ee7195cMerge branch 'matplotlib3.2.1' into sphinx3
bd99462Merge branch 'develop' into sphinx3
cc61541Merge commit 'bd99462f6f89757b9b1674fbeb55743ce7f6fab6' of git://trac.sagemath.org/sage into t/29754/no-py2-backports

comment:34 Changed 11 months ago by mkoeppe

  • Dependencies changed from #29757 to #29757, #28856
  • Status changed from needs_work to positive_review

comment:35 Changed 11 months ago by git

  • Commit changed from cc615411d7ceee69b369139923e2fe153b4f56cb to 057893701afc844827240711fa63cb821d6fbd0d
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

0578937Merge tag '9.2.beta2' into t/29754/no-py2-backports

comment:36 Changed 11 months ago by mkoeppe

  • Dependencies #29757, #28856 deleted
  • Status changed from needs_review to positive_review

merged in the latest beta

comment:37 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/no-py2-backports to 057893701afc844827240711fa63cb821d6fbd0d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.