#29750 closed defect (fixed)

Fix a bug in singular points computation of projective curves

Reported by: klee Owned by:
Priority: minor Milestone: sage-9.2
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Kwankyu Lee Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c4d2974 (Commits, GitHub, GitLab) Commit: c4d2974d25adbe1aa21b2cf7471fd14a7a08dd54
Dependencies: Stopgaps:

Status badges

Description (last modified by klee)

We fix this bug:

sage: P2.<x0,x1,x2> = ProjectiveSpace(2, GF(3))
sage: C = Curve(x0)
sage: C.singular_closed_points()
...
ZeroDivisionError: Cannot invert 0
sage: C._singularities
...
ZeroDivisionError: Cannot invert 0

Change History (6)

comment:1 Changed 13 months ago by klee

  • Branch set to u/klee/29750

comment:2 Changed 13 months ago by git

  • Commit set to c4d2974d25adbe1aa21b2cf7471fd14a7a08dd54

Branch pushed to git repo; I updated commit sha1. New commits:

c4d2974Fix a bug in _singularities

comment:3 Changed 13 months ago by klee

  • Authors set to Kwankyu Lee

comment:4 Changed 13 months ago by klee

  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 13 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 13 months ago by vbraun

  • Branch changed from u/klee/29750 to c4d2974d25adbe1aa21b2cf7471fd14a7a08dd54
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.