Opened 2 years ago
Closed 2 years ago
#29746 closed enhancement (fixed)
Document integer overflow bug in vector_space_dimension()
Reported by:  ghkliem  Owned by:  

Priority:  trivial  Milestone:  sage9.2 
Component:  commutative algebra  Keywords:  sd109 
Cc:  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  76d3388 (Commits, GitHub, GitLab)  Commit:  76d3388f9cb48e34516147ebf0a40bcb7c6587e0 
Dependencies:  Stopgaps: 
Description
We document the following bug reported in #8586
sage: P.<x,y,z> = PolynomialRing(GF(32003),3) sage: sage.rings.ideal.FieldIdeal(P).vector_space_dimension() 1973539045 # 2^32  (32003^3) % 2^32 == 1973539045
Change History (7)
comment:1 Changed 2 years ago by
Branch:  → public/29746 

Commit:  → a7e3ac5ea81450450d5bf22772b3999030f24347 
Status:  new → needs_review 
comment:2 followup: 4 Changed 2 years ago by
Shouldn't there rather be a test for the correct result, marked # not tested  known bug
comment:3 Changed 2 years ago by
Commit:  a7e3ac5ea81450450d5bf22772b3999030f24347 → 76d3388f9cb48e34516147ebf0a40bcb7c6587e0 

Branch pushed to git repo; I updated commit sha1. New commits:
76d3388  show the correct result for the known bug

comment:4 Changed 2 years ago by
Replying to mkoeppe:
Shouldn't there rather be a test for the correct result, marked # not tested  known bug
Ok.
Just # known bug
works for me and this appears to be the common approach.
comment:5 Changed 2 years ago by
Reviewers:  → Matthias Koeppe 

Status:  needs_review → positive_review 
comment:7 Changed 2 years ago by
Branch:  public/29746 → 76d3388f9cb48e34516147ebf0a40bcb7c6587e0 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
document integer overflow bug