#29734 closed defect (fixed)

Defect in `shortest_path_lengths` method in `generic_graph.py`

Reported by: gh-vipul79321 Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords: gsoc20
Cc: dcoudert Merged in:
Authors: Vipul Gupta Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 556f496 (Commits, GitHub, GitLab) Commit: 556f496f993f3d949d47fb20b7da83d1af0fbd60
Dependencies: Stopgaps:

Status badges

Description

shortest_path_lengths method in generic_graph.py makes self.weighted=True, when called with Dijkstra_Boost or Bellman-Ford_Boost See the code below

sage: G = graphs.PathGraph(7)
sage: G.weighted()
False
sage: G.shortest_path_lengths(0,algorithm='Dijkstra_Boost')
{0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6}
sage: G.weighted()
True

Change History (4)

comment:1 Changed 14 months ago by gh-vipul79321

  • Branch set to u/gh-vipul79321/ticket29734
  • Commit set to 556f496f993f3d949d47fb20b7da83d1af0fbd60

comment:2 Changed 14 months ago by gh-vipul79321

  • Status changed from new to needs_review

comment:3 Changed 14 months ago by dcoudert

  • Keywords gsoc20 added
  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 14 months ago by vbraun

  • Branch changed from u/gh-vipul79321/ticket29734 to 556f496f993f3d949d47fb20b7da83d1af0fbd60
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.