Opened 12 months ago
Closed 11 months ago
#29730 closed enhancement (fixed)
Update sympy to 1.6
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  packages: standard  Keywords:  
Cc:  fbissey, ghtimokau, saraedum, slelievre, arojas, vdelecroix, isuruf  Merged in:  
Authors:  Antonio Rojas  Reviewers:  Matthias Koeppe, Isuru Fernando 
Report Upstream:  N/A  Work issues:  
Branch:  1734209 (Commits, GitHub, GitLab)  Commit:  17342095391b824b8fe8ed56b7cfd3f1a9e949ee 
Dependencies:  Stopgaps: 
Description
Change History (13)
comment:1 Changed 12 months ago by
comment:2 Changed 12 months ago by
I don't have a branch.
comment:3 Changed 12 months ago by
 Branch set to u/arojas/update_to_sympy_1_6
 Commit set to 8a395fecd78cc8da448956e94101c81489b35c3f
New commits:
8a395fe  Update sympy to 1.6

comment:4 Changed 12 months ago by
 Status changed from new to needs_review
comment:5 Changed 11 months ago by
 Branch changed from u/arojas/update_to_sympy_1_6 to u/mkoeppe/update_to_sympy_1_6
comment:6 Changed 11 months ago by
 Branch changed from u/mkoeppe/update_to_sympy_1_6 to u/arojas/update_to_sympy_1_6
rebased on 9.2.beta1
comment:7 followup: ↓ 9 Changed 11 months ago by
comment:8 Changed 11 months ago by
all_classes
is private API as far as I know.
How about just if isinstance(expression, sympy.Basic)
?
comment:9 in reply to: ↑ 7 Changed 11 months ago by
Replying to mkoeppe:
Tests run at https://github.com/mkoeppe/sage/actions/runs/135267093
... looking fine.
comment:10 Changed 11 months ago by
 Commit changed from 8a395fecd78cc8da448956e94101c81489b35c3f to 17342095391b824b8fe8ed56b7cfd3f1a9e949ee
Branch pushed to git repo; I updated commit sha1. New commits:
1734209  Avoid using sympy private API

comment:11 Changed 11 months ago by
 Reviewers set to Matthias Koeppe, Isuru Fernando
comment:12 Changed 11 months ago by
 Status changed from needs_review to positive_review
comment:13 Changed 11 months ago by
 Branch changed from u/arojas/update_to_sympy_1_6 to 17342095391b824b8fe8ed56b7cfd3f1a9e949ee
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I don't know why I'm not getting most trac emails lately... I missed this and I just opened a duplicate with a patch at #29731  feel free to use it if you don't have your own branch already.