#29721 closed enhancement (fixed)

coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: build: configure Keywords: sd109, spkg-configure
Cc: tscrim, dimpase, mjo, arojas, isuruf Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1497f3f (Commits, GitHub, GitLab) Commit: 1497f3f08d580fb6579e8316f3e4b05d5e8d81b8
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix coxeter/.

In this ticket we change the includes in src/sage/libs/coxeter3/decl.pxd to use the prefix coxeter/, which allows us to get rid of include_dirs in src/module_list.py:

    OptionalExtension('sage.libs.coxeter3.coxeter',
              sources = ['sage/libs/coxeter3/coxeter.pyx'],
              language="c++",
              include_dirs = [os.path.join(SAGE_INC, 'coxeter')],
              package = 'coxeter3'),

This simplifies the work in #29720.

Change History (16)

comment:1 Changed 20 months ago by mkoeppe

  • Cc isuruf added

comment:2 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 20 months ago by mkoeppe

  • Branch set to u/mkoeppe/spkg_configure_m4_for_coxeter3

comment:4 Changed 20 months ago by mkoeppe

  • Commit set to ad1b8b76af360832a06615cd96952c22d9d764c8
  • Keywords sd109 added

New commits:

ad1b8b7build/pkgs/coxeter3/distros/fedora.txt: New

comment:5 Changed 20 months ago by mkoeppe

Help with this ticket would be very welcome

comment:6 Changed 20 months ago by mkoeppe

  • Authors set to Matthias Koeppe, ...

comment:7 Changed 20 months ago by git

  • Commit changed from ad1b8b76af360832a06615cd96952c22d9d764c8 to 3dd29273db8fa38f760c8ba4eef791787214865b

Branch pushed to git repo; I updated commit sha1. New commits:

3dd2927src/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive

comment:8 Changed 20 months ago by git

  • Commit changed from 3dd29273db8fa38f760c8ba4eef791787214865b to dbbc985165ac81360e84ac595c66d7cd1b168211

Branch pushed to git repo; I updated commit sha1. New commits:

dbbc985src/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option

comment:9 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:10 Changed 20 months ago by git

  • Commit changed from dbbc985165ac81360e84ac595c66d7cd1b168211 to 1497f3f08d580fb6579e8316f3e4b05d5e8d81b8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6909e23build/pkgs/coxeter3/distros/fedora.txt: New
2b060aesrc/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive
4f0d07dsrc/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option
1497f3fbuild/pkgs/coxeter3/spkg-configure.m4: New

comment:11 Changed 20 months ago by mkoeppe

  • Authors changed from Matthias Koeppe, ... to Matthias Koeppe
  • Description modified (diff)
  • Status changed from new to needs_review

comment:12 Changed 20 months ago by mkoeppe

  • Authors changed from Matthias Koeppe to Matthias Koeppe, ...
  • Description modified (diff)
  • Keywords spkg-configure added
  • Summary changed from spkg-configure.m4 for coxeter3 to coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives

comment:13 Changed 20 months ago by mkoeppe

  • Authors changed from Matthias Koeppe, ... to Matthias Koeppe

comment:14 Changed 20 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

coxeter3 builds on my system. So LGTM.

One of these days I will actually get back to converting coxeter3 to full C++ and doing some additional cleanup...

comment:15 Changed 20 months ago by mkoeppe

Thank you!

comment:16 Changed 19 months ago by vbraun

  • Branch changed from u/mkoeppe/spkg_configure_m4_for_coxeter3 to 1497f3f08d580fb6579e8316f3e4b05d5e8d81b8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.