Opened 3 years ago

Closed 2 years ago

#29720 closed enhancement (fixed)

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 2 - OptionalExtensions)

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords: sd109
Cc: François Bissey, Dima Pasechnik, John Palmieri, Travis Scrimshaw, gh-kliem, David Roe, Vincent Delecroix, Volker Braun Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 2821934 (Commits, GitHub, GitLab) Commit: 28219340dd0eb3d939dcd0c7e9fbc89133490a0c
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

Follow-up from #29706.

In this part, we take care of all OptionalExtensions except for

Change History (14)

comment:1 Changed 3 years ago by Matthias Köppe

Type: PLEASE CHANGEenhancement

comment:2 Changed 3 years ago by Matthias Köppe

Branch: u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_2___optionalextensions_

comment:3 Changed 3 years ago by Matthias Köppe

Commit: 69004cda88b8754b4cf0eea6010af487b062ff7c
Keywords: sd109 added

New commits:

69004cdsrc/sage: Move OptionalExtension options from src/module_list.py to distutils directives

comment:4 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:5 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:6 Changed 2 years ago by git

Commit: 69004cda88b8754b4cf0eea6010af487b062ff7c9805a19ba05d34df245cbde95d1a0be14a60bf41

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9805a19src/sage: Move OptionalExtension options from src/module_list.py to distutils directives

comment:7 Changed 2 years ago by git

Commit: 9805a19ba05d34df245cbde95d1a0be14a60bf41401a864da70df1fe2b60ae4371644b4ff054bbdd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

401a864src/sage: Move OptionalExtension options (except tdlib) from src/module_list.py to distutils directives

comment:8 Changed 2 years ago by git

Commit: 401a864da70df1fe2b60ae4371644b4ff054bbddbfd9fedc42fe0b770edf87cf56e488a21e6099ca

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bfd9fedsrc/sage: Move OptionalExtension options (except tdlib, coxeter) from src/module_list.py to distutils directives

comment:9 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Status: newneeds_review

fes does not really exist (it was an old-style experimental package that was never converted to new-style), but it's not the job of this ticket to remove the corresponding extension.

comment:10 Changed 2 years ago by git

Commit: bfd9fedc42fe0b770edf87cf56e488a21e6099ca28219340dd0eb3d939dcd0c7e9fbc89133490a0c

Branch pushed to git repo; I updated commit sha1. New commits:

2821934Fix sage_setup directives: Use distribution, not package

comment:11 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:12 Changed 2 years ago by gh-kliem

Reviewers: Jonathan Kliem
Status: needs_reviewpositive_review

LGTM.

comment:13 Changed 2 years ago by Matthias Köppe

Thanks!

comment:14 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_2___optionalextensions_28219340dd0eb3d939dcd0c7e9fbc89133490a0c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.