Opened 2 years ago

Closed 2 years ago

#29712 closed enhancement (fixed)

some cleanup for core.py

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 08c4b57 (Commits, GitHub, GitLab) Commit: 08c4b577de5697e8188d68e0c31cf853d92a4a3e
Dependencies: Stopgaps:

Status badges

Description

mainly pep8 changes

also adding __ne__ (see #15904)

Change History (11)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/29712
  • Commit set to b2397c5ecf2c098aa8d023115734b15080f3d88b

New commits:

​b2397c5spring cleanup for combinat/core.py

comment:2 Changed 2 years ago by git

  • Commit changed from b2397c5ecf2c098aa8d023115734b15080f3d88b to 4c8a0814eba59b6af21fefa8d65eb167ad56748f

Branch pushed to git repo; I updated commit sha1. New commits:

​4c8a081pyflakes

comment:3 Changed 2 years ago by chapoton

Hmm, it seems that adding __ne__ breaks things elsewhere.

comment:4 Changed 2 years ago by git

  • Commit changed from 4c8a0814eba59b6af21fefa8d65eb167ad56748f to 27179f7b6368462ead05b9e8daef52e94811dee6

Branch pushed to git repo; I updated commit sha1. New commits:

​27179f7fix tests for skewness in k_tableau

comment:5 Changed 2 years ago by chapoton

maybe __bool__ was not needed, see

​https://docs.python.org/3/reference/datamodel.html#object.__bool

comment:6 Changed 2 years ago by git

  • Commit changed from 27179f7b6368462ead05b9e8daef52e94811dee6 to a284512f6348e8141d8f395079f7577ec00e4388

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​a284512spring cleanup for combinat/core.py

comment:7 Changed 2 years ago by chapoton

  • Cc tscrim added
  • Status changed from new to needs_review

green bot, please review

comment:8 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Why a bool here: 

-        if self._inner_shape != []:
+        if bool(self._inner_shape):

Once changed or justified, you can set a positive review.

comment:9 Changed 2 years ago by git

  • Commit changed from a284512f6348e8141d8f395079f7577ec00e4388 to 08c4b577de5697e8188d68e0c31cf853d92a4a3e

Branch pushed to git repo; I updated commit sha1. New commits:

​08c4b57fix detail

comment:10 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

thanks, fixed. I am setting to positive

comment:11 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/29712 to 08c4b577de5697e8188d68e0c31cf853d92a4a3e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.