Opened 2 years ago
Closed 2 years ago
#29682 closed enhancement (fixed)
spring cleanup in pushout.py
| Reported by: | chapoton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.2 |
| Component: | categories | Keywords: | |
| Cc: | tscrim | Merged in: | |
| Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 51b6ee0 (Commits, GitHub, GitLab) | Commit: | 51b6ee016fe87259b62e1f7bfdb090f31034be37 |
| Dependencies: | Stopgaps: |
Status badges
Description
mainly pep8 changes, plus little code changes and one lgtm suggestion
may need to be rebased over #29643
Change History (8)
comment:1 Changed 2 years ago by
- Branch set to u/chapoton/29682
- Commit set to 4ec5aacd326c453458c87fea31f58d86886a20ec
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Commit changed from 4ec5aacd326c453458c87fea31f58d86886a20ec to 7051806db961bc5a27608badb101087dbe2dd30f
Branch pushed to git repo; I updated commit sha1. New commits:
| 7051806 | trac 29682 fix unicode detail
|
comment:3 Changed 2 years ago by
- Cc tscrim added
green bot, please review (lot of pep8, but a few other things)
comment:4 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 2 years ago by
- Commit changed from 7051806db961bc5a27608badb101087dbe2dd30f to 51b6ee016fe87259b62e1f7bfdb090f31034be37
Branch pushed to git repo; I updated commit sha1. New commits:
| 51b6ee0 | Merge branch 'u/chapoton/29682' with 9.2.b0
|
comment:7 Changed 2 years ago by
- Status changed from needs_work to positive_review
trivial rebase, setting back to positive
comment:8 Changed 2 years ago by
- Branch changed from u/chapoton/29682 to 51b6ee016fe87259b62e1f7bfdb090f31034be37
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
spring cleanup for pushout.py