Opened 11 months ago

Closed 7 months ago

#29681 closed enhancement (fixed)

Small improvements for `FaceIterator_base`

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: polyhedron, face iterator
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fc84ffa (Commits, GitHub, GitLab) Commit: fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a
Dependencies: #29654 Stopgaps:

Status badges

Description

This ticket collects some small improvements for the the class FaceIterator_base and the inherited classes FaceIterator, FaceIterator_geom:

  • Add a method reset.
  • Add a method current that retrieves the last value of __next__.
  • Simplify the methods ignore_subfaces and ignore_supfaces by outsourcing the common code to ignore_subsets.

Follow up:

Use face iterator to obtain the meet of (some) vertices or the join of (some) facets.

Change History (7)

comment:1 Changed 11 months ago by gh-kliem

  • Branch set to public/29681
  • Commit set to f6633bd5c3ac4d55b348d6bc99cd939d12436d70
  • Status changed from new to needs_review

Last 10 new commits:

​53fd2a2fixed failing doctest
​a6d2b2da face iterator subclass that yield PolyhedronFace
​1476675representation like Polyhedron_base
​47fc7cdaccount for FaceIterator -> FaceIterator_base
​295039adocumentation
​d36da4acoverage and small improvement
​2d0f0d9method `reset` for the face iterator
​6d99a4ctypo
​5711f6bmethod `ignore_subsets`
​f6633bdmethod current and fix for reset

comment:2 Changed 11 months ago by gh-kliem

  • Milestone changed from sage-9.1 to sage-9.2

comment:3 Changed 8 months ago by mkoeppe

  • Status changed from needs_review to needs_work

needs rebase

comment:4 Changed 8 months ago by gh-kliem

  • Branch changed from public/29681 to public/29681-reb
  • Commit changed from f6633bd5c3ac4d55b348d6bc99cd939d12436d70 to fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a
  • Status changed from needs_work to needs_review

New commits:

​3f92d2dfixed merge conflict
​3ba34fdmove documenation to exposed class
​d89a503Merge branch 'public/29654-reb3' of git://trac.sagemath.org/sage into public/29681-reb
​fc84ffaMerge branch 'public/29681' of git://trac.sagemath.org/sage into public/29681-reb

comment:5 Changed 8 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 8 months ago by gh-kliem

Thanks.

comment:7 Changed 7 months ago by vbraun

  • Branch changed from public/29681-reb to fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.