Opened 2 years ago
Closed 21 months ago
#29681 closed enhancement (fixed)
Small improvements for `FaceIterator_base`
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | geometry | Keywords: | polyhedron, face iterator |
Cc: | jipilab, gh-LaisRast | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | fc84ffa (Commits, GitHub, GitLab) | Commit: | fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a |
Dependencies: | #29654 | Stopgaps: |
Description
This ticket collects some small improvements for the the class FaceIterator_base
and the inherited classes FaceIterator
, FaceIterator_geom
:
- Add a method
reset
. - Add a method
current
that retrieves the last value of__next__
. - Simplify the methods
ignore_subfaces
andignore_supfaces
by outsourcing the common code toignore_subsets
.
Follow up:
Use face iterator to obtain the meet of (some) vertices or the join of (some) facets.
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to public/29681
- Commit set to f6633bd5c3ac4d55b348d6bc99cd939d12436d70
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Milestone changed from sage-9.1 to sage-9.2
comment:4 Changed 22 months ago by
- Branch changed from public/29681 to public/29681-reb
- Commit changed from f6633bd5c3ac4d55b348d6bc99cd939d12436d70 to fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a
- Status changed from needs_work to needs_review
comment:5 Changed 21 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 21 months ago by
Thanks.
comment:7 Changed 21 months ago by
- Branch changed from public/29681-reb to fc84ffa5c6f01a7c3353e8974bc5ef444bc7cd9a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
fixed failing doctest
a face iterator subclass that yield PolyhedronFace
representation like Polyhedron_base
account for FaceIterator -> FaceIterator_base
documentation
coverage and small improvement
method `reset` for the face iterator
typo
method `ignore_subsets`
method current and fix for reset