Opened 2 years ago

Last modified 2 years ago

#29676 closed enhancement

Make a nogil version of the most important methods of FaceIterator. — at Version 3

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: polytopes, f-vector
Cc: Jean-Philippe Labbé, Laith Rastanawi, Travis Scrimshaw Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: public/29676 (Commits, GitHub, GitLab) Commit: c6fe6d4578c25aaa3e465f8c74b1c500ff5d6946
Dependencies: #28894 Stopgaps:

Status badges

Description (last modified by gh-kliem)

We outsource 3 crucial methods of FaceIterator to nogil functions.

This is part of #28893: Parallel f-vector for polyhedra.

Anything happening within prange should be without gil. Any function that is called in the parallel section needs to be nogil.

Change History (3)

comment:1 Changed 2 years ago by gh-kliem

Authors: Jonathan Kliem
Branch: public/29676
Cc: Jean-Philippe Labbé Laith Rastanawi added
Commit: c6fe6d4578c25aaa3e465f8c74b1c500ff5d6946
Status: newneeds_review

New commits:

0c44221important attributes of iterator in structure
efb0bd3src/simplification of doctests
53fd2a2fixed failing doctest
c6fe6d4make nogil function of crucial methods in FaceIterator

comment:2 Changed 2 years ago by Jean-Philippe Labbé

Could you extend a little bit in the description on what this does?

comment:3 Changed 2 years ago by gh-kliem

Description: modified (diff)
Note: See TracTickets for help on using tickets.