Opened 2 years ago

Closed 2 years ago

#29658 closed enhancement (fixed)

Update to BRiAl 1.2.8

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: arojas, fbissey, mjo Merged in:
Authors: John Palmieri Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 8501c36 (Commits, GitHub, GitLab) Commit: 8501c36d6cf576c9524754b31114e5553be75535
Dependencies: Stopgaps:

Status badges

Description

BRiAl 1.2.8 fixes some Python 3 issues present in the current version in Sage.

Change History (15)

comment:1 Changed 2 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/brial-1.2.8

comment:2 Changed 2 years ago by jhpalmieri

  • Commit set to a3a5736929ea4a2907a911b411c98df7da031fad
  • Status changed from new to needs_review

New commits:

a3a5736trac 29658: update BRiAl

comment:3 Changed 2 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

It is a trivial bump, and I should know, I am one the one doing the releases.

comment:4 Changed 2 years ago by jhpalmieri

Thanks. Maybe you should be the author and I should be the reviewer. ;)

comment:5 Changed 2 years ago by mkoeppe

  • Cc mjo added

Shouldn't sage_brial be updated at the same time?

comment:6 Changed 2 years ago by mkoeppe

  • Status changed from positive_review to needs_info

comment:7 Changed 2 years ago by fbissey

We share the tarball so yes. Plus John explicitly mention python stuff, that's in sage_brial. I should pay more attention to the fact that the package has been split in vanilla sage too.

comment:8 Changed 2 years ago by git

  • Commit changed from a3a5736929ea4a2907a911b411c98df7da031fad to 8501c36d6cf576c9524754b31114e5553be75535

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8501c36trac 29658: update BRiAl

comment:9 Changed 2 years ago by jhpalmieri

  • Status changed from needs_info to needs_review

Okay, this updates sage_brial also.

comment:10 follow-up: Changed 2 years ago by jhpalmieri

By the way, to update sage_brial, I updated the version number in package_version.txt and ran sage --package fix-checksum, and was told

Updating checksum of brial-1.2.8.tar.bz2

Should it use the package name instead of the tarball name, or perhaps both? I find it a little misleading.

comment:11 in reply to: ↑ 10 Changed 2 years ago by fbissey

Replying to jhpalmieri:

By the way, to update sage_brial, I updated the version number in package_version.txt and ran sage --package fix-checksum, and was told

Updating checksum of brial-1.2.8.tar.bz2

Should it use the package name instead of the tarball name, or perhaps both? I find it a little misleading.

Well, it is updating what it sees in checksum.ini which is brial in this case. If we want say the "package name" corresponding to the tarball that's some extra code for fix-checksum.

And I am not touching sage's own packaging system anymore.

Last edited 2 years ago by fbissey (previous) (diff)

comment:12 Changed 2 years ago by jhpalmieri

I propose (for another ticket):

  • build/sage_bootstrap/app.py

    diff --git a/build/sage_bootstrap/app.py b/build/sage_bootstrap/app.py
    index 45818546a1..6405527e4d 100644
    a b class Application(object): 
    134134        """
    135135        for pkg in Package.all():
    136136            if not os.path.exists(pkg.tarball.upstream_fqn):
    137                 log.debug('Ignoring {0} because tarball is not cached'.format(pkg.tarball_filename))
     137                log.debug('Ignoring {0} because tarball is not cached'.format(pkg.name))
    138138                continue
    139139            if pkg.tarball.checksum_verifies():
    140                 log.debug('Checksum of {0} unchanged'.format(pkg.tarball_filename))
     140                log.debug('Checksum of {0} unchanged'.format(pkg.name))
    141141                continue
    142142            update = ChecksumUpdater(pkg.name)
    143             print('Updating checksum of {0}'.format(pkg.tarball_filename))
     143            print('Updating checksum of {0} (tarball {1})'.format(pkg.name, pkg.tarball_filename))
    144144            update.fix_checksum()
    145145
    146146    def fix_checksum(self, package_name):
    class Application(object): 
    154154        update = ChecksumUpdater(package_name)
    155155        pkg = update.package
    156156        if pkg.tarball.checksum_verifies():
    157             print('Checksum of {0} unchanged'.format(pkg.tarball_filename))
     157            print('Checksum of {0} unchanged'.format(package_name))
    158158        else:
    159             print('Updating checksum of {0}'.format(pkg.tarball_filename))
     159            print('Updating checksum of {0} (tarball {1})'.format(package_name, pkg.tarball_filename))
    160160            update.fix_checksum()
    161161       
    162162    def create(self, package_name, version, tarball, pkg_type, upstream_url):

comment:13 Changed 2 years ago by jhpalmieri

Sample output:

% ./sage --package fix-checksum sage_brial
Updating checksum of sage_brial (tarball brial-1.2.8.tar.bz2)
% ./sage --package fix-checksum sage_brial
Checksum of sage_brial unchanged

comment:14 Changed 2 years ago by fbissey

  • Status changed from needs_review to positive_review

Otherwise, I cannot see anything else holding this ticket. Feel free to say I am wrong.

comment:15 Changed 2 years ago by vbraun

  • Branch changed from u/jhpalmieri/brial-1.2.8 to 8501c36d6cf576c9524754b31114e5553be75535
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.