Opened 2 years ago
Closed 2 years ago
#29658 closed enhancement (fixed)
Update to BRiAl 1.2.8
Reported by:  jhpalmieri  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  packages: standard  Keywords:  
Cc:  arojas, fbissey, mjo  Merged in:  
Authors:  John Palmieri  Reviewers:  François Bissey 
Report Upstream:  N/A  Work issues:  
Branch:  8501c36 (Commits, GitHub, GitLab)  Commit:  8501c36d6cf576c9524754b31114e5553be75535 
Dependencies:  Stopgaps: 
Description
BRiAl 1.2.8 fixes some Python 3 issues present in the current version in Sage.
Change History (15)
comment:1 Changed 2 years ago by
 Branch set to u/jhpalmieri/brial1.2.8
comment:2 Changed 2 years ago by
 Commit set to a3a5736929ea4a2907a911b411c98df7da031fad
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
 Reviewers set to François Bissey
 Status changed from needs_review to positive_review
It is a trivial bump, and I should know, I am one the one doing the releases.
comment:4 Changed 2 years ago by
Thanks. Maybe you should be the author and I should be the reviewer. ;)
comment:6 Changed 2 years ago by
 Status changed from positive_review to needs_info
comment:7 Changed 2 years ago by
We share the tarball so yes. Plus John explicitly mention python stuff, that's in sage_brial. I should pay more attention to the fact that the package has been split in vanilla sage too.
comment:8 Changed 2 years ago by
 Commit changed from a3a5736929ea4a2907a911b411c98df7da031fad to 8501c36d6cf576c9524754b31114e5553be75535
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
8501c36  trac 29658: update BRiAl

comment:9 Changed 2 years ago by
 Status changed from needs_info to needs_review
Okay, this updates sage_brial also.
comment:10 followup: ↓ 11 Changed 2 years ago by
By the way, to update sage_brial, I updated the version number in package_version.txt
and ran sage package fixchecksum
, and was told
Updating checksum of brial1.2.8.tar.bz2
Should it use the package name instead of the tarball name, or perhaps both? I find it a little misleading.
comment:11 in reply to: ↑ 10 Changed 2 years ago by
Replying to jhpalmieri:
By the way, to update sage_brial, I updated the version number in
package_version.txt
and ransage package fixchecksum
, and was toldUpdating checksum of brial1.2.8.tar.bz2Should it use the package name instead of the tarball name, or perhaps both? I find it a little misleading.
Well, it is updating what it sees in checksum.ini
which is brial
in this case. If we want say the "package name" corresponding to the tarball that's some extra code for fixchecksum
.
And I am not touching sage's own packaging system anymore.
comment:12 Changed 2 years ago by
I propose (for another ticket):

build/sage_bootstrap/app.py
diff git a/build/sage_bootstrap/app.py b/build/sage_bootstrap/app.py index 45818546a1..6405527e4d 100644
a b class Application(object): 134 134 """ 135 135 for pkg in Package.all(): 136 136 if not os.path.exists(pkg.tarball.upstream_fqn): 137 log.debug('Ignoring {0} because tarball is not cached'.format(pkg. tarball_filename))137 log.debug('Ignoring {0} because tarball is not cached'.format(pkg.name)) 138 138 continue 139 139 if pkg.tarball.checksum_verifies(): 140 log.debug('Checksum of {0} unchanged'.format(pkg. tarball_filename))140 log.debug('Checksum of {0} unchanged'.format(pkg.name)) 141 141 continue 142 142 update = ChecksumUpdater(pkg.name) 143 print('Updating checksum of {0} '.format(pkg.tarball_filename))143 print('Updating checksum of {0} (tarball {1})'.format(pkg.name, pkg.tarball_filename)) 144 144 update.fix_checksum() 145 145 146 146 def fix_checksum(self, package_name): … … class Application(object): 154 154 update = ChecksumUpdater(package_name) 155 155 pkg = update.package 156 156 if pkg.tarball.checksum_verifies(): 157 print('Checksum of {0} unchanged'.format(p kg.tarball_filename))157 print('Checksum of {0} unchanged'.format(package_name)) 158 158 else: 159 print('Updating checksum of {0} '.format(pkg.tarball_filename))159 print('Updating checksum of {0} (tarball {1})'.format(package_name, pkg.tarball_filename)) 160 160 update.fix_checksum() 161 161 162 162 def create(self, package_name, version, tarball, pkg_type, upstream_url):
comment:13 Changed 2 years ago by
Sample output:
% ./sage package fixchecksum sage_brial Updating checksum of sage_brial (tarball brial1.2.8.tar.bz2) % ./sage package fixchecksum sage_brial Checksum of sage_brial unchanged
comment:14 Changed 2 years ago by
 Status changed from needs_review to positive_review
Otherwise, I cannot see anything else holding this ticket. Feel free to say I am wrong.
comment:15 Changed 2 years ago by
 Branch changed from u/jhpalmieri/brial1.2.8 to 8501c36d6cf576c9524754b31114e5553be75535
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac 29658: update BRiAl