Opened 3 years ago

Closed 2 years ago

#29653 closed enhancement (fixed)

Add system package information for FreeBSD

Reported by: Thierry Thomas Owned by:
Priority: major Milestone: sage-9.2
Component: build Keywords: FreeBSD; system packages
Cc: Matthias Köppe, Michael Orlitzky, Dima Pasechnik Merged in:
Authors: Thierry Thomas Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cb698c7 (Commits, GitHub, GitLab) Commit: cb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
Dependencies: #30044 Stopgaps:

Status badges

Description

Add system package information for FreeBSD, as asked by mkoeppe in #26249 comment:41.

Also add a patch to configure.ac: without it configure is rejected.

Attachments (4)

patch-configure.ac (823 bytes) - added by Thierry Thomas 3 years ago.
Add FreeBSD support in configure
build_bin_sage-guess-package-system.diff (353 bytes) - added by Thierry Thomas 3 years ago.
Add support of FreeBSD pkg in build/bin/sage-guess-package-system
build_bin_sage-print-system-package-command (490 bytes) - added by Thierry Thomas 3 years ago.
Add support of FreeBSD pkg in build/bin/sage-print-system-package-command
build_pkgs_freebsd.txt.tar.gz (3.2 KB) - added by Thierry Thomas 3 years ago.
Add the freebsd.txt files to build/pkg/

Download all attachments as: .zip

Change History (21)

Changed 3 years ago by Thierry Thomas

Attachment: patch-configure.ac added

Add FreeBSD support in configure

Changed 3 years ago by Thierry Thomas

Add support of FreeBSD pkg in build/bin/sage-guess-package-system

Changed 3 years ago by Thierry Thomas

Add support of FreeBSD pkg in build/bin/sage-print-system-package-command

Changed 3 years ago by Thierry Thomas

Add the freebsd.txt files to build/pkg/

comment:1 Changed 3 years ago by Matthias Köppe

git branch please

comment:2 in reply to:  1 Changed 3 years ago by Thierry Thomas

Replying to mkoeppe:

git branch please

fatal: remote error: access denied or repository not exported: /sage.git

Version 0, edited 3 years ago by Thierry Thomas (next)

comment:3 Changed 3 years ago by Thierry Thomas

Branch: u/gh-thierry-FreeBSD/add_system_package_information_for_freebsd

comment:4 Changed 3 years ago by Matthias Köppe

Commit: 9138c47e45f8926ea93d5fe515f51630b7063a6b

The branch has some changes on configure.ac that are probably not intended


New commits:

c6f9137Add support for FreeBSD
9138c47Add system package information for FreeBSD

comment:5 Changed 2 years ago by Matthias Köppe

Cc: Michael Orlitzky Dima Pasechnik added

Can we get a version of this into sage before it bitrots completely?

comment:6 Changed 2 years ago by Matthias Köppe

Authors: gh-thierry-FreeBSDThierry Thomas

comment:7 Changed 2 years ago by Dima Pasechnik

Branch: u/gh-thierry-FreeBSD/add_system_package_information_for_freebsdu/dimpase/add_system_package_information_for_freebsd
Commit: 9138c47e45f8926ea93d5fe515f51630b7063a6b42cb33cb456e708cc9db31ff2d35a8fa2c890f5d
Reviewers: Dima Pasechnik
Status: newneeds_review

New commits:

511fad0Add support for FreeBSD
f57ac7eAdd system package information for FreeBSD
42cb33ccorrect rebase for the latest configure.ac

comment:8 Changed 2 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

LGTM

comment:9 Changed 2 years ago by Matthias Köppe

Branch: u/dimpase/add_system_package_information_for_freebsdu/mkoeppe/add_system_package_information_for_freebsd

comment:10 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/add_system_package_information_for_freebsdu/dimpase/add_system_package_information_for_freebsd
Dependencies: #30044

Merged #30044 to prevent merge conflict

comment:11 Changed 2 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:12 Changed 2 years ago by Matthias Köppe

Status: needs_workpositive_review

Hm... merges cleanly into your develop branch

comment:13 Changed 2 years ago by Volker Braun

Status: positive_reviewneeds_work

merge conflict

comment:14 Changed 2 years ago by Volker Braun

    STDOUT: CONFLICT (content): Merge conflict in build/bin/sage-guess-package-system
    STDOUT: Automatic merge failed; fix conflicts and then commit the result.

comment:15 Changed 2 years ago by Matthias Köppe

Branch: u/dimpase/add_system_package_information_for_freebsdu/mkoeppe/add_system_package_information_for_freebsd

comment:16 Changed 2 years ago by Matthias Köppe

Commit: 42cb33cb456e708cc9db31ff2d35a8fa2c890f5dcb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
Status: needs_workpositive_review

New commits:

b9a6147Add support for FreeBSD
cb698c7Add system package information for FreeBSD

comment:17 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/add_system_package_information_for_freebsdcb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.