Opened 2 years ago

Closed 2 years ago

#29653 closed enhancement (fixed)

Add system package information for FreeBSD

Reported by: gh-thierry-FreeBSD Owned by:
Priority: major Milestone: sage-9.2
Component: build Keywords: FreeBSD; system packages
Cc: mkoeppe, mjo, dimpase Merged in:
Authors: Thierry Thomas Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cb698c7 (Commits, GitHub, GitLab) Commit: cb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
Dependencies: #30044 Stopgaps:

Status badges

Description

Add system package information for FreeBSD, as asked by mkoeppe in #26249 comment:41.

Also add a patch to configure.ac: without it configure is rejected.

Attachments (4)

patch-configure.ac​ (823 bytes) - added by gh-thierry-FreeBSD 2 years ago.
Add FreeBSD support in configure
build_bin_sage-guess-package-system.diff​ (353 bytes) - added by gh-thierry-FreeBSD 2 years ago.
Add support of FreeBSD pkg in build/bin/sage-guess-package-system
build_bin_sage-print-system-package-command​ (490 bytes) - added by gh-thierry-FreeBSD 2 years ago.
Add support of FreeBSD pkg in build/bin/sage-print-system-package-command
build_pkgs_freebsd.txt.tar.gz​ (3.2 KB) - added by gh-thierry-FreeBSD 2 years ago.
Add the freebsd.txt files to build/pkg/

Download all attachments as: .zip

Change History (21)

Changed 2 years ago by gh-thierry-FreeBSD

Add FreeBSD support in configure

Changed 2 years ago by gh-thierry-FreeBSD

Add support of FreeBSD pkg in build/bin/sage-guess-package-system

Changed 2 years ago by gh-thierry-FreeBSD

Add support of FreeBSD pkg in build/bin/sage-print-system-package-command

Changed 2 years ago by gh-thierry-FreeBSD

Add the freebsd.txt files to build/pkg/

comment:1 follow-up: Changed 2 years ago by mkoeppe

git branch please

comment:2 in reply to: ↑ 1 Changed 2 years ago by gh-thierry-FreeBSD

Last edited 2 years ago by gh-thierry-FreeBSD (previous) (diff)

comment:3 Changed 2 years ago by gh-thierry-FreeBSD

  • Branch set to u/gh-thierry-FreeBSD/add_system_package_information_for_freebsd

comment:4 Changed 2 years ago by mkoeppe

  • Commit set to 9138c47e45f8926ea93d5fe515f51630b7063a6b

The branch has some changes on configure.ac that are probably not intended

New commits:

​c6f9137Add support for FreeBSD
​9138c47Add system package information for FreeBSD

comment:5 Changed 2 years ago by mkoeppe

  • Cc mjo dimpase added

Can we get a version of this into sage before it bitrots completely?

comment:6 Changed 2 years ago by mkoeppe

  • Authors changed from gh-thierry-FreeBSD to Thierry Thomas

comment:7 Changed 2 years ago by dimpase

  • Branch changed from u/gh-thierry-FreeBSD/add_system_package_information_for_freebsd to u/dimpase/add_system_package_information_for_freebsd
  • Commit changed from 9138c47e45f8926ea93d5fe515f51630b7063a6b to 42cb33cb456e708cc9db31ff2d35a8fa2c890f5d
  • Reviewers set to Dima Pasechnik
  • Status changed from new to needs_review

New commits:

​511fad0Add support for FreeBSD
​f57ac7eAdd system package information for FreeBSD
​42cb33ccorrect rebase for the latest configure.ac

comment:8 Changed 2 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:9 Changed 2 years ago by mkoeppe

  • Branch changed from u/dimpase/add_system_package_information_for_freebsd to u/mkoeppe/add_system_package_information_for_freebsd

comment:10 Changed 2 years ago by mkoeppe

  • Branch changed from u/mkoeppe/add_system_package_information_for_freebsd to u/dimpase/add_system_package_information_for_freebsd
  • Dependencies set to #30044

Merged #30044 to prevent merge conflict

comment:11 Changed 2 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:12 Changed 2 years ago by mkoeppe

  • Status changed from needs_work to positive_review

Hm... merges cleanly into your develop branch

comment:13 Changed 2 years ago by vbraun

  • Status changed from positive_review to needs_work

merge conflict

comment:14 Changed 2 years ago by vbraun 

    STDOUT: CONFLICT (content): Merge conflict in build/bin/sage-guess-package-system
    STDOUT: Automatic merge failed; fix conflicts and then commit the result.

comment:15 Changed 2 years ago by mkoeppe

  • Branch changed from u/dimpase/add_system_package_information_for_freebsd to u/mkoeppe/add_system_package_information_for_freebsd

comment:16 Changed 2 years ago by mkoeppe

  • Commit changed from 42cb33cb456e708cc9db31ff2d35a8fa2c890f5d to cb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
  • Status changed from needs_work to positive_review

New commits:

​b9a6147Add support for FreeBSD
​cb698c7Add system package information for FreeBSD

comment:17 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/add_system_package_information_for_freebsd to cb698c7f3f005fe3e9ad93d5bd2d22c2420417f0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.