#2964 closed enhancement (fixed)
[with patch, positive review] Improvements to weyl_group.py
Reported by: | bump | Owned by: | mhansen |
---|---|---|---|
Priority: | minor | Milestone: | sage-3.0 |
Component: | combinatorics | Keywords: | |
Cc: | sage-combinat | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
WeylGroup? gets a proper call method that produces a WeylGroup? element. Previously if G is a Weyl group then G(m) produced a MatrixRing? element. This part is a bugfix.
Root systems get a method to produce the highest root, relevant to the affine root system. This could be implemented as a case-by-case method and that would be faster, but searching through the roots for the highest weight is of acceptable speed.
Weyl Groups get a method to produce the long element of the Weyl group. Not implemented yet for E7 and E8.
Weyl group also gets a method to produce the identity element as a WeylGroup? element. Strictly speaking this is not necessary since W(1) will also produce the unit.
Attachments (4)
Change History (12)
Changed 10 years ago by
Changed 10 years ago by
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
- Summary changed from Improvements to weyl_group.py to [with patch, needs review] Improvements to weyl_group.py
comment:3 Changed 10 years ago by
There will be a further patch because I forgot to finish the doctests.
comment:4 Changed 10 years ago by
Okay, excellent. I'll review them when you put them up.
Changed 10 years ago by
comment:5 Changed 10 years ago by
I added a third patch with doctest for long element and now I think it is OK.
Thanks, Dan
Changed 10 years ago by
comment:6 Changed 10 years ago by
- Summary changed from [with patch, needs review] Improvements to weyl_group.py to [with patch, positive review] Improvements to weyl_group.py
Looks good to me. Apply all four patches.
comment:7 Changed 10 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged all four patches in Sage 3.0.rc0
comment:8 Changed 9 years ago by
- Cc sage-combinat added
These are patches against 3.0alpha6.