Opened 2 years ago

Closed 2 years ago

#29636 closed enhancement (fixed)

Delete changelog sections from all SPKG.txt files

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.2
Component: build Keywords:
Cc: John Palmieri, Dima Pasechnik, Frédéric Chapoton, Samuel Lelièvre, William Stein Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 079224e (Commits, GitHub, GitLab) Commit: 079224e0fed934534f72e9bfa9feeaef6e532763
Dependencies: Stopgaps:

Status badges

Description

They only cover ancient history.

Change History (12)

comment:1 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/delete_changelog_sections_from_all_spkg_txt_files

comment:2 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Frédéric Chapoton added
Commit: 079224e0fed934534f72e9bfa9feeaef6e532763
Status: newneeds_review

New commits:

aa9ada9Delete changelog sections from all SPKG.txt files
079224eRemove remaining SPKG.txt changelog sections manually

comment:3 Changed 2 years ago by Matthias Köppe

Priority: majorcritical

It's critical to remove these sections because they make look Sage's packages much more outdated than they are.

comment:4 Changed 2 years ago by Dima Pasechnik

I agree that something needs to be done, but not this way - these changelogs may hold sentimental value for people involved (especially as Sage used to be developed using patches rather than commits to a VCS).

How about moving these sections into separate files named old_changelog.txt or something like this? (each of them may start with a notice like

Historical - check git logs for recent changes

comment:5 Changed 2 years ago by Matthias Köppe

We do have historical changelogs on the website, listing individual contributions of authors. http://www.sagemath.org/changelogs/index.html I would think that it is sufficient.

Keeping this in the source tree can't be the right solution.

In particular, if we keep the old spkg changelogs in the tree, then the contributions of newer contributors are not represented.

comment:6 Changed 2 years ago by Matthias Köppe

Cc: Samuel Lelièvre added

comment:7 Changed 2 years ago by Matthias Köppe

Cc: William Stein added

comment:8 Changed 2 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

OK, then perhaps something like mentioning a git incantation to use to see the data removed here, in https://wiki.sagemath.org/ReleaseTours/sage-9.1 (or perhaps just copy it there, under a separate heading)

comment:9 Changed 2 years ago by Matthias Köppe

See #29640 - Create an AUTHORS.md file with links

comment:10 Changed 2 years ago by Matthias Köppe

I have also added a "Spring cleaning" section to https://wiki.sagemath.org/ReleaseTours/sage-9.1 which mentions this removal

comment:11 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

comment:12 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/delete_changelog_sections_from_all_spkg_txt_files079224e0fed934534f72e9bfa9feeaef6e532763
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.