Opened 2 years ago
Closed 18 months ago
#29630 closed enhancement (fixed)
spkgconfigure.m4 for libhomfly
Reported by:  ghthierryFreeBSD  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  build: configure  Keywords:  libhomfly; spkgconfigure; system packages 
Cc:  tscrim, mjo, dimpase, ghsheerluck  Merged in:  
Authors:  Thierry Thomas, Dima Pasechnik  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  6b90412 (Commits, GitHub, GitLab)  Commit:  6b90412c119e319cc66757afc2d8580e10975819 
Dependencies:  #28991, #30626  Stopgaps: 
Description (last modified by )
This ticket adds an spkgconfigure.m4 for libhomfly, in order to use it from a system package if possible (see #27330).
No problem detected with this one: Sage builds flawlessy with the system package on FreeBSD, and the platforms tested on GH Actions.
Attachments (1)
Change History (29)
Changed 2 years ago by
comment:1 Changed 22 months ago by
On Debian there is libhomflydev, version 1.02r5 (Sage has 1.02r4)
comment:3 Changed 22 months ago by
 Cc tscrim added
comment:4 Changed 21 months ago by
 Cc mjo dimpase added
comment:5 Changed 21 months ago by
comment:6 Changed 21 months ago by
 Branch set to u/dimpase/packages/libhomfly/configm4
 Commit set to fd23a02164e81f1f48a9aa767d069a1ce2000e07
 Dependencies set to #28991
 Status changed from new to needs_review
comment:7 Changed 21 months ago by
tests run on https://github.com/dimpase/sage/pull/16
comment:8 followup: ↓ 11 Changed 21 months ago by
I just added libhomfly to Gentoo as scilibs/libhomfly
so that can be put in gentoo.txt
. The system copy is detected fine FWIW.
comment:9 Changed 21 months ago by
 Cc ghsheerluck added
comment:10 Changed 21 months ago by
 Commit changed from fd23a02164e81f1f48a9aa767d069a1ce2000e07 to b94b80cd096e1db799f9eb9a3ee42dd79acc237e
Branch pushed to git repo; I updated commit sha1. New commits:
b94b80c  added gentoo pkg info

comment:11 in reply to: ↑ 8 Changed 21 months ago by
Replying to mjo:
I just added libhomfly to Gentoo as
scilibs/libhomfly
so that can be put ingentoo.txt
. The system copy is detected fine FWIW.
OK, done, thanks.
comment:12 Changed 21 months ago by
 Commit changed from b94b80cd096e1db799f9eb9a3ee42dd79acc237e to 5a9d7eab2829271de100f9ec2fa5a3572b7652f0
comment:13 Changed 21 months ago by
 Commit changed from 5a9d7eab2829271de100f9ec2fa5a3572b7652f0 to 92b6a0d6a37ea139a16a7ef4eb083bec653f2963
comment:14 Changed 21 months ago by
debianbusterstandard
(https://github.com/sagemath/sage/runs/1068090166):
E: Unable to locate package libhomfly
Need to add IGNORE_MISSING_SYSTEM_PACKAGES=yes
for this platform in tox.ini
.
Best done on top of #27754 to avoid a merge conflict
comment:15 Changed 21 months ago by
Same on ubuntueoanstandard
comment:16 Changed 21 months ago by
 Status changed from needs_review to needs_work
comment:17 Changed 21 months ago by
please feel free to add commits, or open a followup ticket and waive this one through.
I have little idea about IGNORE_MISSING_SYSTEM_PACKAGES (it's undocumented as of 9.2.beta12), I can only gather it has something to do with generated docker images.
comment:18 Changed 20 months ago by
 Dependencies changed from #28991 to #28991, #30626
comment:19 Changed 20 months ago by
Actually this was just bad package info, fixed in #30626.
comment:20 Changed 20 months ago by
 Branch changed from u/dimpase/packages/libhomfly/configm4 to u/mkoeppe/packages/libhomfly/configm4
comment:21 Changed 20 months ago by
 Commit changed from 92b6a0d6a37ea139a16a7ef4eb083bec653f2963 to 8c7423b8c1b576bb860d6c80610a39dfe0e2f4a1
 Status changed from needs_work to needs_review
comment:22 Changed 20 months ago by
 Reviewers set to https://github.com/mkoeppe/sage/actions/runs/265872338
comment:23 Changed 20 months ago by
 Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/265872338 to Matthias Koeppe
 Status changed from needs_review to positive_review
comment:24 Changed 20 months ago by
 Description modified (diff)
comment:25 Changed 20 months ago by
 Commit changed from 8c7423b8c1b576bb860d6c80610a39dfe0e2f4a1 to 6b90412c119e319cc66757afc2d8580e10975819
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
6b90412  build/pkgs/libhomfly/distros/fedora.txt: Fixup

comment:26 Changed 20 months ago by
 Status changed from needs_review to positive_review
comment:27 Changed 19 months ago by
 Milestone changed from sage9.2 to sage9.3
comment:28 Changed 18 months ago by
 Branch changed from u/mkoeppe/packages/libhomfly/configm4 to 6b90412c119e319cc66757afc2d8580e10975819
 Resolution set to fixed
 Status changed from positive_review to closed
To be put under build/pkgs/libhomfly