#29589 closed defect (duplicate)

Syntax error is spkg-check

Reported by: vbraun Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: jhpalmieri, embray, dimpase, mkoeppe Merged in:
Authors: Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Thats on Debian 9:

Copying package files from temporary location /var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage/build/pari-2.11.2/inst to /var/lib/buildbot/slave/sage_git/build/local
Running the test suite for pari-2.11.2...
./spkg-check: line 38: syntax error near unexpected token `else'
./spkg-check: line 38: `else'

Change History (11)

comment:1 Changed 12 months ago by jhpalmieri

  • Cc mkoeppe added

comment:2 Changed 12 months ago by mkoeppe

Some more details would be needed here.

comment:3 Changed 12 months ago by mkoeppe

@vbraun By the way, the announcement of 9.1.rc2 is missing

comment:4 Changed 12 months ago by mkoeppe

  • Status changed from new to needs_info

comment:5 Changed 12 months ago by vbraun

Relevant lines of spgk-check:

     32 
     33 ###########################################
     34 ## PARI
     35 ###########################################
     36 
     37 if [ "x$SAGE_DEBUG" = xyes ] ; then
     38     CFLAGS="$CFLAGS -O0 -g" # Disable optimisation, add debug symbols. Good
     39                             # for debugging or working around compiler bugs.
     40 else
     41     CFLAGS="-O3 -g $CFLAGS" # Default optimisation, with debug symbols.
     42                             # Prepend to not override user's setting.
     43 fi

comment:6 Changed 12 months ago by mkoeppe

These lines have not been touched since 2010. Are you using some experimental bash version on that bot? This error does not show on any of the platforms that I test, including debian-stretch

comment:7 Changed 12 months ago by vbraun

No, nothing has changed on the buildbot in a long time. I just noticed the snipped is likely wrong as I did another build in the meantime.

comment:8 Changed 12 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-duplicate/invalid/wontfix
  • Priority changed from blocker to major
  • Status changed from needs_info to needs_review

Likely from when you tested #27122, not from 9.1.rc2

comment:9 Changed 12 months ago by gh-kliem

  • Status changed from needs_review to positive_review

Yes, this is me in #27122. I'll fix it there.

comment:10 Changed 12 months ago by mkoeppe

  • Reviewers set to Jonathan Kliem

comment:11 Changed 11 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.