Opened 13 months ago
Last modified 7 weeks ago
#29581 needs_info enhancement
New Algorithm for Characteristic Classes
Reported by:  ghmjungmath  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  characteristic_classes, manifolds 
Cc:  slelievre, egourgoulhon  Merged in:  
Authors:  Michael Jung  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/ghmjungmath/new_algorithm (Commits, GitHub, GitLab)  Commit:  19815c4257cee7dcf503d94e3b9bb651150bef5f 
Dependencies:  #30211  Stopgaps: 
Description (last modified by )
Alternative algorithm for characteristic classes involving chern roots.
Change History (19)
comment:1 Changed 13 months ago by
 Branch set to u/ghmjungmath/new_algorithm
comment:2 Changed 13 months ago by
 Commit set to 1a803eba5b9724ebfa93e726a474d957fd6915b4
 Milestone changed from sage9.1 to sage9.2
comment:3 Changed 13 months ago by
 Cc slelievre added
 Component changed from PLEASE CHANGE to geometry
comment:4 Changed 13 months ago by
Please add a short description in the "Description" field of the ticket,
and the author's full name in the "Authors" field of the ticket. Don't forget
to set to needs_review
when this is ready for review.
comment:5 Changed 12 months ago by
 Commit changed from 1a803eba5b9724ebfa93e726a474d957fd6915b4 to cb442eb8919ca33a5db63a17bac52f99f55553dd
Branch pushed to git repo; I updated commit sha1. New commits:
730046c  Merge branch 'develop' into t/29570/diff_form_bug

130ae3f  Trac #29570: NotImplementedError for nongeneric ring elements

bba21e1  Trac #29570: Strange typo fixed...

ba3b4b9  Trac #29570: correct parent, vectorfield_module changes reverted

841e1bf  Merge branch 't/29570/diff_form_bug' into t/29581/new_algorithm

cb442eb  Trac #29570: new algorithm added and code cleaned

comment:6 Changed 12 months ago by
 Commit changed from cb442eb8919ca33a5db63a17bac52f99f55553dd to 15c7341d071327a04fd229c3d2f78d583564f476
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
15c7341  Trac #29581: new algorithm added and code cleaned

comment:7 Changed 12 months ago by
 Cc egourgoulhon added
 Description modified (diff)
 Keywords characteristic_classes manifolds added
 Type changed from PLEASE CHANGE to enhancement
comment:8 Changed 12 months ago by
Correct syntax for crosslinks is
.. SEEALSO::
comment:9 Changed 12 months ago by
 do not use this:
if distinct_real == False
but
if not distinct_real
(at least in two places)
 The following change is wrong:
  ``cmatrix``  curvature matrix  +  ``cmatrix``  curvature matrix OUTPUT:   ``I/(2*pi)*cmatrix`` +  ``I/(2*pi)*cmatrix``
as one should not indent inside INPUT or OUTPUT blocks (because they end with only one colon). And moreover, one does want empty lines to separate these things.
This is also incorrect:
 self._dual_exterior_powers[p] = ExtPowerDualFreeModule(self, p) + self._dual_exterior_powers[p] = ExtPowerDualFreeModule(self, p)
Why did you change the indentation ? it was ok.
comment:10 Changed 12 months ago by
I am sorry. At this stage, this is just a draft. The indentations are typos coming from using alt+tab (at least I guess so). I will fix this soon.
comment:11 Changed 12 months ago by
Thanks for your advice. :)
comment:12 Changed 12 months ago by
 Commit changed from 15c7341d071327a04fd229c3d2f78d583564f476 to d37229341effff46ea2fa4b3287e32997c8422b0
Branch pushed to git repo; I updated commit sha1. New commits:
d372293  Trac #29581: Strange typos reverted

comment:13 Changed 12 months ago by
 Status changed from new to needs_review
comment:14 Changed 12 months ago by
 Status changed from needs_review to needs_info
comment:15 Changed 12 months ago by
An example for the application of the new algorithm would be really nice. For instance a Todd class or AHat class. But I have no idea for a suitable one. If anyone does, or at least knows someone who does, I would really appreciate it. Thanks! :)
comment:16 Changed 12 months ago by
 Commit changed from d37229341effff46ea2fa4b3287e32997c8422b0 to 19815c4257cee7dcf503d94e3b9bb651150bef5f
comment:17 Changed 10 months ago by
 Component changed from geometry to manifolds
 Dependencies set to #30211
comment:18 Changed 6 months ago by
 Milestone changed from sage9.2 to sage9.3
comment:19 Changed 7 weeks ago by
 Milestone changed from sage9.3 to sage9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
New commits:
Trac #29570: alternating_form returns correct element
Trac #29570: Typo fixed, doctest added, returned element preferably nonzero
Trac #29581: New Algorithm for Char Classes