Opened 2 years ago

Closed 2 years ago

#29566 closed enhancement (fixed)

CombinatorialPolyhedron: Store incidence matrix on initialization

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-9.2
Component: geometry Keywords: combinatorial polyhedron, incidence matrix
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 5d1a52e (Commits, GitHub, GitLab) Commit: 5d1a52e4c73c33f69aeae6ad9e42265750394adb
Dependencies: Stopgaps:

Status badges

Description

In case the combinatorial polyhedron is initialized from a matrix, we store the incidence matrix to avoid recomputation.

Note, that this is also the case when the combinatorial polyhedron is obtained e.g. from a polyhedron. In this case the incidence matrix is computed and then this is used to initialize the combinatorial polyhedron.

Change History (8)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to public/29566
  • Commit set to 5d1a52e4c73c33f69aeae6ad9e42265750394adb
  • Status changed from new to needs_review

New commits:

5d1a52estore incidence matrix, if initialized from it

comment:2 Changed 2 years ago by gh-LaisRast

  • Status changed from needs_review to needs_work
  • I would suggest adding the definitions of "k-neighborly" and "neighborly" instead of referring to Wikipedia.
  • The sentence for the d-simplex is not a definition. It is just an example. So why should it be mentioned?
  • -        - ``True`` if the every set of up to ``k`` vertices forms a face,
    +        - ``True`` if every set of up to ``k`` vertices forms a face
    
Version 0, edited 2 years ago by gh-LaisRast (next)

comment:3 Changed 2 years ago by gh-kliem

Please move your comment to the correct ticket.

comment:4 Changed 2 years ago by gh-kliem

  • Status changed from needs_work to needs_review

comment:5 Changed 2 years ago by gh-LaisRast

Sorry. I removed my comment and put it in the correct ticket.

comment:6 Changed 2 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to positive_review

Looks good to me.

comment:7 Changed 2 years ago by gh-kliem

Thank you.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from public/29566 to 5d1a52e4c73c33f69aeae6ad9e42265750394adb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.