Opened 12 months ago
Closed 11 months ago
#29565 closed enhancement (fixed)
Migrate neighborly to combinatorial polyhedron
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  geometry  Keywords:  neighborly polytopes 
Cc:  jipilab, ghLaisRast  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  JeanPhilippe Labbé, Laith Rastanawi 
Report Upstream:  N/A  Work issues:  
Branch:  aa535d8 (Commits, GitHub, GitLab)  Commit:  aa535d84ce1eefcaca325c9afa4c3bd10007e790 
Dependencies:  Stopgaps: 
Description
We migrate is_neighborly
and neighborliness
to CombinatorialPolyhedron
.
It is also faster now, as use the fvector instead of indirectly getting the number of kfaces.
Along the way we add is_simplex
to CombinatorialPolyhedron
and cache the methods f_vector
and n_vertices
.
Change History (10)
comment:1 Changed 12 months ago by
 Branch set to public/29565
 Commit set to 847740aed1da968534913501432632df51e09daf
 Status changed from new to needs_review
comment:2 Changed 12 months ago by
 Status changed from needs_review to needs_work
 I would suggest adding the definitions of "kneighborly" and "neighborly" instead of referring to Wikipedia.
 The sentence for the dsimplex is not a definition. It is just an example. So why should it be mentioned?
*
  ``True`` if the every set of up to ``k`` vertices forms a face, +  ``True`` if every set of up to ``k`` vertices forms a face
comment:3 Changed 12 months ago by
 Commit changed from 847740aed1da968534913501432632df51e09daf to 0f740364f03176edd7435181a63a663456ea70d8
Branch pushed to git repo; I updated commit sha1. New commits:
0f74036  improvements in the documentation

comment:4 Changed 12 months ago by
 Status changed from needs_work to needs_review
comment:5 Changed 11 months ago by
 Branch changed from public/29565 to public/29565reb
 Commit changed from 0f740364f03176edd7435181a63a663456ea70d8 to 80ce9f989a8ef6c0d690704544fddfbcf3e711b3
comment:6 Changed 11 months ago by
 Reviewers set to JeanPhilippe Labbé
 Status changed from needs_review to needs_work
Small coding style:
+ @cached_method + def neighborliness(self): + r"""  Returns the largest ``k``, such that the polyhedron is ``k``neighborly. + Return the largest ``k``, such that the polyhedron is ``k``neighborly.
You can put this on positive review on my behalf once this is fixed.
comment:7 Changed 11 months ago by
 Commit changed from 80ce9f989a8ef6c0d690704544fddfbcf3e711b3 to aa535d84ce1eefcaca325c9afa4c3bd10007e790
Branch pushed to git repo; I updated commit sha1. New commits:
aa535d8  coding style

comment:8 Changed 11 months ago by
 Status changed from needs_work to positive_review
comment:9 Changed 11 months ago by
 Reviewers changed from JeanPhilippe Labbé to JeanPhilippe Labbé, Laith Rastanawi
comment:10 Changed 11 months ago by
 Branch changed from public/29565reb to aa535d84ce1eefcaca325c9afa4c3bd10007e790
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
migrate neighborly to combinatorial polyhedron