#29565 closed enhancement (fixed)

Migrate neighborly to combinatorial polyhedron

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: neighborly polytopes
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé, Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: aa535d8 (Commits, GitHub, GitLab) Commit: aa535d84ce1eefcaca325c9afa4c3bd10007e790
Dependencies: Stopgaps:

Status badges

Description

We migrate is_neighborly and neighborliness to CombinatorialPolyhedron. It is also faster now, as use the f-vector instead of indirectly getting the number of k-faces.

Along the way we add is_simplex to CombinatorialPolyhedron and cache the methods f_vector and n_vertices.

Change History (10)

comment:1 Changed 15 months ago by gh-kliem

  • Branch set to public/29565
  • Commit set to 847740aed1da968534913501432632df51e09daf
  • Status changed from new to needs_review

New commits:

847740amigrate neighborly to combinatorial polyhedron

comment:2 Changed 15 months ago by gh-LaisRast

  • Status changed from needs_review to needs_work
  • I would suggest adding the definitions of "k-neighborly" and "neighborly" instead of referring to Wikipedia.
  • The sentence for the d-simplex is not a definition. It is just an example. So why should it be mentioned?

*

-        - ``True`` if the every set of up to ``k`` vertices forms a face,
+        - ``True`` if every set of up to ``k`` vertices forms a face

comment:3 Changed 15 months ago by git

  • Commit changed from 847740aed1da968534913501432632df51e09daf to 0f740364f03176edd7435181a63a663456ea70d8

Branch pushed to git repo; I updated commit sha1. New commits:

0f74036improvements in the documentation

comment:4 Changed 15 months ago by gh-kliem

  • Status changed from needs_work to needs_review

comment:5 Changed 15 months ago by gh-kliem

  • Branch changed from public/29565 to public/29565-reb
  • Commit changed from 0f740364f03176edd7435181a63a663456ea70d8 to 80ce9f989a8ef6c0d690704544fddfbcf3e711b3

New commits:

f5caca8migrate neighborly to combinatorial polyhedron
80ce9f9improvements in the documentation

comment:6 Changed 15 months ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to needs_work

Small coding style:

+    @cached_method
+    def neighborliness(self):
+        r"""
-        Returns the largest ``k``, such that the polyhedron is ``k``-neighborly.
+        Return the largest ``k``, such that the polyhedron is ``k``-neighborly.

You can put this on positive review on my behalf once this is fixed.

comment:7 Changed 15 months ago by git

  • Commit changed from 80ce9f989a8ef6c0d690704544fddfbcf3e711b3 to aa535d84ce1eefcaca325c9afa4c3bd10007e790

Branch pushed to git repo; I updated commit sha1. New commits:

aa535d8coding style

comment:8 Changed 15 months ago by gh-kliem

  • Status changed from needs_work to positive_review

Thank you.


New commits:

aa535d8coding style

New commits:

aa535d8coding style

comment:9 Changed 15 months ago by gh-LaisRast

  • Reviewers changed from Jean-Philippe Labbé to Jean-Philippe Labbé, Laith Rastanawi

comment:10 Changed 14 months ago by vbraun

  • Branch changed from public/29565-reb to aa535d84ce1eefcaca325c9afa4c3bd10007e790
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.