Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#29564 closed enhancement (fixed)

fix some details suggested by lgtm in number fields and quaternions

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.1
Component: number fields Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d425680 (Commits, GitHub, GitLab) Commit: d42568035927110a65689ab01a05fc66728ebfc0
Dependencies: Stopgaps:

Status badges

Description


Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/29564
  • Commit set to 24d78d1e11d2c363b9585ba9597166f52a0a1a29
  • Status changed from new to needs_review

New commits:

​24d78d1some lgtm-suggested details in number fields and quaternions

comment:2 Changed 2 years ago by git

  • Commit changed from 24d78d1e11d2c363b9585ba9597166f52a0a1a29 to d42568035927110a65689ab01a05fc66728ebfc0

Branch pushed to git repo; I updated commit sha1. New commits:

​d425680details

comment:3 Changed 2 years ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

Last edited 2 years ago by tscrim (previous) (diff)

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/29564 to d42568035927110a65689ab01a05fc66728ebfc0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.1
Note: See TracTickets for help on using tickets.