#29564 closed enhancement (fixed)
fix some details suggested by lgtm in number fields and quaternions
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-9.1 |
Component: | number fields | Keywords: | |
Cc: | tscrim | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | d425680 (Commits, GitHub, GitLab) | Commit: | d42568035927110a65689ab01a05fc66728ebfc0 |
Dependencies: | Stopgaps: |
Description
Change History (6)
comment:1 Changed 2 years ago by
- Branch set to u/chapoton/29564
- Commit set to 24d78d1e11d2c363b9585ba9597166f52a0a1a29
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Commit changed from 24d78d1e11d2c363b9585ba9597166f52a0a1a29 to d42568035927110a65689ab01a05fc66728ebfc0
Branch pushed to git repo; I updated commit sha1. New commits:
d425680 | details
|
comment:4 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:5 Changed 2 years ago by
- Branch changed from u/chapoton/29564 to d42568035927110a65689ab01a05fc66728ebfc0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:6 Changed 2 years ago by
- Milestone changed from sage-9.2 to sage-9.1
Note: See
TracTickets for help on using
tickets.
New commits:
some lgtm-suggested details in number fields and quaternions