Opened 3 years ago

Closed 3 years ago

#29560 closed enhancement (fixed)

sage-guess-package-system: Ignore conda if no environment is activated

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.1
Component: build: configure Keywords:
Cc: isuruf, jhpalmieri, dimpase, slelievre Merged in:
Authors: Matthias Koeppe Reviewers: Isuru Fernando
Report Upstream: N/A Work issues:
Branch: 27f6bac (Commits, GitHub, GitLab) Commit: 27f6bac140df0e7b88e3ec8d8edfcbaa1aa2bec6
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This is so that users can get installation hints e.g. for homebrew after running conda deactivate (as for example advised by the Anaconda detection code added by #27699)

Change History (11)

comment:1 Changed 3 years ago by mkoeppe

Component: PLEASE CHANGEbuild: configure
Description: modified (diff)

comment:2 Changed 3 years ago by mkoeppe

Authors: Matthias Koeppe
Cc: dimpase added
Status: newneeds_review

comment:3 Changed 3 years ago by jhpalmieri

I don't see a branch.

comment:4 Changed 3 years ago by mkoeppe

Branch: u/mkoeppe/sage_guess_package_system__ignore_conda_if_no_environment_is_activated

comment:5 Changed 3 years ago by mkoeppe

Commit: 27f6bac140df0e7b88e3ec8d8edfcbaa1aa2bec6

Ready for review


New commits:

27f6bacbuild/bin/sage-guess-package-system: Ignore conda if no environment is active

comment:6 Changed 3 years ago by mkoeppe

Description: modified (diff)

comment:7 Changed 3 years ago by mkoeppe

Cc: slelievre added

comment:8 Changed 3 years ago by mkoeppe

Let's get this one in please

comment:9 Changed 3 years ago by isuruf

Reviewers: Isuru Fernando
Status: needs_reviewpositive_review

comment:10 Changed 3 years ago by mkoeppe

Thanks!

comment:11 Changed 3 years ago by vbraun

Branch: u/mkoeppe/sage_guess_package_system__ignore_conda_if_no_environment_is_activated27f6bac140df0e7b88e3ec8d8edfcbaa1aa2bec6
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.