Opened 9 months ago

Closed 9 months ago

#29554 closed defect (fixed)

fix buggy test in #29445

Reported by: dimpase Owned by:
Priority: blocker Milestone: sage-9.1
Component: build: configure Keywords:
Cc: mkoeppe, gh-kliem, chapoton, vdelecroix, kedlaya Merged in:
Authors: Dima Pasechnik Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: bf8c1d9 (Commits) Commit: bf8c1d99fb0dd21dddda1b16e6f58f5bbe40c910
Dependencies: Stopgaps:

Description (last modified by dimpase)

configure:17249: checking whether hyperellcharpoly bug is fixed
  ***   too many arguments: ...lcharpoly(x^10+x^9+x^8+x,0*Mod(1,3))
  ***                                                   ^-----------
configure:17257: result: no; cannot use system pari/GP with known bug

also should fix the error in another ticket #29494 touching this stuff

Attachments (1)

config.log (243.4 KB) - added by vdelecroix 9 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 9 months ago by dimpase

{{{
configure:17249: checking whether hyperellcharpoly bug is fixed
  ***   too many arguments: ...lcharpoly(x^10+x^9+x^8+x,0*Mod(1,3))
  ***                                                   ^-----------
configure:17257: result: no; cannot use system pari/GP with known bug

}}}

comment:2 Changed 9 months ago by dimpase

missing extra pair of []:

-        bug_check=$(echo "hyperellcharpoly([x^10 + x^9 + x^8 + x,0]*Mod(1,3))" | $GP -qf 2>> config.log)
+        bug_check=`echo "hyperellcharpoly([[x^10 + x^9 + x^8 + x,0]]*Mod(1,3))" | $GP -qf 2>> config.log`

comment:3 Changed 9 months ago by dimpase

  • Description modified (diff)

comment:4 Changed 9 months ago by dimpase

  • Description modified (diff)

comment:5 Changed 9 months ago by dimpase

  • Description modified (diff)

comment:6 Changed 9 months ago by dimpase

  • Authors set to Dima Pasechnik
  • Cc mkoeppe added

comment:7 Changed 9 months ago by dimpase

  • Branch set to u/dimpase/packages/parifixes
  • Cc gh-kliem chapoton vdelecroix kedlaya added
  • Commit set to 526d15c3116768a776f28aff14488ecd0cd012ee
  • Status changed from new to needs_review

New commits:

526d15cfix buggy tests in #29445 and in #29494

comment:8 Changed 9 months ago by git

  • Commit changed from 526d15c3116768a776f28aff14488ecd0cd012ee to bf8c1d99fb0dd21dddda1b16e6f58f5bbe40c910

Branch pushed to git repo; I updated commit sha1. New commits:

bf8c1d9use macro to check pari/gp deps

Changed 9 months ago by vdelecroix

comment:9 follow-up: Changed 9 months ago by vdelecroix

configure is now happy with my pari. However there is something that I don't understand in config.log line 2023. matpermanent is not found. Why is there a search for it if it does not matter?

comment:10 in reply to: ↑ 9 Changed 9 months ago by dimpase

Replying to vdelecroix:

configure is now happy with my pari. However there is something that I don't understand in config.log line 2023. matpermanent is not found. Why is there a search for it if it does not matter?

This is normal functioning of AC_SEARCH_LIBS macro.

matpermanent is used to detect that libpari is at least verision 2.11. First, an attempt is made to link without -lpari, adn it fails. The next attempt (line 2107), -lpari is added, and test passes.

Last edited 9 months ago by dimpase (previous) (diff)

comment:11 Changed 9 months ago by vdelecroix

  • Reviewers set to Vincent Delecroix

If you feel like testing on my computer was good enough for a review, you can set to positive review.

comment:12 Changed 9 months ago by dimpase

  • Status changed from needs_review to positive_review

Thanks, I think it's good.

comment:13 follow-up: Changed 9 months ago by gh-kliem

Thanks for the quick fix.

I started test runs a minute ago: https://github.com/kliem/sage-test-27122/actions/runs/85835472.

I will leave a message here tomorrow either way, but I don't expect any trouble.

comment:14 in reply to: ↑ 13 Changed 9 months ago by gh-kliem

Replying to gh-kliem:

Thanks for the quick fix.

I started test runs a minute ago: https://github.com/kliem/sage-test-27122/actions/runs/85835472.

I will leave a message here tomorrow either way, but I don't expect any trouble.

Yes. Seems to work fine.

comment:15 Changed 9 months ago by vbraun

  • Branch changed from u/dimpase/packages/parifixes to bf8c1d99fb0dd21dddda1b16e6f58f5bbe40c910
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.