Opened 21 months ago

Closed 4 months ago

#29542 closed enhancement (invalid)

spkg-configure.m4 for pynac

Reported by: gh-thierry-FreeBSD Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build: configure Keywords: spkg-configure pynac giac
Cc: fbissey, mjo, dimpase Merged in:
Authors: Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: public/29542 (Commits, GitHub, GitLab) Commit: 1c424ad023463a3d4f20b279b0b8ac5f38daa215
Dependencies: #32386 Stopgaps:

Status badges

Description

This ticket adds an spkg-configure.m4 for pynac, in order to use it from a system package if possible (see #27330).

Remark: it works as-is when pynac has been built without giac, i.e. if --without-giac has been set (when giac is installed, pynac finds and uses it by default). And if pynac has been built against giac, src/module_list.py must be patched.

Attachments (1)

spkg-configure.m4 (227 bytes) - added by gh-thierry-FreeBSD 21 months ago.
spkg-configure.m4 to be put under build/pkgs/pynac/

Download all attachments as: .zip

Change History (13)

Changed 21 months ago by gh-thierry-FreeBSD

spkg-configure.m4 to be put under build/pkgs/pynac/

comment:1 Changed 21 months ago by gh-thierry-FreeBSD

Note: about pynac being built against giac, see also https://github.com/pynac/pynac/issues/352

comment:2 Changed 21 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

comment:3 Changed 18 months ago by mkoeppe

  • Authors changed from gh-thierry-FreeBSD to Thierry Thomas
  • Cc fbissey mjo dimpase added
  • Keywords giac added

comment:4 Changed 16 months ago by mkoeppe

See also #30534 - Repackage pynac as a pip-installable package (then no spkg-configure would be needed)

comment:5 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:6 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:7 Changed 10 months ago by slelievre

  • Authors changed from Thierry Thomas to Thierry Thomas, Samuel Lelièvre
  • Branch set to public/29542
  • Commit set to 1c424ad023463a3d4f20b279b0b8ac5f38daa215
  • Status changed from new to needs_review

Here is a branch with Thierry's spkg-configure.m4 file and distro info.


New commits:

0c0252529542: Add spkg-configure.m4 for pynac
1c424ad29542: Add pynac distro information

comment:8 Changed 10 months ago by mkoeppe

  • Status changed from needs_review to needs_work

This is not ready. The spkg-configure.m4 would need to check that pynac works with the configured PYTHON_FOR_VENV; and the system pynac cannot be used at all if we build our own python3.

I'd rather go in the direction of #30534

comment:9 Changed 6 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

Setting a new milestone for this ticket based on a cursory review.

comment:10 Changed 5 months ago by mkoeppe

  • Authors Thierry Thomas, Samuel Lelièvre deleted
  • Dependencies set to #32386
  • Milestone changed from sage-9.5 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

#32386 makes this obsolete

comment:11 Changed 4 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:12 Changed 4 months ago by mkoeppe

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.