spkg-configure.m4 for giac

[gh-thierry-FreeBSD]

This ticket adds an spkg-configure.m4 for giac, in order to use it from a system package if possible.

​https://repology.org/project/giac/versions

See also:

• #30537 Upgrade giac to 1.6.0-7

[gh-thierry-FreeBSD]

spkg-configure.m4 to be put under build/pkgs/giac/

[mkoeppe]

Do we know which versions of system giac are acceptable? According to our update tickets (see #29552) >= 1.5.0-63 and < 1.6 are fine.

What does the check for ConvertUTF16toUTF8 in the proposed spkg-configure.m4 test? Does this test for a minimum version?

Is there a way to test the patchlevel of giac? giac --version does not include this information.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​43ee06b

build/pkgs/giac/distros: Add debian, fedora, opensuse

[mkoeppe]

ubuntu-focal-standard (​https://github.com/mkoeppe/sage/runs/969005184), debian-bullseye-standard: pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac. So some package is still missing

[mkoeppe]

fedora-32-standard (​https://github.com/mkoeppe/sage/runs/969005556):

Checking whether SageMath should install SPKG giac...
checking whether any of pari is installed as or will be installed as SPKG... no
checking giac/giac.h usability... no
checking giac/giac.h presence... no
checking for giac/giac.h... no
configure: no suitable system package found for SPKG giac

[mkoeppe]

archlinux-latest-standard (​https://github.com/mkoeppe/sage/runs/969005637):

   TypeError: unable to start giac because the command 'giac --sage' failed: The command was not found or was not executable: giac.

[mkoeppe]

Replying to mkoeppe:

ubuntu-focal-standard (​https://github.com/mkoeppe/sage/runs/969005184), debian-bullseye-standard: pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac. So some package is still missing

debian has the giac executable in package xcas, which pulls in a lot of dependencies

[mkoeppe]

Replying to mkoeppe:

fedora-32-standard (​https://github.com/mkoeppe/sage/runs/969005556):

... missing giac-devel

[mkoeppe]

Replying to mkoeppe:

archlinux-latest-standard (​https://github.com/mkoeppe/sage/runs/969005637):

need package giac

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​1923160	build/pkgs/giac/spkg-configure.m4: Test for giac executable
​1016934	build/pkgs/giac/distros: Add missing packages

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c076383	src/sage/interfaces/giac.py: Make new latex doctest more flexible
​b4f2434	Merge branch 't/29552/upgrade_giac_to_1_5_0_87' into t/29541/spkg_configure_m4_for_giac

[mkoeppe]

This fixed ubuntu-focal-standard (​https://github.com/mkoeppe/sage/runs/974323603); waiting for other runs to finish.

[mkoeppe]

archlinux-latest-standard (​https://github.com/mkoeppe/sage/runs/974324005) now finds system giac 1.6.0.7 and reproduces the doctest errors reported in ​https://trac.sagemath.org/ticket/29552#comment:2

[mkoeppe]

fedora-32-standard (​https://github.com/mkoeppe/sage/runs/974323894) now finds system giac 1.5.0.85, all tests pass

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​d1c0f2d

build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​bc8c54f	build/pkgs/python3/patches/cygwin-socket-tcpnodelay-21649.patch: New
​5778922	Merge branch 't/30127/cygwin_minimal__pip_20_1_1_fails_to_install' into t/29541/spkg_configure_m4_for_giac
​bc65004	tox.ini, tox.yml: Add ubuntu-groovy, fedora-33
​def5d4d	Merge branch 't/30339/tox_ini__update_for_latest_ubuntu__fedora_versions' into t/29541/spkg_configure_m4_for_giac
​7240f3d	build/make/Makefile.in: Filter out "-j" from sub-make invocations to avoid excessive parallel load
​5eab5a5	Merge branch 't/30345/build_make_makefile_in__filter_out___j__from_sub_make_invocations_to_avoid_excessive_parallel_load' into t/29541/spkg_configure_m4_for_giac
​cf25b83	Move code for tagging/pushing docker images into tox.ini
​51c6cde	fixup
​231b812	.github-workflows/tox-*.yml: Update similarly
​8a0feee	Merge branch 't/30144/tox_ini___tox_yml__move_code_for_tagging_pushing_docker_images_into_tox_ini' into t/29541/spkg_configure_m4_for_giac

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ec95752	build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6
​2649da3	Merge branch 't/30127/cygwin_minimal__pip_20_1_1_fails_to_install' into t/29541/spkg_configure_m4_for_giac
​b6d16af	Merge branch 't/30339/tox_ini__update_for_latest_ubuntu__fedora_versions' into t/29541/spkg_configure_m4_for_giac
​199b893	Merge branch 't/30345/build_make_makefile_in__filter_out___j__from_sub_make_invocations_to_avoid_excessive_parallel_load' into t/29541/spkg_configure_m4_for_giac
​35f3673	Merge branch 't/30144/tox_ini___tox_yml__move_code_for_tagging_pushing_docker_images_into_tox_ini' into t/29541/spkg_configure_m4_for_giac

[mkoeppe]

Rebased, dropping the merge with the upgrade ticket #29552

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​5efb0d7

GiacElement._latex_: Make array doctest more flexible

[mkoeppe]

Replying to mkoeppe:

archlinux-latest-standard (​https://github.com/mkoeppe/sage/runs/974324005) now finds system giac 1.6.0.7 and reproduces the doctest errors reported in ​https://trac.sagemath.org/ticket/29552#comment:2

ec95752 has changed it so it rejects giac >= 1.6, as can be seen in ​https://github.com/mkoeppe/sage/runs/985886420

The latest commit, 5efb0d7, fixes the doctest error.

Ready for review

[git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​0338556	src/sage/libs/giac/giac.pyx: Update _latex_ doctest
​798f6c2	doctest fixes + __len__ modification for giac 1.5.0.87 behavior with emptylist seq[]
​17bc2e4	sage/libs/giac/giac.pyx: Make _latex_ doctest more flexible
​7d25a4b	Merge branch 'public/29171' of git://trac.sagemath.org/sage into public/29171
​2f528a1	put giac methods in a separate file with doctrings from giac's help
​2e44aa6	remove optional giacpy_sage from multi_polynomial_ideal
​db48d99	add a lazy import for libgiac
​923f8f3	Merge tag '9.2.beta9' into t/29171/public/29171
​911ddfb	GiacElement._latex_: Make array doctest more flexible
​f6e801e	Merge branch 't/29171/public/29171' into t/29541/spkg_configure_m4_for_giac

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ca43ddd	build/pkgs/giac/spkg-configure.m4: New
​64e80ac	build/pkgs/giac/distros: Add debian, fedora, opensuse
​ab410b9	build/pkgs/giac/spkg-configure.m4: Test for giac executable
​83543d0	build/pkgs/giac/distros: Add missing packages
​4cf38df	build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6

[mkoeppe]

Rebased, needs review

[charpent]

On Debian testing, installing xcas, libgiac (and their dependencies) is not detected by ./configure. From config.log :

configure:35644: result: giac-1.5.0.87p0:                             does not support check for system package; will be installed as an SPKG

==>needs_work

[dimpase]

I suppose you need libgiac-dev, not just libgiac.

​https://packages.debian.org/sid/libgiac-dev

[charpent]

Replying to dimpase:

I suppose you need libgiac-dev, not just libgiac.

That's what I installed (and typoed when typing my answer... ;-).

So, still needs_work...

[mkoeppe]

does not support check for system package

If you want to test this ticket, you need to use ./bootstrap

[isuruf]

This looks good to me. Can you add giac to distros/conda.txt? You can set it to positive review afterwards.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​0df15df

build/pkgs/giac/distros/conda.txt: New

[mkoeppe]

Thanks!