Opened 2 years ago
Closed 2 years ago
#29541 closed enhancement (fixed)
spkg-configure.m4 for giac
Reported by: | gh-thierry-FreeBSD | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | build: configure | Keywords: | spkg-configure giac |
Cc: | dimpase, mjo, fbissey, frederichan, parisse, gh-sheerluck, arojas, gh-kliem, thansen | Merged in: | |
Authors: | Thierry Thomas, Matthias Koeppe | Reviewers: | Isuru Fernando |
Report Upstream: | N/A | Work issues: | |
Branch: | 0df15df (Commits, GitHub, GitLab) | Commit: | 0df15df93e049a8383d0e49bc2af06f618a42cc3 |
Dependencies: | Stopgaps: |
Description (last modified by )
This ticket adds an spkg-configure.m4 for giac, in order to use it from a system package if possible.
https://repology.org/project/giac/versions
See also:
- #30537 Upgrade giac to 1.6.0-7
Attachments (1)
Change History (49)
Changed 2 years ago by
comment:1 Changed 2 years ago by
- Milestone changed from sage-9.1 to sage-9.2
comment:2 Changed 2 years ago by
- Cc dimpase mjo added
comment:3 Changed 2 years ago by
- Cc fbissey added
- Description modified (diff)
comment:4 Changed 2 years ago by
- Cc frederichan parisse added
Do we know which versions of system giac are acceptable? According to our update tickets (see #29552) >= 1.5.0-63 and < 1.6 are fine.
What does the check for ConvertUTF16toUTF8
in the proposed spkg-configure.m4
test? Does this test for a minimum version?
Is there a way to test the patchlevel of giac? giac --version
does not include this information.
comment:5 Changed 2 years ago by
comment:6 Changed 2 years ago by
- Branch set to u/mkoeppe/spkg_configure_m4_for_giac
comment:7 Changed 2 years ago by
- Commit set to 43ee06bc9c733c64fb3c9eaa41f3db259c326846
Branch pushed to git repo; I updated commit sha1. New commits:
43ee06b | build/pkgs/giac/distros: Add debian, fedora, opensuse
|
comment:8 Changed 2 years ago by
- Reviewers set to github.com/mkoeppe/sage/actions/runs/203238491
comment:9 follow-up: ↓ 13 Changed 2 years ago by
ubuntu-focal-standard
(https://github.com/mkoeppe/sage/runs/969005184), debian-bullseye-standard
: pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac.
So some package is still missing
comment:10 follow-up: ↓ 14 Changed 2 years ago by
fedora-32-standard
(https://github.com/mkoeppe/sage/runs/969005556):
Checking whether SageMath should install SPKG giac... checking whether any of pari is installed as or will be installed as SPKG... no checking giac/giac.h usability... no checking giac/giac.h presence... no checking for giac/giac.h... no configure: no suitable system package found for SPKG giac
comment:11 Changed 2 years ago by
- Cc gh-sheerluck added
comment:12 follow-up: ↓ 15 Changed 2 years ago by
- Cc arojas added
archlinux-latest-standard
(https://github.com/mkoeppe/sage/runs/969005637):
TypeError: unable to start giac because the command 'giac --sage' failed: The command was not found or was not executable: giac.
comment:13 in reply to: ↑ 9 Changed 2 years ago by
Replying to mkoeppe:
ubuntu-focal-standard
(https://github.com/mkoeppe/sage/runs/969005184),debian-bullseye-standard
:pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac.
So some package is still missing
debian has the giac
executable in package xcas
, which pulls in a lot of dependencies
comment:14 in reply to: ↑ 10 Changed 2 years ago by
Replying to mkoeppe:
fedora-32-standard
(https://github.com/mkoeppe/sage/runs/969005556):
... missing giac-devel
comment:15 in reply to: ↑ 12 Changed 2 years ago by
Replying to mkoeppe:
archlinux-latest-standard
(https://github.com/mkoeppe/sage/runs/969005637):
need package giac
comment:16 Changed 2 years ago by
- Commit changed from 43ee06bc9c733c64fb3c9eaa41f3db259c326846 to 1016934b27eb22ce3c26e78a521751f578bf8b6e
comment:17 Changed 2 years ago by
- Dependencies set to #29552
comment:18 Changed 2 years ago by
- Commit changed from 1016934b27eb22ce3c26e78a521751f578bf8b6e to b4f2434119e95dcc914fa162f6405d111e37ef53
comment:19 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/203238491 to https://github.com/mkoeppe/sage/actions/runs/205036006
comment:20 Changed 2 years ago by
This fixed ubuntu-focal-standard
(https://github.com/mkoeppe/sage/runs/974323603); waiting for other runs to finish.
comment:21 follow-up: ↓ 32 Changed 2 years ago by
archlinux-latest-standard
(https://github.com/mkoeppe/sage/runs/974324005) now finds system giac 1.6.0.7 and reproduces the doctest errors reported in https://trac.sagemath.org/ticket/29552#comment:2
comment:22 Changed 2 years ago by
fedora-32-standard
(https://github.com/mkoeppe/sage/runs/974323894) now finds system giac 1.5.0.85, all tests pass
comment:23 Changed 2 years ago by
- Commit changed from b4f2434119e95dcc914fa162f6405d111e37ef53 to d1c0f2db49cd64bcb9989f72fbd84e1ba5d27fa7
Branch pushed to git repo; I updated commit sha1. New commits:
d1c0f2d | build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6
|
comment:24 Changed 2 years ago by
- Dependencies changed from #29552 to #29552, #30127, #30339, #30345, #30144
comment:25 Changed 2 years ago by
- Commit changed from d1c0f2db49cd64bcb9989f72fbd84e1ba5d27fa7 to 8a0feee1892d227c349d1d6e9ce7a6d45107a453
Branch pushed to git repo; I updated commit sha1. New commits:
bc8c54f | build/pkgs/python3/patches/cygwin-socket-tcpnodelay-21649.patch: New
|
5778922 | Merge branch 't/30127/cygwin_minimal__pip_20_1_1_fails_to_install' into t/29541/spkg_configure_m4_for_giac
|
bc65004 | tox.ini, tox.yml: Add ubuntu-groovy, fedora-33
|
def5d4d | Merge branch 't/30339/tox_ini__update_for_latest_ubuntu__fedora_versions' into t/29541/spkg_configure_m4_for_giac
|
7240f3d | build/make/Makefile.in: Filter out "-j" from sub-make invocations to avoid excessive parallel load
|
5eab5a5 | Merge branch 't/30345/build_make_makefile_in__filter_out___j__from_sub_make_invocations_to_avoid_excessive_parallel_load' into t/29541/spkg_configure_m4_for_giac
|
cf25b83 | Move code for tagging/pushing docker images into tox.ini
|
51c6cde | fixup
|
231b812 | .github-workflows/tox-*.yml: Update similarly
|
8a0feee | Merge branch 't/30144/tox_ini___tox_yml__move_code_for_tagging_pushing_docker_images_into_tox_ini' into t/29541/spkg_configure_m4_for_giac
|
comment:26 Changed 2 years ago by
- Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/205036006 to github.com/mkoeppe/sage/actions/runs/206465268
comment:27 Changed 2 years ago by
- Status changed from new to needs_review
comment:28 Changed 2 years ago by
- Commit changed from 8a0feee1892d227c349d1d6e9ce7a6d45107a453 to 35f3673c9ae0a637dc3721506a4b39c7b28ca291
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ec95752 | build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6
|
2649da3 | Merge branch 't/30127/cygwin_minimal__pip_20_1_1_fails_to_install' into t/29541/spkg_configure_m4_for_giac
|
b6d16af | Merge branch 't/30339/tox_ini__update_for_latest_ubuntu__fedora_versions' into t/29541/spkg_configure_m4_for_giac
|
199b893 | Merge branch 't/30345/build_make_makefile_in__filter_out___j__from_sub_make_invocations_to_avoid_excessive_parallel_load' into t/29541/spkg_configure_m4_for_giac
|
35f3673 | Merge branch 't/30144/tox_ini___tox_yml__move_code_for_tagging_pushing_docker_images_into_tox_ini' into t/29541/spkg_configure_m4_for_giac
|
comment:29 Changed 2 years ago by
- Dependencies changed from #29552, #30127, #30339, #30345, #30144 to #30127, #30339, #30345, #30144
Rebased, dropping the merge with the upgrade ticket #29552
comment:30 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/206465268 to github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334
comment:31 Changed 2 years ago by
- Commit changed from 35f3673c9ae0a637dc3721506a4b39c7b28ca291 to 5efb0d7c3b6d634fb1a1fb85ff58b95b45aee9f6
Branch pushed to git repo; I updated commit sha1. New commits:
5efb0d7 | GiacElement._latex_: Make array doctest more flexible
|
comment:32 in reply to: ↑ 21 Changed 2 years ago by
Replying to mkoeppe:
archlinux-latest-standard
(https://github.com/mkoeppe/sage/runs/974324005) now finds system giac 1.6.0.7 and reproduces the doctest errors reported in https://trac.sagemath.org/ticket/29552#comment:2
ec95752 has changed it so it rejects giac >= 1.6, as can be seen in https://github.com/mkoeppe/sage/runs/985886420
The latest commit, 5efb0d7, fixes the doctest error.
Ready for review
comment:33 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334 to github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334, ...
comment:34 Changed 2 years ago by
- Commit changed from 5efb0d7c3b6d634fb1a1fb85ff58b95b45aee9f6 to f6e801ef6ef32356243ee511b841efbc2d94d906
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0338556 | src/sage/libs/giac/giac.pyx: Update _latex_ doctest
|
798f6c2 | doctest fixes + __len__ modification for giac 1.5.0.87 behavior with emptylist seq[]
|
17bc2e4 | sage/libs/giac/giac.pyx: Make _latex_ doctest more flexible
|
7d25a4b | Merge branch 'public/29171' of git://trac.sagemath.org/sage into public/29171
|
2f528a1 | put giac methods in a separate file with doctrings from giac's help
|
2e44aa6 | remove optional giacpy_sage from multi_polynomial_ideal
|
db48d99 | add a lazy import for libgiac
|
923f8f3 | Merge tag '9.2.beta9' into t/29171/public/29171
|
911ddfb | GiacElement._latex_: Make array doctest more flexible
|
f6e801e | Merge branch 't/29171/public/29171' into t/29541/spkg_configure_m4_for_giac
|
comment:35 Changed 2 years ago by
- Dependencies changed from #30127, #30339, #30345, #30144 to #30127, #30339, #30345, #30144, #29171
comment:36 Changed 2 years ago by
- Commit changed from f6e801ef6ef32356243ee511b841efbc2d94d906 to 4cf38df769c483d69773f080fa15dfd9e91fc9ad
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ca43ddd | build/pkgs/giac/spkg-configure.m4: New
|
64e80ac | build/pkgs/giac/distros: Add debian, fedora, opensuse
|
ab410b9 | build/pkgs/giac/spkg-configure.m4: Test for giac executable
|
83543d0 | build/pkgs/giac/distros: Add missing packages
|
4cf38df | build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6
|
comment:37 Changed 2 years ago by
- Dependencies #30127, #30339, #30345, #30144, #29171 deleted
Rebased, needs review
comment:38 Changed 2 years ago by
- Cc gh-kliem added
comment:39 Changed 2 years ago by
- Status changed from needs_review to needs_work
On Debian testing, installing xcas
, libgiac
(and their dependencies) is not detected by ./configure
. From config.log
:
configure:35644: result: giac-1.5.0.87p0: does not support check for system package; will be installed as an SPKG
==>needs_work
comment:40 follow-up: ↓ 41 Changed 2 years ago by
I suppose you need libgiac-dev
, not just libgiac
.
comment:41 in reply to: ↑ 40 Changed 2 years ago by
Replying to dimpase:
I suppose you need
libgiac-dev
, not justlibgiac
.
That's what I installed (and typoed when typing my answer... ;-).
So, still needs_work
...
comment:42 Changed 2 years ago by
- Status changed from needs_work to needs_review
does not support check for system package
If you want to test this ticket, you need to use ./bootstrap
comment:43 Changed 2 years ago by
- Cc thansen added
comment:44 Changed 2 years ago by
- Description modified (diff)
comment:45 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334, ... to Isuru Fernando
This looks good to me. Can you add giac
to distros/conda.txt
? You can set it to positive review afterwards.
comment:46 Changed 2 years ago by
- Commit changed from 4cf38df769c483d69773f080fa15dfd9e91fc9ad to 0df15df93e049a8383d0e49bc2af06f618a42cc3
Branch pushed to git repo; I updated commit sha1. New commits:
0df15df | build/pkgs/giac/distros/conda.txt: New
|
comment:48 Changed 2 years ago by
- Branch changed from u/mkoeppe/spkg_configure_m4_for_giac to 0df15df93e049a8383d0e49bc2af06f618a42cc3
- Resolution set to fixed
- Status changed from positive_review to closed
spkg-configure.m4 to be put under build/pkgs/giac/