Opened 3 years ago

Closed 3 years ago

#29530 closed enhancement (fixed)

Make Docker images generated by GitHub CI workflows available; minor CI fixes

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: porting Keywords: ci, docker, ContinuousIntegration
Cc: gh-kliem, vbraun, dimpase, embray, saraedum, slelievre Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 163562d (Commits, GitHub, GitLab) Commit: 163562d24508d81271a0333c131c13020a052856
Dependencies: #29341, #29534 Stopgaps:

Status badges

Description (last modified by mkoeppe)

They are already tagged with meaningful names and just need to be pushed to a registry.

Now we push them to the registry provided by GitHub. Example: https://github.com/mkoeppe/sage/runs/604103405 created https://github.com/mkoeppe/sage/packages/193111

Change History (28)

comment:1 Changed 3 years ago by slelievre

Cc: embray saraedum slelievre added
Keywords: ci docker added

comment:2 Changed 3 years ago by mkoeppe

Description: modified (diff)

comment:3 Changed 3 years ago by dimpase

will it be possible to pull an image for letting cal inspection and debugging? cool. (currently building a fedora 28 image locally...)

comment:4 Changed 3 years ago by mkoeppe

Dependencies: #29341

comment:5 Changed 3 years ago by mkoeppe

Keywords: ContinuousIntegration added

comment:6 Changed 3 years ago by mkoeppe

Dependencies: #29341#29341, #29534
Description: modified (diff)

comment:7 in reply to:  3 Changed 3 years ago by mkoeppe

Replying to dimpase:

will it be possible to pull an image for ... inspection and debugging?

Yes, that's the idea

comment:8 Changed 3 years ago by mkoeppe

Branch: u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available

comment:9 Changed 3 years ago by git

Commit: d6b64ba3e7f7c07ec91c8538d191bb77e9b01518

Branch pushed to git repo; I updated commit sha1. New commits:

e506503Add documentation
d6b64batox-optional.yml: Push the docker images

comment:10 Changed 3 years ago by mkoeppe

Authors: Matthias Koeppe
Description: modified (diff)
Status: newneeds_review

comment:11 Changed 3 years ago by git

Commit: d6b64ba3e7f7c07ec91c8538d191bb77e9b0151806a9c3946d7e3b2cba0fa0bbfd4d87cb3639c949

Branch pushed to git repo; I updated commit sha1. New commits:

06a9c39fixup doc

comment:12 Changed 3 years ago by git

Commit: 06a9c3946d7e3b2cba0fa0bbfd4d87cb3639c94902f86f661f7b3985dbfc06d05a429910c524adff

Branch pushed to git repo; I updated commit sha1. New commits:

02f86f6tox*.yml: First try secrets.DOCKER_PKG_GITHUB_TOKEN, then secrets.GITHUB_TOKEN; ignore errors

comment:13 Changed 3 years ago by git

Commit: 02f86f661f7b3985dbfc06d05a429910c524adff37c2186db82be211bc96897ddb8dac601b40d34a

Branch pushed to git repo; I updated commit sha1. New commits:

00a82b0Merge tag '9.1.rc1' into t/29530/make_docker_images_generated_by_github_ci_workflows_available
807c2bdFix spelling of --downloadonly
bd687c9Merge branch 't/29403/ci_cygwin_yml__multi_stage_build' into t/29341/optional-test-9.1.rc0
784abe8ci-cygwin.yml: SAGE_FAT_BINARY=yes
eeadb9d.github/workflows/ci-cygwin.yml: Test more optional packages
316c5f6Fixup
37c2186Merge branch 't/29341/optional-test-9.1.rc0' into t/29530/make_docker_images_generated_by_github_ci_workflows_available

comment:14 Changed 3 years ago by git

Commit: 37c2186db82be211bc96897ddb8dac601b40d34a0d886cc5824b7b973875a0bccc5c3a8febc58752

Branch pushed to git repo; I updated commit sha1. New commits:

87210e9.github/workflows/ci-cygwin.yml: Rebalance stages
0d886ccbuild/pkgs/pari_nftables/distros/arch.txt: Remove (package does not exist)

comment:15 Changed 3 years ago by mkoeppe

Summary: Make Docker images generated by GitHub CI workflows availableMake Docker images generated by GitHub CI workflows available; minor CI fixes

comment:16 Changed 3 years ago by git

Commit: 0d886cc5824b7b973875a0bccc5c3a8febc58752652787bd0a1094a08d84a2d6a364b8f7dbdfcc61

Branch pushed to git repo; I updated commit sha1. New commits:

652787b.github/workflows/tox*.yml: Make copying logs from containers more robust

comment:17 Changed 3 years ago by mkoeppe

Status: needs_reviewneeds_work

copying logs needs more work, e.g. https://github.com/mkoeppe/sage/runs/612694530?check_suite_focus=true displays no logs

Last edited 3 years ago by mkoeppe (previous) (diff)

comment:18 Changed 3 years ago by git

Commit: 652787bd0a1094a08d84a2d6a364b8f7dbdfcc612b9f53166dcff1fd4da84f52e5a66e7610cbc432

Branch pushed to git repo; I updated commit sha1. New commits:

2b9f531local-{conda,homebrew}-maximal: Take packages from -standard

comment:19 Changed 3 years ago by git

Commit: 2b9f53166dcff1fd4da84f52e5a66e7610cbc43288b5aa6d4ae024d230835ab6bbc14dd3caa76380

Branch pushed to git repo; I updated commit sha1. New commits:

88b5aa6tox.ini: Commit a failed build container so that logs are copied from it

comment:20 Changed 3 years ago by git

Commit: 88b5aa6d4ae024d230835ab6bbc14dd3caa76380f8c6e7a30e822fcd6a0b7690db5bbb7d8fc1fde4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f8c6e7atox.ini: Commit a failed build container so that logs are copied from it

comment:21 Changed 3 years ago by git

Commit: f8c6e7a30e822fcd6a0b7690db5bbb7d8fc1fde44f4fe609ce1fe22a543cdbed3d798d129db4c9b8

Branch pushed to git repo; I updated commit sha1. New commits:

5c8e685tox-optional.yml: Fix likewise
4f4fe60ci-cygwin.yml: Split the file so that unrelated stages do not wait

comment:22 Changed 3 years ago by mkoeppe

Status: needs_workneeds_review

comment:23 Changed 3 years ago by git

Commit: 4f4fe609ce1fe22a543cdbed3d798d129db4c9b827c63f19bdfc6ef314cb0007a65daa192bb1c499

Branch pushed to git repo; I updated commit sha1. New commits:

27c63f1Improve docker login instructions

comment:24 Changed 3 years ago by git

Commit: 27c63f19bdfc6ef314cb0007a65daa192bb1c499dbf461da6562dae7312ab0c1fb025c5de5babeb8

Branch pushed to git repo; I updated commit sha1. New commits:

dbf461dMerge tag '9.1.rc2' into t/29530/make_docker_images_generated_by_github_ci_workflows_available

comment:25 Changed 3 years ago by git

Commit: dbf461da6562dae7312ab0c1fb025c5de5babeb8163562d24508d81271a0333c131c13020a052856

Branch pushed to git repo; I updated commit sha1. New commits:

163562dRename cygwin workflows

comment:26 Changed 3 years ago by dimpase

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

OK, this looks nice now. I have tested just one docker image, but I trust this should be fine in general.

comment:27 Changed 3 years ago by mkoeppe

Thank you!

comment:28 Changed 3 years ago by vbraun

Branch: u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available163562d24508d81271a0333c131c13020a052856
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.