Opened 3 years ago
Closed 3 years ago
#29530 closed enhancement (fixed)
Make Docker images generated by GitHub CI workflows available; minor CI fixes
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | porting | Keywords: | ci, docker, ContinuousIntegration |
Cc: | gh-kliem, vbraun, dimpase, embray, saraedum, slelievre | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 163562d (Commits, GitHub, GitLab) | Commit: | 163562d24508d81271a0333c131c13020a052856 |
Dependencies: | #29341, #29534 | Stopgaps: |
Description (last modified by )
They are already tagged with meaningful names and just need to be pushed to a registry.
Now we push them to the registry provided by GitHub. Example: https://github.com/mkoeppe/sage/runs/604103405 created https://github.com/mkoeppe/sage/packages/193111
Change History (28)
comment:1 Changed 3 years ago by
Cc: | embray saraedum slelievre added |
---|---|
Keywords: | ci docker added |
comment:2 Changed 3 years ago by
Description: | modified (diff) |
---|
comment:3 follow-up: 7 Changed 3 years ago by
comment:4 Changed 3 years ago by
Dependencies: | → #29341 |
---|
comment:5 Changed 3 years ago by
Keywords: | ContinuousIntegration added |
---|
comment:6 Changed 3 years ago by
Dependencies: | #29341 → #29341, #29534 |
---|---|
Description: | modified (diff) |
comment:7 Changed 3 years ago by
Replying to dimpase:
will it be possible to pull an image for ... inspection and debugging?
Yes, that's the idea
comment:8 Changed 3 years ago by
Branch: | → u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available |
---|
comment:9 Changed 3 years ago by
Commit: | → d6b64ba3e7f7c07ec91c8538d191bb77e9b01518 |
---|
comment:10 Changed 3 years ago by
Authors: | → Matthias Koeppe |
---|---|
Description: | modified (diff) |
Status: | new → needs_review |
comment:11 Changed 3 years ago by
Commit: | d6b64ba3e7f7c07ec91c8538d191bb77e9b01518 → 06a9c3946d7e3b2cba0fa0bbfd4d87cb3639c949 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
06a9c39 | fixup doc
|
comment:12 Changed 3 years ago by
Commit: | 06a9c3946d7e3b2cba0fa0bbfd4d87cb3639c949 → 02f86f661f7b3985dbfc06d05a429910c524adff |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
02f86f6 | tox*.yml: First try secrets.DOCKER_PKG_GITHUB_TOKEN, then secrets.GITHUB_TOKEN; ignore errors
|
comment:13 Changed 3 years ago by
Commit: | 02f86f661f7b3985dbfc06d05a429910c524adff → 37c2186db82be211bc96897ddb8dac601b40d34a |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
00a82b0 | Merge tag '9.1.rc1' into t/29530/make_docker_images_generated_by_github_ci_workflows_available
|
807c2bd | Fix spelling of --downloadonly
|
bd687c9 | Merge branch 't/29403/ci_cygwin_yml__multi_stage_build' into t/29341/optional-test-9.1.rc0
|
784abe8 | ci-cygwin.yml: SAGE_FAT_BINARY=yes
|
eeadb9d | .github/workflows/ci-cygwin.yml: Test more optional packages
|
316c5f6 | Fixup
|
37c2186 | Merge branch 't/29341/optional-test-9.1.rc0' into t/29530/make_docker_images_generated_by_github_ci_workflows_available
|
comment:14 Changed 3 years ago by
Commit: | 37c2186db82be211bc96897ddb8dac601b40d34a → 0d886cc5824b7b973875a0bccc5c3a8febc58752 |
---|
comment:15 Changed 3 years ago by
Summary: | Make Docker images generated by GitHub CI workflows available → Make Docker images generated by GitHub CI workflows available; minor CI fixes |
---|
comment:16 Changed 3 years ago by
Commit: | 0d886cc5824b7b973875a0bccc5c3a8febc58752 → 652787bd0a1094a08d84a2d6a364b8f7dbdfcc61 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
652787b | .github/workflows/tox*.yml: Make copying logs from containers more robust
|
comment:17 Changed 3 years ago by
Status: | needs_review → needs_work |
---|
copying logs needs more work, e.g. https://github.com/mkoeppe/sage/runs/612694530?check_suite_focus=true displays no logs
comment:18 Changed 3 years ago by
Commit: | 652787bd0a1094a08d84a2d6a364b8f7dbdfcc61 → 2b9f53166dcff1fd4da84f52e5a66e7610cbc432 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
2b9f531 | local-{conda,homebrew}-maximal: Take packages from -standard
|
comment:19 Changed 3 years ago by
Commit: | 2b9f53166dcff1fd4da84f52e5a66e7610cbc432 → 88b5aa6d4ae024d230835ab6bbc14dd3caa76380 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
88b5aa6 | tox.ini: Commit a failed build container so that logs are copied from it
|
comment:20 Changed 3 years ago by
Commit: | 88b5aa6d4ae024d230835ab6bbc14dd3caa76380 → f8c6e7a30e822fcd6a0b7690db5bbb7d8fc1fde4 |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
f8c6e7a | tox.ini: Commit a failed build container so that logs are copied from it
|
comment:21 Changed 3 years ago by
Commit: | f8c6e7a30e822fcd6a0b7690db5bbb7d8fc1fde4 → 4f4fe609ce1fe22a543cdbed3d798d129db4c9b8 |
---|
comment:22 Changed 3 years ago by
Status: | needs_work → needs_review |
---|
comment:23 Changed 3 years ago by
Commit: | 4f4fe609ce1fe22a543cdbed3d798d129db4c9b8 → 27c63f19bdfc6ef314cb0007a65daa192bb1c499 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
27c63f1 | Improve docker login instructions
|
comment:24 Changed 3 years ago by
Commit: | 27c63f19bdfc6ef314cb0007a65daa192bb1c499 → dbf461da6562dae7312ab0c1fb025c5de5babeb8 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
dbf461d | Merge tag '9.1.rc2' into t/29530/make_docker_images_generated_by_github_ci_workflows_available
|
comment:25 Changed 3 years ago by
Commit: | dbf461da6562dae7312ab0c1fb025c5de5babeb8 → 163562d24508d81271a0333c131c13020a052856 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
163562d | Rename cygwin workflows
|
comment:26 Changed 3 years ago by
Reviewers: | → Dima Pasechnik |
---|---|
Status: | needs_review → positive_review |
OK, this looks nice now. I have tested just one docker image, but I trust this should be fine in general.
comment:28 Changed 3 years ago by
Branch: | u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available → 163562d24508d81271a0333c131c13020a052856 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
will it be possible to pull an image for letting cal inspection and debugging? cool. (currently building a fedora 28 image locally...)